ODFstudio/odfstudio
2
0
Fork 0
Code Issues Packages Activity

Simplify Sequence iterations in UnoControls

Browse Source 
Use range-based loops

Change-Id: I4d3be75bb83c74267b9dec6f1dcdc105c292be9d
Reviewed-on: https://gerrit.libreoffice.org/72011
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
This commit is contained in:
Arkadiy Illarionov
2019-05-09 08:48:32 +02:00
committed by Noel Grandin
parent e0382c3ad7
commit a11572dc2e
2 changed files with 6 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
UnoControls/source/base/basecontainercontrol.cxx
+2 -3
View File
@@ -117,11 +117,10 @@ void SAL_CALL BaseContainerControl::createPeer( const Reference< XToolkit >&
// create peers at all children
Sequence< Reference< XControl > > seqControlList = getControls();
sal_uInt32 nControls = seqControlList.getLength();
for ( sal_uInt32 n=0; n<nControls; n++ )
for ( auto& rxControl : seqControlList )
{
seqControlList.getArray()[n]->createPeer( xToolkit, getPeer() );
rxControl->createPeer( xToolkit, getPeer() );
}
}
}
UnoControls/source/base/multiplexer.cxx
+4 -8
View File
@@ -156,22 +156,18 @@ void OMRCListenerMultiplexerHelper::setPeer( const Reference< XWindow >& xPeer )
{
// get all types from the listener added to the peer
Sequence< Type > aContainedTypes = m_aListenerHolder.getContainedTypes();
const Type* pArray = aContainedTypes.getConstArray();
sal_Int32 nCount = aContainedTypes.getLength();
// loop over all listener types and remove the listeners from the peer
for( sal_Int32 i=0; i<nCount; i++ )
impl_unadviseFromPeer( m_xPeer, pArray[i] );
for( const auto& rContainedType : aContainedTypes )
impl_unadviseFromPeer( m_xPeer, rContainedType );
}
m_xPeer = xPeer;
if( m_xPeer.is() )
{
// get all types from the listener added to the peer
Sequence< Type > aContainedTypes = m_aListenerHolder.getContainedTypes();
const Type* pArray = aContainedTypes.getConstArray();
sal_Int32 nCount = aContainedTypes.getLength();
// loop over all listener types and add the listeners to the peer
for( sal_Int32 i = 0; i < nCount; i++ )
impl_adviseToPeer( m_xPeer, pArray[i] );
for( const auto& rContainedType : aContainedTypes )
impl_adviseToPeer( m_xPeer, rContainedType );
}
}
}