Remove unneeded breaks

Extending this:
https://gerrit.libreoffice.org/c/core/+/110512

Change-Id: If7e6f9c4079c2e0b48e642aa0b140fb4e03996bf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110520
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
This commit is contained in:
Andrea Gelmini
2021-02-10 08:52:11 +01:00
committed by Stephan Bergmann
parent b7189e1a9a
commit 974dc88a06
13 changed files with 0 additions and 96 deletions
@@ -113,7 +113,6 @@ namespace
break;
default:
return false;
break;
}
}
return true;
@@ -291,7 +291,6 @@ OUString ChartController::GetContextName()
{
case OBJECTTYPE_DATA_SERIES:
return "Series";
break;
case OBJECTTYPE_DATA_ERRORS_X:
case OBJECTTYPE_DATA_ERRORS_Y:
case OBJECTTYPE_DATA_ERRORS_Z:
-14
View File
@@ -242,46 +242,32 @@ namespace comphelper
return ScalarPredicateLess< sal_Unicode >().isLess(lhs, rhs);
case TypeClass_BOOLEAN:
return ScalarPredicateLess< bool >().isLess(lhs, rhs);
break;
case TypeClass_BYTE:
return ScalarPredicateLess< sal_Int8 >().isLess(lhs, rhs);
break;
case TypeClass_SHORT:
return ScalarPredicateLess< sal_Int16 >().isLess(lhs, rhs);
break;
case TypeClass_UNSIGNED_SHORT:
return ScalarPredicateLess< sal_uInt16 >().isLess(lhs, rhs);
break;
case TypeClass_LONG:
return ScalarPredicateLess< sal_Int32 >().isLess(lhs, rhs);
break;
case TypeClass_UNSIGNED_LONG:
return ScalarPredicateLess< sal_uInt32 >().isLess(lhs, rhs);
break;
case TypeClass_HYPER:
return ScalarPredicateLess< sal_Int64 >().isLess(lhs, rhs);
break;
case TypeClass_UNSIGNED_HYPER:
return ScalarPredicateLess< sal_uInt64 >().isLess(lhs, rhs);
break;
case TypeClass_FLOAT:
return ScalarPredicateLess< float >().isLess(lhs, rhs);
break;
case TypeClass_DOUBLE:
return ScalarPredicateLess< double >().isLess(lhs, rhs);
break;
case TypeClass_STRING:
return StringPredicateLess().isLess(lhs, rhs);
break;
case TypeClass_TYPE:
return TypePredicateLess().isLess(lhs, rhs);
break;
case TypeClass_ENUM:
return EnumPredicateLess( lhs.getValueType() ).isLess(lhs, rhs);
break;
case TypeClass_INTERFACE:
return InterfacePredicateLess().isLess(lhs, rhs);
break;
case TypeClass_STRUCT:
if ( lhs.getValueType().equals( ::cppu::UnoType< Date >::get() ) )
return DatePredicateLess().isLess(lhs, rhs);
@@ -784,7 +784,6 @@ bool OFlatTable::seekRow(IResultSetHelper::Movement eCursorPosition, sal_Int32 n
}
// m_nMaxRowCount can still be zero, but now it means there a genuinely zero rows in the table
return seekRow(IResultSetHelper::ABSOLUTE1, m_nMaxRowCount, nCurPos);
break;
case IResultSetHelper::RELATIVE1:
{
const sal_Int32 nNewRowPos = m_nRowPos + nOffset;
@@ -42,19 +42,14 @@ static OUString lcl_activeAppName(vcl::EnumContext::Application eApp)
{
case vcl::EnumContext::Application::Writer:
return "ActiveWriter";
break;
case vcl::EnumContext::Application::Calc:
return "ActiveCalc";
break;
case vcl::EnumContext::Application::Impress:
return "ActiveImpress";
break;
case vcl::EnumContext::Application::Draw:
return "ActiveDraw";
break;
default:
return OUString();
break;
}
}
@@ -64,19 +59,14 @@ static OUString lcl_getAppName(vcl::EnumContext::Application eApp)
{
case vcl::EnumContext::Application::Writer:
return "Writer";
break;
case vcl::EnumContext::Application::Calc:
return "Calc";
break;
case vcl::EnumContext::Application::Impress:
return "Impress";
break;
case vcl::EnumContext::Application::Draw:
return "Draw";
break;
default:
return OUString();
break;
}
}
@@ -205,7 +205,6 @@ SvXMLStyleContext *OTableStylesContext::CreateStyleStyleChildContext(
case XmlStyleFamily::TABLE_COLUMN:
case XmlStyleFamily::TABLE_CELL:
return new OTableStyleContext( GetOwnImport(), *this, nFamily );
break;
default: break;
}
-5
View File
@@ -402,12 +402,10 @@ public:
case XML_ELEMENT(OOO, XML_STYLES):
rImport.GetProgressBarHelper()->Increment( PROGRESS_BAR_STEP );
return rImport.CreateStylesContext(false);
break;
case XML_ELEMENT(OFFICE, XML_AUTOMATIC_STYLES):
case XML_ELEMENT(OOO, XML_AUTOMATIC_STYLES):
rImport.GetProgressBarHelper()->Increment( PROGRESS_BAR_STEP );
return rImport.CreateStylesContext(true);
break;
}
return nullptr;
}
@@ -454,15 +452,12 @@ public:
case XML_ELEMENT(OFFICE, XML_BODY):
case XML_ELEMENT(OOO, XML_BODY):
return new DBXMLDocumentBodyContext(rImport);
break;
case XML_ELEMENT(OFFICE, XML_SCRIPTS):
return new XMLScriptContext(GetImport(), rImport.GetModel());
break;
case XML_ELEMENT(OFFICE, XML_AUTOMATIC_STYLES):
case XML_ELEMENT(OOO, XML_AUTOMATIC_STYLES):
rImport.GetProgressBarHelper()->Increment( PROGRESS_BAR_STEP );
return rImport.CreateStylesContext(true);
break;
default: break;
}
return nullptr;
-1
View File
@@ -1441,7 +1441,6 @@ bool SvxBoxItem::QueryValue( uno::Any& rVal, sal_uInt8 nMemberId ) const
// it doesn't make sense to return a value for these since it's
// probably ambiguous
return true;
break;
}
if( bDistMember )
@@ -58,7 +58,6 @@ namespace
case 8:
case 24:
return true;
break;
default:
break;
}
-1
View File
@@ -2127,7 +2127,6 @@ static void lcl_Rotate(Degree100 nAngle, Point center, Point& pt)
break;
default:
return;
break;
}
sal_Int32 x0 =pt.X()-center.X();
sal_Int32 y0 =pt.Y()-center.Y();
@@ -3031,7 +3031,6 @@ LanguageTag makeLanguageTagFromAppleLanguageId(AppleLanguageId nLanguage)
break;
case AppleLanguageId::AZERI_ARABIC:
return LanguageTag("az-Arab");
break;
case AppleLanguageId::ARMENIAN:
nLang = LANGUAGE_ARMENIAN;
break;
@@ -3154,7 +3153,6 @@ LanguageTag makeLanguageTagFromAppleLanguageId(AppleLanguageId nLanguage)
break;
case AppleLanguageId::RUNDI:
return LanguageTag("rn");
break;
case AppleLanguageId::NYANJA:
nLang = LANGUAGE_USER_NYANJA;
break;
@@ -3184,7 +3182,6 @@ LanguageTag makeLanguageTagFromAppleLanguageId(AppleLanguageId nLanguage)
break;
case AppleLanguageId::AYMARA:
return LanguageTag("ay");
break;
case AppleLanguageId::TATAR:
nLang = LANGUAGE_TATAR;
break;
@@ -3196,10 +3193,8 @@ LanguageTag makeLanguageTagFromAppleLanguageId(AppleLanguageId nLanguage)
break;
case AppleLanguageId::JAVANESE_LATIN:
return LanguageTag("jv-Latn");
break;
case AppleLanguageId::SUNDANESE_LATIN:
return LanguageTag("su-Latn");
break;
case AppleLanguageId::GALICIAN:
nLang = LANGUAGE_GALICIAN;
break;
@@ -3220,7 +3215,6 @@ LanguageTag makeLanguageTagFromAppleLanguageId(AppleLanguageId nLanguage)
break;
case AppleLanguageId::IRISH_GAELIC_WITH_DOT_ABOVE:
return LanguageTag("ga-Latg");
break;
case AppleLanguageId::TONGAN:
return LanguageTag("to");
break;
@@ -92,58 +92,40 @@ OUString GetUnderlineName(enumXFUnderline type)
{
case enumXFUnderlineNone:
return "none";
break;
case enumXFUnderlineSingle:
return "single";
break;
case enumXFUnderlineDouble:
return "double";
break;
case enumXFUnderlineDotted:
return "dotted";
break;
case enumXFUnderlineDash:
return "dash";
break;
case enumXFUnderlineLongDash:
return "long-dash";
break;
case enumXFUnderlineDotDash:
return "dot-dash";
break;
case enumXFUnderlineDotDotDash:
return "dot-dot-dash";
break;
case enumXFUnderlineWave:
return "wave";
break;
case enumXFUnderlineBold:
return "bold";
break;
case enumXFUnderlineBoldDotted:
return "bold-dotted";
break;
case enumXFUnderlineBoldDash:
return "bold-dash";
break;
case enumXFUnderlineBoldLongDash:
return "bold-long-dash";
break;
case enumXFUnderlineBoldDotDash:
return "bold-dot-dash";
break;
case enumXFUnderlineBoldDotDotDash:
return "bold-dot-dot-dash";
break;
case enumXFUnderlineBoldWave:
return "bold-wave";
break;
case enumXFUnderlineDoubleWave:
return "double-wave";
break;
case enumXFUnderlineSmallWave:
return "small-wave";
break;
}
return OUString();
}
@@ -154,19 +136,14 @@ OUString GetCrossoutName(enumXFCrossout type)
{
case enumXFCrossoutSignel:
return "single-line";
break;
case enumXFCrossoutDouble:
return "double-line";
break;
case enumXFCrossoutThick:
return "thick-line";
break;
case enumXFCrossoutSlash:
return "slash";
break;
case enumXFCrossoutX:
return "X";
break;
default:
break;
}
@@ -178,16 +155,12 @@ OUString GetTransformName(enumXFTransform type)
switch(type) {
case enumXFTransformUpper:
return "uppercase";
break;
case enumXFTransformLower:
return "lowercase";
break;
case enumXFTransformCapitalize:
return "capitalize";
break;
case enumXFTransformSmallCaps:
return "small-caps";
break;
default:
break;
}
@@ -200,28 +173,20 @@ OUString GetTextDirName(enumXFTextDir dir)
{
case enumXFTextDirLR:
return "lr";
break;
case enumXFTextDirLR_TB:
return "lr-tb";
break;
case enumXFTextDirPage:
return "page";
break;
case enumXFTextDirRL:
return "rl";
break;
case enumXFTextDirRL_TB:
return "rl-tb";
break;
case enumXFTextDirTB:
return "tb";
break;
case enumXFTextDirTB_LR:
return "tb-lr";
break;
case enumXFTextDirTB_RL:
return "tb-rl";
break;
default:
break;
}
@@ -234,16 +199,12 @@ OUString GetFrameXPos(enumXFFrameXPos pos)
{
case enumXFFrameXPosLeft:
return "left";
break;
case enumXFFrameXPosRight:
return "right";
break;
case enumXFFrameXPosCenter:
return "center";
break;
case enumXFFrameXPosFromLeft:
return "from-left";
break;
default:
break;
}
@@ -256,43 +217,30 @@ OUString GetFrameXRel(enumXFFrameXRel rel)
{
case enumXFFrameXRelPage:
return "page";
break;
case enumXFFrameXRelPageContent:
return "page-content";
break;
case enumXFFrameXRelPageEndMargin:
return "page-end-margin";
break;
case enumXFFrameXRelPageStartMargin:
return "page-start-margin";
break;
case enumXFFrameXRelPara:
return "paragraph";
break;
case enumXFFrameXRelParaContent:
return "paragraph-content";
break;
case enumXFFrameXRelParaEndMargin:
return "paragraph-end-margin";
break;
case enumXFFrameXRelParaStartMargin:
return "paragraph-start-margin";
break;
case enumXFFrameXRelChar:
return "char";
break;
case enumXFFrameXRelFrame:
return "frame";
break;
case enumXFFrameXRelFrameContent:
return "frame-content";
break;
case enumXFFrameXRelFrameEndMargin:
return "frame-end-margin";
break;
case enumXFFrameXRelFrameStartMargin:
return "frame-start-margin";
break;
default:
break;
}
@@ -1060,7 +1060,6 @@ bool AccObjectWinManager::IsContainer(XAccessible* pAccessible)
case /*AccessibleRole::*/VIEW_PORT:
case /*AccessibleRole::*/SHAPE:
return true;
break;
case /*AccessibleRole::*/COLUMN_HEADER:
case /*AccessibleRole::*/TABLE:
if(!IsStateManageDescendant(pAccessible))
@@ -1068,7 +1067,6 @@ bool AccObjectWinManager::IsContainer(XAccessible* pAccessible)
break;
case /*AccessibleRole::*/MENU:
return true;
break;
default:
return false;
}