ODFstudio/odfstudio
2
0
Fork 0
Code Issues Packages Activity

cid#1546501 COPY_INSTEAD_OF_MOVE

Browse Source 
and

cid#1546486 COPY_INSTEAD_OF_MOVE
cid#1546485 COPY_INSTEAD_OF_MOVE
cid#1546484 COPY_INSTEAD_OF_MOVE
cid#1546482 COPY_INSTEAD_OF_MOVE

Change-Id: I53cc622f16afc0f57ffd72e3e0a6f18e390fbb83
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160443
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
This commit is contained in:
Caolán McNamara
2023-12-08 09:33:45 +01:00
parent 2f12d5bb9c
commit 950d8b640a
18 changed files with 23 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files
chart2/source/controller/sidebar/ChartAreaPanel.cxx
+1 -1
View File
@@ -512,7 +512,7 @@ void ChartAreaPanel::selectionChanged(bool bCorrectType)
updateData();
}
void ChartAreaPanel::doUpdateModel(rtl::Reference<::chart::ChartModel> xModel)
void ChartAreaPanel::doUpdateModel(const rtl::Reference<::chart::ChartModel>& xModel)
{
if (mbModelValid)
{
chart2/source/controller/sidebar/ChartAreaPanel.hxx
+1 -1
View File
@@ -73,7 +73,7 @@ private:
rtl::Reference<ChartSidebarSelectionListener> mxSelectionListener;
void Initialize();
void doUpdateModel(rtl::Reference<::chart::ChartModel> xModel);
void doUpdateModel(const rtl::Reference<::chart::ChartModel>& xModel);
bool mbUpdate;
bool mbModelValid;
chart2/source/controller/sidebar/ChartAxisPanel.cxx
+1 -1
View File
@@ -300,7 +300,7 @@ void ChartAxisPanel::modelInvalid()
mbModelValid = false;
}
void ChartAxisPanel::doUpdateModel(rtl::Reference<::chart::ChartModel> xModel)
void ChartAxisPanel::doUpdateModel(const rtl::Reference<::chart::ChartModel>& xModel)
{
if (mbModelValid)
{
chart2/source/controller/sidebar/ChartAxisPanel.hxx
+1 -1
View File
@@ -81,7 +81,7 @@ private:
bool mbModelValid;
void Initialize();
void doUpdateModel(rtl::Reference<::chart::ChartModel> xModel);
void doUpdateModel(const rtl::Reference<::chart::ChartModel>& xModel);
DECL_LINK(CheckBoxHdl, weld::Toggleable&, void);
DECL_LINK(ListBoxHdl, weld::ComboBox&, void);
chart2/source/controller/sidebar/ChartElementsPanel.cxx
+1 -1
View File
@@ -557,7 +557,7 @@ void ChartElementsPanel::modelInvalid()
mbModelValid = false;
}
void ChartElementsPanel::doUpdateModel(rtl::Reference<::chart::ChartModel> xModel)
void ChartElementsPanel::doUpdateModel(const rtl::Reference<::chart::ChartModel>& xModel)
{
if (mbModelValid)
{
chart2/source/controller/sidebar/ChartElementsPanel.hxx
+1 -1
View File
@@ -102,7 +102,7 @@ private:
OUString maTextSubTitle;
void Initialize();
void doUpdateModel(rtl::Reference<::chart::ChartModel> xModel);
void doUpdateModel(const rtl::Reference<::chart::ChartModel>& xModel);
void setTitleVisible(TitleHelper::eTitleType eTitle, bool bVisible);
chart2/source/controller/sidebar/ChartErrorBarPanel.cxx
+1 -1
View File
@@ -369,7 +369,7 @@ void ChartErrorBarPanel::modelInvalid()
mbModelValid = false;
}
void ChartErrorBarPanel::doUpdateModel(rtl::Reference<::chart::ChartModel> xModel)
void ChartErrorBarPanel::doUpdateModel(const rtl::Reference<::chart::ChartModel>& xModel)
{
if (mbModelValid)
{
chart2/source/controller/sidebar/ChartErrorBarPanel.hxx
+1 -1
View File
@@ -79,7 +79,7 @@ private:
bool mbModelValid;
void Initialize();
void doUpdateModel(rtl::Reference<::chart::ChartModel> xModel);
void doUpdateModel(const rtl::Reference<::chart::ChartModel>& xModel);
DECL_LINK(RadioBtnHdl, weld::Toggleable&, void);
DECL_LINK(ListBoxHdl, weld::ComboBox&, void);
chart2/source/controller/sidebar/ChartLinePanel.cxx
+1 -1
View File
@@ -196,7 +196,7 @@ void ChartLinePanel::selectionChanged(bool bCorrectType)
updateData();
}
void ChartLinePanel::doUpdateModel(rtl::Reference<::chart::ChartModel> xModel)
void ChartLinePanel::doUpdateModel(const rtl::Reference<::chart::ChartModel>& xModel)
{
if (mbModelValid)
{
chart2/source/controller/sidebar/ChartLinePanel.hxx
+1 -1
View File
@@ -74,7 +74,7 @@ private:
rtl::Reference<ChartSidebarSelectionListener> mxSelectionListener;
void Initialize();
void doUpdateModel(rtl::Reference<::chart::ChartModel> xModel);
void doUpdateModel(const rtl::Reference<::chart::ChartModel>& xModel);
bool mbUpdate;
bool mbModelValid;
chart2/source/controller/sidebar/ChartSeriesPanel.cxx
+1 -1
View File
@@ -400,7 +400,7 @@ void ChartSeriesPanel::modelInvalid()
mbModelValid = false;
}
void ChartSeriesPanel::doUpdateModel(rtl::Reference<::chart::ChartModel> xModel)
void ChartSeriesPanel::doUpdateModel(const rtl::Reference<::chart::ChartModel>& xModel)
{
if (mbModelValid)
{
chart2/source/controller/sidebar/ChartSeriesPanel.hxx
+1 -1
View File
@@ -98,7 +98,7 @@ private:
bool mbModelValid;
void Initialize();
void doUpdateModel(rtl::Reference<::chart::ChartModel> xModel);
void doUpdateModel(const rtl::Reference<::chart::ChartModel>& xModel);
DECL_LINK(CheckBoxHdl, weld::Toggleable&, void);
DECL_LINK(RadioBtnHdl, weld::Toggleable&, void);
chart2/source/controller/sidebar/ChartTypePanel.cxx
+1 -1
View File
@@ -261,7 +261,7 @@ void ChartTypePanel::HandleContextChange(const vcl::EnumContext& rContext)
void ChartTypePanel::modelInvalid() { mbModelValid = false; }
void ChartTypePanel::doUpdateModel(rtl::Reference<::chart::ChartModel> xModel)
void ChartTypePanel::doUpdateModel(const rtl::Reference<::chart::ChartModel>& xModel)
{
if (mbModelValid)
{
chart2/source/controller/sidebar/ChartTypePanel.hxx
+1 -1
View File
@@ -94,7 +94,7 @@ private:
bool mbModelValid;
void Initialize();
void doUpdateModel(rtl::Reference<::chart::ChartModel> xModel);
void doUpdateModel(const rtl::Reference<::chart::ChartModel>& xModel);
std::unique_ptr<Dim3DLookResourceGroup> m_pDim3DLookResourceGroup;
std::unique_ptr<StackingResourceGroup> m_pStackingResourceGroup;
helpcompiler/source/HelpLinker.cxx
+1 -2
View File
@@ -821,12 +821,11 @@ static void StructuredXMLErrorFunction(SAL_UNUSED_PARAMETER void *, const xmlErr
static void StructuredXMLErrorFunction(SAL_UNUSED_PARAMETER void *, xmlErrorPtr error)
#endif
{
std::string aErrorMsg = error->message;
std::string aXMLParsingFile;
if( error->file != nullptr )
aXMLParsingFile = error->file;
int nXMLParsingLine = error->line;
GpXMLParsingException = new HelpProcessingException( aErrorMsg, aXMLParsingFile, nXMLParsingLine );
GpXMLParsingException = new HelpProcessingException(error->message, aXMLParsingFile, nXMLParsingLine);
// Reset error handler
xmlSetStructuredErrorFunc( nullptr, nullptr );
sfx2/source/inet/inettbc.cxx
+4 -5
View File
@@ -145,15 +145,14 @@ void SfxURLToolBoxControl_Impl::OpenURL( const OUString& rName ) const
if ( !xDispatch.is() )
return;
Sequence< PropertyValue > aArgs{
SfxURLToolBoxControl_Impl::ExecuteInfo* pExecuteInfo = new SfxURLToolBoxControl_Impl::ExecuteInfo;
pExecuteInfo->xDispatch = xDispatch;
pExecuteInfo->aTargetURL = aTargetURL;
pExecuteInfo->aArgs = {
comphelper::makePropertyValue("Referer", OUString( "private:user" )),
comphelper::makePropertyValue("FileName", aName)
};
SfxURLToolBoxControl_Impl::ExecuteInfo* pExecuteInfo = new SfxURLToolBoxControl_Impl::ExecuteInfo;
pExecuteInfo->xDispatch = xDispatch;
pExecuteInfo->aTargetURL = aTargetURL;
pExecuteInfo->aArgs = aArgs;
Application::PostUserEvent( LINK( nullptr, SfxURLToolBoxControl_Impl, ExecuteHdl_Impl), pExecuteInfo );
}
svx/source/accessibility/svxrectctaccessiblecontext.cxx
+2 -4
View File
@@ -148,13 +148,11 @@ Reference< XAccessible > SAL_CALL SvxRectCtlAccessibleContext::getAccessibleChil
if (!xChild.is() && mpRepr)
{
const ChildIndexToPointData* p = IndexToPoint( nIndex );
OUString aName(SvxResId(p->pResIdName));
OUString aDescr(SvxResId(p->pResIdDescr));
tools::Rectangle aFocusRect( mpRepr->CalculateFocusRectangle( p->ePoint ) );
rtl::Reference<SvxRectCtlChildAccessibleContext> pChild = new SvxRectCtlChildAccessibleContext(this, aName,
aDescr, aFocusRect, nIndex );
rtl::Reference<SvxRectCtlChildAccessibleContext> pChild = new SvxRectCtlChildAccessibleContext(this,
SvxResId(p->pResIdName), SvxResId(p->pResIdDescr), aFocusRect, nIndex );
mvChildren[ nIndex ] = pChild;
xChild = pChild;
writerfilter/source/dmapper/TableManager.hxx
+2 -2
View File
@@ -121,7 +121,7 @@ class TableManager : public virtual SvRefBase
mpCellProps.clear();
}
void setCellProps(TablePropertyMapPtr pProps)
void setCellProps(const TablePropertyMapPtr& pProps)
{
mpCellProps = pProps;
}
@@ -150,7 +150,7 @@ class TableManager : public virtual SvRefBase
return mpRowProps;
}
void setTableExceptionProps(TablePropertyMapPtr pProps)
void setTableExceptionProps(const TablePropertyMapPtr& pProps)
{
mpTableExceptionProps = pProps;
// set table exception properties of the first cell