ODFstudio/odfstudio
2
0
Fork 0
Code Issues Packages Activity

loplugin:checkunusedparams in hwpfilter..lotuswordpro

Browse Source 
Change-Id: I4925a95cc74571c2e0ffd413d7ac8bc162c247d7
Reviewed-on: https://gerrit.libreoffice.org/37143
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
This commit is contained in:
Noel Grandin
2017-05-02 12:16:54 +02:00
parent 2859c2541d
commit 9297aa2c08
12 changed files with 28 additions and 47 deletions
Download Patch File Download Diff File Expand all files Collapse all files
hwpfilter/source/hwpreader.cxx
+4 -8
View File
@@ -3005,7 +3005,7 @@ void HwpReader::make_text_p3(HWPPara * para,bool bParaStart)
if( !tstart ) {STARTT;}
makeChars(str);
}
makeTab(static_cast<Tab*>(para->hhstr[n].get()));
makeTab();
break;
case CH_TEXT_BOX: /* 10 - ordered by Table/text box/formula/button/hypertext */
{
@@ -3066,7 +3066,6 @@ void HwpReader::make_text_p3(HWPPara * para,bool bParaStart)
}
case CH_LINE: // 14
{
Line *hbox = static_cast<Line*>(para->hhstr[n].get());
if (str.size() > 0)
{
if( !pstart ) {STARTP;}
@@ -3075,7 +3074,7 @@ void HwpReader::make_text_p3(HWPPara * para,bool bParaStart)
}
if( tstart ) {ENDT;}
if( pstart ) {ENDP;}
makeLine(hbox);
makeLine();
pstart = true;
break;
}
@@ -3447,7 +3446,7 @@ void HwpReader::makeDateCode(DateCode * hbox)
}
void HwpReader::makeTab(Tab * ) /*hbox */
void HwpReader::makeTab()
{
rstartEl("text:tab-stop", mxList.get());
rendEl("text:tab-stop");
@@ -4582,10 +4581,7 @@ void HwpReader::makePictureDRAW(HWPDrawingObject *drawobj, Picture * hbox)
}
/**
*
*/
void HwpReader::makeLine(Line * )
void HwpReader::makeLine()
{
padd("text:style-name", sXML_CDATA, "Horizontal Line");
rstartEl( "text:p", mxList.get());
hwpfilter/source/hwpreader.hxx
+2 -2
View File
@@ -120,14 +120,14 @@ private:
void makeBookmark(Bookmark *hbox); //6
void makeDateFormat(DateCode *hbox); //7
void makeDateCode(DateCode *hbox); //8
void makeTab(Tab *hbox); //9
void makeTab(); //9
void makeTable(TxtBox *hbox);
void makeTextBox(TxtBox *hbox);
void makeFormula(TxtBox *hbox);
void makeHyperText(TxtBox *hbox);
void makePicture(Picture *hbox);
void makePictureDRAW(HWPDrawingObject *drawobj, Picture *hbox);
void makeLine(Line *hbox);
void makeLine();
void makeHidden(Hidden *hbox);
void makeFootnote(Footnote *hbox);
void makeAutoNum(AutoNum *hbox);
linguistic/source/convdiclist.cxx
+1 -1
View File
@@ -568,7 +568,7 @@ uno::Reference< uno::XInterface > SAL_CALL ConvDicList_CreateInstance(
void * SAL_CALL ConvDicList_getFactory(
const sal_Char * pImplName,
XMultiServiceFactory * pServiceManager, void * )
XMultiServiceFactory * pServiceManager )
{
void * pRet = nullptr;
if ( ConvDicList::getImplementationName_Static().equalsAscii( pImplName ) )
linguistic/source/dlistimp.cxx
+4 -7
View File
@@ -89,8 +89,7 @@ public:
void DisposeAndClear( const EventObject &rEvtObj );
bool AddDicListEvtListener(
const uno::Reference< XDictionaryListEventListener >& rxListener,
bool bReceiveVerbose );
const uno::Reference< XDictionaryListEventListener >& rxListener );
bool RemoveDicListEvtListener(
const uno::Reference< XDictionaryListEventListener >& rxListener );
sal_Int16 BeginCollectEvents() { return ++nNumCollectEvtListeners;}
@@ -203,8 +202,7 @@ void SAL_CALL DicEvtListenerHelper::processDictionaryEvent(
bool DicEvtListenerHelper::AddDicListEvtListener(
const uno::Reference< XDictionaryListEventListener >& xListener,
bool /*bReceiveVerbose*/ )
const uno::Reference< XDictionaryListEventListener >& xListener )
{
DBG_ASSERT( xListener.is(), "empty reference" );
sal_Int32 nCount = aDicListEvtListeners.getLength();
@@ -474,8 +472,7 @@ sal_Bool SAL_CALL DicList::addDictionaryListEventListener(
bool bRes = false;
if (xListener.is()) //! don't add empty references
{
bRes = mxDicEvtLstnrHelper->
AddDicListEvtListener( xListener, bReceiveVerbose );
bRes = mxDicEvtLstnrHelper->AddDicListEvtListener( xListener );
}
return bRes;
}
@@ -711,7 +708,7 @@ uno::Sequence< OUString > DicList::getSupportedServiceNames_Static() throw()
}
void * SAL_CALL DicList_getFactory( const sal_Char * pImplName,
XMultiServiceFactory * pServiceManager, void * )
XMultiServiceFactory * pServiceManager )
{
void * pRet = nullptr;
if ( DicList::getImplementationName_Static().equalsAscii( pImplName ) )
linguistic/source/gciterator.cxx
+1 -2
View File
@@ -1139,8 +1139,7 @@ static uno::Reference< uno::XInterface > SAL_CALL GrammarCheckingIterator_create
void * SAL_CALL GrammarCheckingIterator_getFactory(
const sal_Char *pImplName,
lang::XMultiServiceFactory *pServiceManager,
void * /*pRegistryKey*/ )
lang::XMultiServiceFactory *pServiceManager )
{
void * pRet = nullptr;
if ( GrammarCheckingIterator_getImplementationName().equalsAscii( pImplName ) )
linguistic/source/lngopt.cxx
+1 -1
View File
@@ -451,7 +451,7 @@ Locale LinguProps::getPropertyLocale(const OUString& aPropertyName)
}
void * SAL_CALL LinguProps_getFactory( const sal_Char * pImplName,
XMultiServiceFactory *pServiceManager, void * )
XMultiServiceFactory *pServiceManager )
{
void * pRet = nullptr;
if ( LinguProps::getImplementationName_Static().equalsAscii( pImplName ) )
linguistic/source/lngreg.cxx
+6 -11
View File
@@ -32,37 +32,32 @@ extern "C"
{
SAL_DLLPUBLIC_EXPORT void * SAL_CALL lng_component_getFactory(
const sal_Char * pImplName, void * pServiceManager, void * pRegistryKey )
const sal_Char * pImplName, void * pServiceManager, void * /*pRegistryKey*/ )
{
void * pRet =
LngSvcMgr_getFactory(
pImplName,
static_cast< XMultiServiceFactory * >( pServiceManager ),
pRegistryKey );
static_cast< XMultiServiceFactory * >( pServiceManager ) );
if(!pRet)
pRet = LinguProps_getFactory(
pImplName,
static_cast< XMultiServiceFactory * >( pServiceManager ),
pRegistryKey );
static_cast< XMultiServiceFactory * >( pServiceManager ) );
if(!pRet)
pRet = DicList_getFactory(
pImplName,
static_cast< XMultiServiceFactory * >( pServiceManager ),
pRegistryKey );
static_cast< XMultiServiceFactory * >( pServiceManager ) );
if(!pRet)
pRet = ConvDicList_getFactory(
pImplName,
static_cast< XMultiServiceFactory * >( pServiceManager ),
pRegistryKey );
static_cast< XMultiServiceFactory * >( pServiceManager ) );
if(!pRet)
pRet = GrammarCheckingIterator_getFactory(
pImplName,
static_cast< XMultiServiceFactory * >( pServiceManager ),
pRegistryKey );
static_cast< XMultiServiceFactory * >( pServiceManager ) );
return pRet;
}
}
linguistic/source/lngreg.hxx
+5 -10
View File
@@ -31,36 +31,31 @@ namespace com { namespace sun { namespace star { namespace lang {
extern void * SAL_CALL LngSvcMgr_getFactory
(
const sal_Char * pImplName,
css::lang::XMultiServiceFactory * pServiceManager,
void * /*pRegistryKey*/
css::lang::XMultiServiceFactory * pServiceManager
);
extern void * SAL_CALL DicList_getFactory
(
const sal_Char * pImplName,
css::lang::XMultiServiceFactory * pServiceManager,
void *
css::lang::XMultiServiceFactory * pServiceManager
);
void * SAL_CALL LinguProps_getFactory
(
const sal_Char * pImplName,
css::lang::XMultiServiceFactory * pServiceManager,
void *
css::lang::XMultiServiceFactory * pServiceManager
);
extern void * SAL_CALL ConvDicList_getFactory
(
const sal_Char * pImplName,
css::lang::XMultiServiceFactory * pServiceManager,
void *
css::lang::XMultiServiceFactory * pServiceManager
);
extern void * SAL_CALL GrammarCheckingIterator_getFactory
(
const sal_Char * pImplName,
css::lang::XMultiServiceFactory * pServiceManager,
void *
css::lang::XMultiServiceFactory * pServiceManager
);
#endif
linguistic/source/lngsvcmgr.cxx
+1 -2
View File
@@ -1988,8 +1988,7 @@ uno::Reference< uno::XInterface > SAL_CALL LngSvcMgr_CreateInstance(
void * SAL_CALL LngSvcMgr_getFactory(
const sal_Char * pImplName,
lang::XMultiServiceFactory * pServiceManager,
void * /*pRegistryKey*/ )
lang::XMultiServiceFactory * pServiceManager )
{
void * pRet = nullptr;
lotuswordpro/source/filter/lwpfribframe.cxx
+1 -1
View File
@@ -228,7 +228,7 @@ void LwpFribRubyFrame::RegisterStyle(LwpFoundry* pFoundry)
* @descr: convert Ruby frame
*
*/
void LwpFribRubyFrame::XFConvert(XFContentContainer* /*pCont*/)
void LwpFribRubyFrame::XFConvert()
{
LwpRubyLayout* pLayout = GetLayout();
if (pLayout)
lotuswordpro/source/filter/lwpfribframe.hxx
+1 -1
View File
@@ -86,7 +86,7 @@ public:
void Read(LwpObjectStream* pObjStrm, sal_uInt16 len) override;
LwpRubyLayout* GetLayout();
void RegisterStyle(LwpFoundry* pFoundry) override;
void XFConvert(XFContentContainer* pCont);
void XFConvert();
private:
LwpObjectID m_objLayout;
};
lotuswordpro/source/filter/lwpfribptr.cxx
+1 -1
View File
@@ -349,7 +349,7 @@ void LwpFribPtr::XFConvert()
case FRIB_TAG_RUBYFRAME:
{
LwpFribRubyFrame* rubyfrmeFrib = static_cast<LwpFribRubyFrame*>(pFrib);
rubyfrmeFrib->XFConvert(m_pXFPara);
rubyfrmeFrib->XFConvert();
break;
}
default :