ODFstudio/odfstudio
2
0
Fork 0
Code Issues Packages Activity

cui: Use weld::Entry member directly in callback

Browse Source 
Use OfaLanguagesTabPage::m_xDatePatternsED instead of the
callback param, as the callback is only connected
for that member.

This prepares for an upcoming commit that will
change the callback param to weld::TextWidget& to
unify/deduplicate the weld::Entry and weld::TextView
implementations.

Change-Id: I186e6f1958d744c78e3ba60fd5fc6f56633407b9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/207935
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
This commit is contained in:
Michael Weghorn
2026-07-10 18:17:15 +02:00
parent 0b091aa5c4
commit 8c2d8e1616
1 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
cui/source/options/optgdlg.cxx
+7 -7
View File
@@ -1517,23 +1517,23 @@ IMPL_LINK_NOARG(OfaLanguagesTabPage, LocaleSettingHdl, weld::ComboBox&, void)
m_xDatePatternsED->set_message_type(weld::EntryMessageType::Normal);
}
IMPL_LINK( OfaLanguagesTabPage, DatePatternsHdl, weld::Entry&, rEd, void )
IMPL_LINK_NOARG(OfaLanguagesTabPage, DatePatternsHdl, weld::Entry&, void)
{
OUString aPatterns(rEd.get_text());
OUString aPatterns(m_xDatePatternsED->get_text());
bool bModified = false;
const bool bValid = validateDatePatterns( bModified, aPatterns);
if (bModified)
{
// gtk3 keeps the cursor position on equal length set_text() but at
// least the 'gen' backend does not and resets to 0.
const int nCursorPos = rEd.get_position();
rEd.set_text(aPatterns);
rEd.set_position(nCursorPos);
const int nCursorPos = m_xDatePatternsED->get_position();
m_xDatePatternsED->set_text(aPatterns);
m_xDatePatternsED->set_position(nCursorPos);
}
if (bValid)
rEd.set_message_type(weld::EntryMessageType::Normal);
m_xDatePatternsED->set_message_type(weld::EntryMessageType::Normal);
else
rEd.set_message_type(weld::EntryMessageType::Error);
m_xDatePatternsED->set_message_type(weld::EntryMessageType::Error);
m_bDatePatternsValid = bValid;
}