ODFstudio/odfstudio
2
0
Fork 0
Code Issues Packages Activity

flatten basctl::docs::DocumentEnumeration

Browse Source 
no need to use pimpl pattern here

Change-Id: I289f545ff237b9770f3a193460a943e91b86fadb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147955
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
This commit is contained in:
Noel Grandin
2023-02-28 11:41:12 +00:00
parent 0bb169dcfa
commit 822cc9e941
2 changed files with 6 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files
basctl/source/basicide/documentenumeration.cxx
+4 -16
View File
@@ -48,22 +48,10 @@ namespace basctl::docs {
namespace FrameSearchFlag = ::com::sun::star::frame::FrameSearchFlag;
// DocumentEnumeration_Data
struct DocumentEnumeration_Data
{
Reference< css::uno::XComponentContext > aContext;
const IDocumentDescriptorFilter* pFilter;
DocumentEnumeration_Data( Reference< css::uno::XComponentContext > const & _rContext, const IDocumentDescriptorFilter* _pFilter )
:aContext( _rContext )
,pFilter( _pFilter )
{
}
};
// DocumentEnumeration
DocumentEnumeration::DocumentEnumeration( Reference< css::uno::XComponentContext > const & _rContext, const IDocumentDescriptorFilter* _pFilter )
:m_pData( new DocumentEnumeration_Data( _rContext, _pFilter ) )
: m_xContext( _rContext )
, m_pFilter( _pFilter )
{
}
@@ -152,11 +140,11 @@ namespace basctl::docs {
try
{
const Reference< XDesktop2 > xDesktop = Desktop::create( m_pData->aContext );
const Reference< XDesktop2 > xDesktop = Desktop::create( m_xContext );
const Reference< XFrames > xFrames( xDesktop->getFrames(), UNO_SET_THROW );
const Sequence< Reference< XFrame > > aFrames( xFrames->queryFrames( FrameSearchFlag::ALL ) );
lcl_getDocuments_nothrow( aFrames, _out_rDocuments, m_pData->pFilter );
lcl_getDocuments_nothrow( aFrames, _out_rDocuments, m_pFilter );
}
catch( const Exception& )
{
basctl/source/basicide/documentenumeration.hxx
+2 -2
View File
@@ -51,7 +51,6 @@ namespace basctl::docs {
};
struct DocumentEnumeration_Data;
/** is a helper class for enumerating documents in OOo
If you need a list of all open documents in OOo, this is little bit of
@@ -81,7 +80,8 @@ namespace basctl::docs {
) const;
private:
std::unique_ptr< DocumentEnumeration_Data > m_pData;
css::uno::Reference< css::uno::XComponentContext > m_xContext;
const IDocumentDescriptorFilter* m_pFilter;
};