clang-tidy:readability-redundant-member-init

Change-Id: Ibeff6e5cbc20ab86b1e9cb96292acb340849ede3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121149
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

avmedia/source/framework/mediacontrol.cxx

@@ -35,7 +35,6 @@ MediaControl::MediaControl( vcl::Window* pParent, MediaControlStyle eControlStyl
                                    OUString("svx/ui/mediawindow.ui") :
                                    OUString("svx/ui/medialine.ui"),
                                "MediaWindow"),
-    MediaControlBase(),
     maIdle( "avmedia MediaControl Idle" ),
     maChangeTimeIdle( "avmedia MediaControl Change Time Idle" ),
     maItem( 0, AVMediaSetMask::ALL ),

avmedia/source/gstreamer/gstframegrabber.cxx

@@ -48,8 +48,7 @@ void FrameGrabber::disposePipeline()
     }
 }
 
-FrameGrabber::FrameGrabber( std::u16string_view rURL ) :
-    FrameGrabber_BASE()
+FrameGrabber::FrameGrabber( std::u16string_view rURL )
 {
     gchar *pPipelineStr;
     pPipelineStr = g_strdup_printf(

basegfx/source/color/bcolormodifier.cxx

@@ -148,8 +148,7 @@ namespace basegfx
     }
 
     BColorModifier_gamma::BColorModifier_gamma(double fValue)
-    :   BColorModifier(),
-        mfValue(fValue),
+    :   mfValue(fValue),
         mfInvValue(fValue),
         mbUseIt(!basegfx::fTools::equal(fValue, 1.0) && basegfx::fTools::more(fValue, 0.0) && basegfx::fTools::lessOrEqual(fValue, 10.0))
     {
@@ -195,8 +194,7 @@ namespace basegfx
     }
 
     BColorModifier_RGBLuminanceContrast::BColorModifier_RGBLuminanceContrast(double fRed, double fGreen, double fBlue, double fLuminance, double fContrast)
-    :   BColorModifier(),
-        mfRed(std::clamp(fRed, -1.0, 1.0)),
+    :   mfRed(std::clamp(fRed, -1.0, 1.0)),
         mfGreen(std::clamp(fGreen, -1.0, 1.0)),
         mfBlue(std::clamp(fBlue, -1.0, 1.0)),
         mfLuminance(std::clamp(fLuminance, -1.0, 1.0)),

basegfx/source/curve/b2dbeziertools.cxx

@@ -24,8 +24,7 @@
 namespace basegfx
 {
     B2DCubicBezierHelper::B2DCubicBezierHelper(const B2DCubicBezier& rBase, sal_uInt32 nDivisions)
-    :   maLengthArray(),
-        mnEdgeCount(0)
+    :   mnEdgeCount(0)
     {
         const bool bIsBezier(rBase.isBezier());
 

basegfx/source/matrix/b2dhommatrix.cxx

@@ -42,7 +42,6 @@ namespace basegfx
     B2DHomMatrix::~B2DHomMatrix() = default;
 
     B2DHomMatrix::B2DHomMatrix(double f_0x0, double f_0x1, double f_0x2, double f_1x0, double f_1x1, double f_1x2)
-        :   mpImpl() // identity
     {
         mpImpl->set(0, 0, f_0x0);
         mpImpl->set(0, 1, f_0x1);

basegfx/source/polygon/b2dpolygon.cxx

@@ -250,8 +250,7 @@ public:
     {}
 
     ControlVectorArray2D(const ControlVectorArray2D& rOriginal, sal_uInt32 nIndex, sal_uInt32 nCount)
-    :   maVector(),
-        mnUsedVectors(0)
+    :   mnUsedVectors(0)
     {
         ControlVectorPair2DVector::const_iterator aStart(rOriginal.maVector.begin());
         aStart += nIndex;
@@ -468,9 +467,6 @@ private:
 
 public:
     ImplBufferedData()
-    :   basegfx::SystemDependentDataHolder(),
-        mpDefaultSubdivision(),
-        mpB2DRange()
     {
     }
 
@@ -600,15 +596,11 @@ public:
 
     ImplB2DPolygon()
     :   maPoints(0),
-        mpControlVector(),
-        mpBufferedData(),
         mbIsClosed(false)
     {}
 
     ImplB2DPolygon(const ImplB2DPolygon& rToBeCopied)
     :   maPoints(rToBeCopied.maPoints),
-        mpControlVector(),
-        mpBufferedData(),
         mbIsClosed(rToBeCopied.mbIsClosed)
     {
         // complete initialization using copy
@@ -620,8 +612,6 @@ public:
 
     ImplB2DPolygon(const ImplB2DPolygon& rToBeCopied, sal_uInt32 nIndex, sal_uInt32 nCount)
     :   maPoints(rToBeCopied.maPoints, nIndex, nCount),
-        mpControlVector(),
-        mpBufferedData(),
         mbIsClosed(rToBeCopied.mbIsClosed)
     {
         // complete initialization using partly copy
@@ -1130,7 +1120,6 @@ namespace basegfx
     B2DPolygon::B2DPolygon() = default;
 
     B2DPolygon::B2DPolygon(std::initializer_list<basegfx::B2DPoint> aPoints)
-        : mpPolygon()
     {
         for (const basegfx::B2DPoint& rPoint : aPoints)
         {

basegfx/source/polygon/b2dpolypolygon.cxx

@@ -30,20 +30,16 @@ class ImplB2DPolyPolygon
 
 public:
     ImplB2DPolyPolygon()
-    :   maPolygons(),
-        mpSystemDependentDataHolder()
     {
     }
 
     explicit ImplB2DPolyPolygon(const ImplB2DPolyPolygon& rSource)
-    :   maPolygons(rSource.maPolygons),
-        mpSystemDependentDataHolder()
+    :   maPolygons(rSource.maPolygons)
     {
     }
 
     explicit ImplB2DPolyPolygon(const basegfx::B2DPolygon& rToBeCopied)
-    :   maPolygons(1,rToBeCopied),
-        mpSystemDependentDataHolder()
+    :   maPolygons(1,rToBeCopied)
     {
     }
 

basegfx/source/polygon/b2dtrapezoid.cxx

@@ -482,9 +482,6 @@ namespace basegfx::trapezoidhelper
         public:
             explicit TrapezoidSubdivider(
                 const B2DPolyPolygon& rSourcePolyPolygon)
-            :   maTrDeEdgeEntries(),
-                maPoints(),
-                maNewPoints()
             {
                 B2DPolyPolygon aSource(rSourcePolyPolygon);
                 TrDeSimpleEdges aTrDeSimpleEdges;

basegfx/source/polygon/b3dpolygon.cxx

@@ -37,7 +37,6 @@ class CoordinateData3D
 
 public:
     CoordinateData3D()
-    :   maPoint()
     {
     }
 
@@ -251,8 +250,7 @@ public:
     }
 
     BColorArray(const BColorArray& rOriginal, sal_uInt32 nIndex, sal_uInt32 nCount)
-    :   maVector(),
-        mnUsedEntries(0)
+    :   mnUsedEntries(0)
     {
         BColorDataVector::const_iterator aStart(rOriginal.maVector.begin());
         aStart += nIndex;
@@ -393,8 +391,7 @@ public:
     }
 
     NormalsArray3D(const NormalsArray3D& rOriginal, sal_uInt32 nIndex, sal_uInt32 nCount)
-    :   maVector(),
-        mnUsedEntries(0)
+    :   mnUsedEntries(0)
     {
         NormalsData3DVector::const_iterator aStart(rOriginal.maVector.begin());
         aStart += nIndex;
@@ -542,8 +539,7 @@ public:
     }
 
     TextureCoordinate2D(const TextureCoordinate2D& rOriginal, sal_uInt32 nIndex, sal_uInt32 nCount)
-    :   maVector(),
-        mnUsedEntries(0)
+    :   mnUsedEntries(0)
     {
         TextureData2DVector::const_iterator aStart(rOriginal.maVector.begin());
         aStart += nIndex;

basegfx/source/polygon/b3dpolypolygon.cxx

@@ -31,7 +31,7 @@ class ImplB3DPolyPolygon
     PolygonVector                                   maPolygons;
 
 public:
-    ImplB3DPolyPolygon() : maPolygons()
+    ImplB3DPolyPolygon()
     {
     }
 

basegfx/source/range/b2dpolyrange.cxx

@@ -31,10 +31,7 @@ namespace basegfx
     class ImplB2DPolyRange
     {
     public:
-        ImplB2DPolyRange() :
-            maBounds(),
-            maRanges(),
-            maOrient()
+        ImplB2DPolyRange()
         {}
 
         bool operator==(const ImplB2DPolyRange& rRHS) const

basegfx/source/range/b2drange.cxx

@@ -23,9 +23,7 @@
 
 namespace basegfx
 {
-    B2DRange::B2DRange( const B2IRange& rRange ) :
-        maRangeX(),
-        maRangeY()
+    B2DRange::B2DRange( const B2IRange& rRange )
     {
         if( !rRange.isEmpty() )
         {

basegfx/source/range/b2drangeclipper.cxx

@@ -226,7 +226,6 @@ namespace basegfx
             ImplPolygon() :
                 mpLeadingRightEdge(nullptr),
                 mnIdx(-1),
-                maPoints(),
                 mbIsFinished(false)
             {
                 // completely ad-hoc. but what the hell.

basegfx/source/raster/rasterconvert3d.cxx

@@ -48,8 +48,6 @@ namespace basegfx
     }
 
     RasterConverter3D::RasterConverter3D()
-    :   InterpolatorProvider3D(),
-        maLineEntries()
     {}
 
     RasterConverter3D::~RasterConverter3D()

basegfx/source/tools/b2dclipstate.cxx

@@ -36,15 +36,10 @@ namespace basegfx::utils
         enum Operation {UNION, INTERSECT, XOR, SUBTRACT};
 
         ImplB2DClipState() :
-            maPendingPolygons(),
-            maPendingRanges(),
-            maClipPoly(),
             mePendingOps(UNION)
         {}
 
         explicit ImplB2DClipState( const B2DPolyPolygon& rPoly ) :
-            maPendingPolygons(),
-            maPendingRanges(),
             maClipPoly(rPoly),
             mePendingOps(UNION)
         {}

basegfx/source/tools/systemdependentdata.cxx

@@ -96,7 +96,6 @@ namespace basegfx
 namespace basegfx
 {
     SystemDependentDataHolder::SystemDependentDataHolder()
-    :   maSystemDependentReferences()
     {
     }
 

basic/source/classes/sbunoobj.cxx

@@ -4196,8 +4196,7 @@ public:
 }
 
 ModuleInvocationProxy::ModuleInvocationProxy( std::u16string_view  aPrefix, SbxObjectRef const & xScopeObj )
-    : m_aMutex()
-    , m_aPrefix( OUString::Concat(aPrefix) + "_" )
+    : m_aPrefix( OUString::Concat(aPrefix) + "_" )
     , m_xScopeObj( xScopeObj )
     , m_aListeners( m_aMutex )
 {

basic/source/sbx/sbxarray.cxx

@@ -35,7 +35,7 @@ struct SbxVarEntry
 
 //  SbxArray
 
-SbxArray::SbxArray( SbxDataType t ) : SbxBase()
+SbxArray::SbxArray( SbxDataType t )
 {
     eType = t;
     if( t != SbxVARIANT )

basic/source/sbx/sbxvalue.cxx

@@ -35,12 +35,12 @@
 
 ///////////////////////////// constructors
 
-SbxValue::SbxValue() : SbxBase()
+SbxValue::SbxValue()
 {
     aData.eType = SbxEMPTY;
 }
 
-SbxValue::SbxValue( SbxDataType t ) : SbxBase()
+SbxValue::SbxValue( SbxDataType t )
 {
     int n = t & 0x0FFF;
 

basic/source/sbx/sbxvar.cxx

@@ -36,7 +36,7 @@ using namespace com::sun::star::uno;
 
 // SbxVariable
 
-SbxVariable::SbxVariable() : SbxValue()
+SbxVariable::SbxVariable()
 {
 }
 
@@ -539,7 +539,7 @@ bool SbxVariable::StoreData( SvStream& rStrm ) const
 // SbxInfo
 
 SbxInfo::SbxInfo()
-        : aHelpFile(), nHelpId(0)
+        :  nHelpId(0)
 {}
 
 SbxInfo::SbxInfo( const OUString& r, sal_uInt32 n )

include/basegfx/color/bcolor.hxx

@@ -45,7 +45,6 @@ namespace basegfx
             The color is initialized to (0.0, 0.0, 0.0)
         */
         BColor()
-        :   B3DTuple()
         {}
 
         /** Create a 3D Color

include/basegfx/color/bcolormodifier.hxx

@@ -88,7 +88,6 @@ namespace basegfx
     {
     public:
         BColorModifier_gray()
-        :   BColorModifier()
         {
         }
 
@@ -109,7 +108,6 @@ namespace basegfx
     {
     public:
         BColorModifier_invert()
-        :   BColorModifier()
         {
         }
 
@@ -134,7 +132,6 @@ namespace basegfx
     {
     public:
         BColorModifier_luminance_to_alpha()
-        :   BColorModifier()
         {
         }
 
@@ -160,8 +157,7 @@ namespace basegfx
 
     public:
         BColorModifier_replace(const ::basegfx::BColor& rBColor)
-        :   BColorModifier(),
-            maBColor(rBColor)
+        :   maBColor(rBColor)
         {
         }
 
@@ -192,8 +188,7 @@ namespace basegfx
 
     public:
         BColorModifier_interpolate(const ::basegfx::BColor& rBColor, double fValue)
-        :   BColorModifier(),
-            maBColor(rBColor),
+        :   maBColor(rBColor),
             mfValue(fValue)
         {
         }
@@ -219,8 +214,7 @@ namespace basegfx
 
     public:
         BColorModifier_black_and_white(double fValue)
-        :   BColorModifier(),
-            mfValue(fValue)
+        :   mfValue(fValue)
         {
         }
 

include/basegfx/matrix/b2dhommatrixtools.hxx

@@ -157,9 +157,7 @@ namespace basegfx::utils
 
         public:
             B2DHomMatrixBufferedDecompose(const B2DHomMatrix& rB2DHomMatrix = B2DHomMatrix())
-            :   maScale(),
-                maTranslate(),
-                mfRotate(0.0),
+            :   mfRotate(0.0),
                 mfShearX(0.0)
             {
                 rB2DHomMatrix.decompose(maScale, maTranslate, mfRotate, mfShearX);
@@ -201,8 +199,6 @@ namespace basegfx::utils
         public:
             B2DHomMatrixBufferedOnDemandDecompose(const B2DHomMatrix& rB2DHomMatrix = B2DHomMatrix())
             :   maB2DHomMatrix(rB2DHomMatrix),
-                maScale(),
-                maTranslate(),
                 mfRotate(0.0),
                 mfShearX(0.0),
                 mbDecomposed(false)

include/basegfx/point/b2dpoint.hxx

@@ -45,7 +45,6 @@ namespace basegfx
             The point is initialized to (0.0, 0.0)
         */
         B2DPoint()
-        :   B2DTuple()
         {}
 
         /** Create a 2D Point

include/basegfx/point/b2ipoint.hxx

@@ -41,7 +41,6 @@ namespace basegfx
             The point is initialized to (0, 0)
         */
         B2IPoint()
-        :   B2ITuple()
         {}
 
         /** Create a 2D Point

include/basegfx/point/b3dpoint.hxx

@@ -42,7 +42,6 @@ namespace basegfx
             The point is initialized to (0.0, 0.0, 0.0)
         */
         B3DPoint()
-        :   B3DTuple()
         {}
 
         /** Create a 3D Point

include/basegfx/range/b2dconnectedranges.hxx

@@ -77,8 +77,7 @@ namespace basegfx
 
         /// Create the range calculator
         B2DConnectedRanges() :
-            maDisjunctAggregatesList(),
-            maTotalBounds()
+            maDisjunctAggregatesList()
         {
         }
 

include/basegfx/raster/rasterconvert3d.hxx

@@ -71,8 +71,6 @@ namespace basegfx
 
     public:
         ip_double()
-        :   maX(),
-            maY()
         {}
 
         ip_double(double fXVal, double fXInc, double fYVal, double fYInc)
@@ -95,9 +93,6 @@ namespace basegfx
 
     public:
         ip_triple()
-        :   maX(),
-            maY(),
-            maZ()
         {}
 
         ip_triple(double fXVal, double fXInc, double fYVal, double fYInc, double fZVal, double fZInc)

include/basegfx/utils/gradienttools.hxx

@@ -66,9 +66,7 @@ namespace basegfx
 
     public:
         ODFGradientInfo()
-        :   maTextureTransform(),
-            maBackTextureTransform(),
-            mfAspectRatio(1.0),
+        :   mfAspectRatio(1.0),
             mnSteps(0)
         {
         }
@@ -78,7 +76,6 @@ namespace basegfx
             double fAspectRatio,
             sal_uInt32 nSteps)
         :   maTextureTransform(rTextureTransform),
-            maBackTextureTransform(),
             mfAspectRatio(fAspectRatio),
             mnSteps(nSteps)
         {

include/basegfx/vector/b2dvector.hxx

@@ -44,7 +44,6 @@ namespace basegfx
             The vector is initialized to (0.0, 0.0)
         */
         B2DVector()
-        :   B2DTuple()
         {}
 
         /** Create a 2D Vector

include/basegfx/vector/b2ivector.hxx

@@ -44,7 +44,6 @@ namespace basegfx
             The vector is initialized to (0, 0)
         */
         B2IVector()
-        :   B2ITuple()
         {}
 
         /** Create a 2D Vector

include/basegfx/vector/b3dvector.hxx

@@ -42,7 +42,6 @@ namespace basegfx
             The vector is initialized to (0.0, 0.0, 0.0)
         */
         B3DVector()
-        :   B3DTuple()
         {}
 
         /** Create a 3D Vector