ODFstudio/odfstudio
2
0
Fork 0
Code Issues Packages Activity

Avoid loplugin:noexceptmove failure with recent Clang 19 trunk

Browse Source 
> CallExpr 0x7fae572c85e0 '<dependent type>'
> `-UnresolvedMemberExpr 0x7fae572c8580 '<bound member function type>' lvalue
>   `-DeclRefExpr 0x7fae572c8560 'WeakReference<reference_type>' lvalue ParmVar 0x7fae572c76d0 'rWeakRef' 'WeakReference<reference_type> &&'
> In file included from tools/source/ref/ref.cxx:21:
> include/tools/weakbase.hxx:52:5: error: what's up doc? [loplugin:noexceptmove]
>    52 |     rWeakRef.reset();
>       |     ^~~~~~~~~~~~~~~~

Change-Id: I5693fda3c4e5afb02e6229bcb8ea952a62f0e363
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167157
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
This commit is contained in:
Stephan Bergmann
2024-05-05 22:30:56 +02:00
parent 4279455876
commit 7a895ec420
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
compilerplugins/clang/noexceptmove.cxx
+2 -1
View File
@@ -286,7 +286,8 @@ compat::optional<bool> NoExceptMove::IsCallThrows(const CallExpr* callExpr)
}
auto calleeExpr = callExpr->getCallee();
if (isa<CXXDependentScopeMemberExpr>(calleeExpr) || isa<UnresolvedLookupExpr>(calleeExpr))
if (isa<CXXDependentScopeMemberExpr>(calleeExpr) || isa<UnresolvedLookupExpr>(calleeExpr)
|| isa<UnresolvedMemberExpr>(calleeExpr))
{
m_CannotFix.back() = true;
return true;