Remove special treatment of UITests here

If stored setting changes UI test, the test should change to handle
that - which is done for tdf146019 (after tdf141297 checks "link"
checkbox in Insert Graphic dialog).

Change-Id: I3c0d1bb991fe6b07dc4be162f50464097d15bae8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/200671
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

sd/qa/uitest/impress_tests2/tdf146019.py

@@ -8,7 +8,7 @@
 #
 from uitest.framework import UITestCase
 from libreoffice.uno.propertyvalue import mkPropertyValues
-from uitest.uihelper.common import get_url_for_data_file
+from uitest.uihelper.common import get_state_as_dict, get_url_for_data_file
 
 class tdf146019(UITestCase):
 
@@ -25,6 +25,10 @@ class tdf146019(UITestCase):
                 xFileName = xOpenDialog.getChild("file_name")
                 xFileName.executeAction("TYPE", mkPropertyValues({"TEXT": get_url_for_data_file("tdf146019.jpg")}))
 
+                xLink = xOpenDialog.getChild("link")
+                if get_state_as_dict(xLink)['Selected'] == "true" :
+                    xLink.executeAction("CLICK", tuple())
+
             # Before the fix, a dialog was displayed at this point
 
             # Check the shape is rotated, height > width

sfx2/source/dialog/filedlghelper.cxx

@@ -20,7 +20,6 @@
 #include <memory>
 #include <optional>
 #include <string_view>
-#include <o3tl/test_info.hxx>
 
 #include <sfx2/filedlghelper.hxx>
 #include <sal/types.h>
@@ -2094,10 +2093,7 @@ void FileDialogHelper_Impl::saveConfig()
         try
         {
             // tdf#61358 - remember the last "insert as link" state
-            if (o3tl::IsRunningUITest())
-                aValue <<= false;
-            else
-                aValue = xDlg->getValue(ExtendedFilePickerElementIds::CHECKBOX_LINK, 0);
+            aValue = xDlg->getValue(ExtendedFilePickerElementIds::CHECKBOX_LINK, 0);
             bool bLink = false;
             aValue >>= bLink;
             OUString aUserData(GRF_CONFIG_STR);