ODFstudio/odfstudio
2
0
Fork 0
Code Issues Packages Activity

Resolves: tdf#156411 listen to "value-changed" not "changed"

Browse Source 
we were listening to "changed" and querying the "value", but the value
isn't guaranteed to have changed while the contents are being edited,
only when "value-changed" arrives.

Change-Id: I077051555813df48adae4259aa9a93d39c360dc3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154907
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
This commit is contained in:
Caolán McNamara
2023-07-26 11:26:20 +02:00
parent 1b6c01bdf7
commit 6a51ab527b
2 changed files with 12 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
include/svx/compressgraphicdialog.hxx
+4 -4
View File
@@ -67,10 +67,10 @@ private:
DECL_DLLPRIVATE_LINK( SlideHdl, weld::Scale&, void );
DECL_DLLPRIVATE_LINK( NewInterpolationModifiedHdl, weld::ComboBox&, void );
DECL_DLLPRIVATE_LINK( NewQualityModifiedHdl, weld::Entry&, void );
DECL_DLLPRIVATE_LINK( NewCompressionModifiedHdl, weld::Entry&, void );
DECL_DLLPRIVATE_LINK( NewWidthModifiedHdl, weld::Entry&, void );
DECL_DLLPRIVATE_LINK( NewHeightModifiedHdl, weld::Entry&, void );
DECL_DLLPRIVATE_LINK( NewQualityModifiedHdl, weld::SpinButton&, void );
DECL_DLLPRIVATE_LINK( NewCompressionModifiedHdl, weld::SpinButton&, void );
DECL_DLLPRIVATE_LINK( NewWidthModifiedHdl, weld::SpinButton&, void );
DECL_DLLPRIVATE_LINK( NewHeightModifiedHdl, weld::SpinButton&, void );
DECL_DLLPRIVATE_LINK( ResolutionModifiedHdl, weld::ComboBox&, void );
DECL_DLLPRIVATE_LINK( ToggleCompressionRB, weld::Toggleable&, void );
DECL_DLLPRIVATE_LINK( ToggleReduceResolutionRB, weld::Toggleable&, void );
svx/source/dialog/compressgraphicdialog.cxx
+8 -8
View File
@@ -135,8 +135,8 @@ void CompressGraphicsDialog::Initialize()
m_xInterpolationCombo->connect_changed(LINK(this, CompressGraphicsDialog, NewInterpolationModifiedHdl));
m_xMFNewWidth->connect_changed( LINK( this, CompressGraphicsDialog, NewWidthModifiedHdl ));
m_xMFNewHeight->connect_changed( LINK( this, CompressGraphicsDialog, NewHeightModifiedHdl ));
m_xMFNewWidth->connect_value_changed( LINK( this, CompressGraphicsDialog, NewWidthModifiedHdl ));
m_xMFNewHeight->connect_value_changed( LINK( this, CompressGraphicsDialog, NewHeightModifiedHdl ));
m_xResolutionLB->connect_changed( LINK( this, CompressGraphicsDialog, ResolutionModifiedHdl ));
m_xBtnCalculate->connect_clicked( LINK( this, CompressGraphicsDialog, CalculateClickHdl ) );
@@ -148,8 +148,8 @@ void CompressGraphicsDialog::Initialize()
m_xQualitySlider->connect_value_changed( LINK( this, CompressGraphicsDialog, SlideHdl ));
m_xCompressionSlider->connect_value_changed( LINK( this, CompressGraphicsDialog, SlideHdl ));
m_xQualityMF->connect_changed( LINK( this, CompressGraphicsDialog, NewQualityModifiedHdl ));
m_xCompressionMF->connect_changed( LINK( this, CompressGraphicsDialog, NewCompressionModifiedHdl ));
m_xQualityMF->connect_value_changed( LINK( this, CompressGraphicsDialog, NewQualityModifiedHdl ));
m_xCompressionMF->connect_value_changed( LINK( this, CompressGraphicsDialog, NewCompressionModifiedHdl ));
m_xJpegCompRB->set_active(true);
m_xReduceResolutionCB->set_active(true);
@@ -288,7 +288,7 @@ IMPL_LINK_NOARG( CompressGraphicsDialog, OkayClickHdl, weld::Button&, void )
CompressGraphicsDialog::response(RET_OK);
}
IMPL_LINK_NOARG( CompressGraphicsDialog, NewWidthModifiedHdl, weld::Entry&, void )
IMPL_LINK_NOARG( CompressGraphicsDialog, NewWidthModifiedHdl, weld::SpinButton&, void )
{
m_dResolution = m_xMFNewWidth->get_value() / GetViewWidthInch();
@@ -311,19 +311,19 @@ IMPL_LINK_NOARG( CompressGraphicsDialog, NewInterpolationModifiedHdl, weld::Comb
Update();
}
IMPL_LINK_NOARG( CompressGraphicsDialog, NewQualityModifiedHdl, weld::Entry&, void )
IMPL_LINK_NOARG( CompressGraphicsDialog, NewQualityModifiedHdl, weld::SpinButton&, void )
{
m_xQualitySlider->set_value(m_xQualityMF->get_value());
Update();
}
IMPL_LINK_NOARG( CompressGraphicsDialog, NewCompressionModifiedHdl, weld::Entry&, void )
IMPL_LINK_NOARG( CompressGraphicsDialog, NewCompressionModifiedHdl, weld::SpinButton&, void )
{
m_xCompressionSlider->set_value(m_xCompressionMF->get_value());
Update();
}
IMPL_LINK_NOARG( CompressGraphicsDialog, NewHeightModifiedHdl, weld::Entry&, void )
IMPL_LINK_NOARG( CompressGraphicsDialog, NewHeightModifiedHdl, weld::SpinButton&, void )
{
m_dResolution = m_xMFNewHeight->get_value() / GetViewHeightInch();