ODFstudio/odfstudio
2
0
Fork 0
Code Issues Packages Activity

tdf#152974 revert change to ORichTextModel::getPropertyDefaultByHandle

Browse Source 
properties that match the default are not exported, so we're basically
stuck with what is in there for compatibility with older versions, so
revert

commit ca46afebb7
Date:   Tue Oct 4 16:22:51 2022 +0100

    default to 'flat' instead of '3D Look' for form controls

and set m_nBorder to the desired new default in the ctor but
leave getPropertyDefaultByHandle as it always was

Change-Id: Ia862fc6851248fc9b16b3b4c505fdaf6fdb4b2ac
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151497
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
This commit is contained in:
Caolán McNamara
2023-05-08 13:21:20 +02:00
parent 772ce2e0a9
commit 63b8e8bda2
1 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
forms/source/richtext/richtextmodel.cxx
+7 -3
View File
@@ -64,7 +64,9 @@ namespace frm
m_nClassId = FormComponentType::TEXTFIELD;
getPropertyDefaultByHandle( PROPERTY_ID_DEFAULTCONTROL ) >>= m_sDefaultControl;
getPropertyDefaultByHandle( PROPERTY_ID_BORDER ) >>= m_nBorder;
// Default to 'flat' instead of '3D Look' for form controls, but don't change
// getPropertyDefaultByHandle, see tdf#152974
m_nBorder = 2;
getPropertyDefaultByHandle( PROPERTY_ID_ENABLED ) >>= m_bEnabled;
getPropertyDefaultByHandle( PROPERTY_ID_ENABLEVISIBLE ) >>= m_bEnableVisible;
getPropertyDefaultByHandle( PROPERTY_ID_HARDLINEBREAKS ) >>= m_bHardLineBreaks;
@@ -450,7 +452,9 @@ namespace frm
}
}
// note tdf#152974, we can't simply change a default here because properties
// that match the default are not exported, so for compatibility these
// can't be changed without some sort of solution for that
Any ORichTextModel::getPropertyDefaultByHandle( sal_Int32 _nHandle ) const
{
Any aDefault;
@@ -506,7 +510,7 @@ namespace frm
break;
case PROPERTY_ID_BORDER:
aDefault <<= sal_Int16(2);
aDefault <<= sal_Int16(1);
break;
default: