tdf#168145 Base must come out of the insert row

If you use ResultSets with the XRowLocate interface, Base moves to the insertion row in the WrappedResultSet.cxx file, line 73.

And it never returns. Normally, this shouldn't happen, after the insert is done you must go away from the insertion row to continue.
At least that's what it seems to me?

The same scenario happens in the file BookmarkSet.cxx line 78 and so this has also been corrected.

Change-Id: I169fd0a32441922025b3cc5531b32166b4c54be0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190349
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
This commit is contained in:
prrvchr
2025-09-29 09:40:28 +02:00
committed by Noel Grandin
parent c4c93d1a3e
commit 5d64bdf62a
2 changed files with 4 additions and 0 deletions
+2
View File
@@ -84,6 +84,8 @@ void OBookmarkSet::insertRow( const ORowSetRow& _rInsertRow,const connectivity::
updateColumn(i,xUpdRow,*aIter);
}
xUpd->insertRow();
// We must go away from the insert row when the insert is finish
xUpd->moveToCurrentRow();
(*_rInsertRow->begin()) = m_xRowLocate->getBookmark();
}
else
@@ -79,6 +79,8 @@ void WrappedResultSet::insertRow( const ORowSetRow& _rInsertRow,const connectivi
updateColumn(i,m_xUpdRow,*aIter);
}
m_xUpd->insertRow();
// We must go away from the insert row when the insert is finish
m_xUpd->moveToCurrentRow();
(*_rInsertRow->begin()) = getBookmark();
}