Sidebar tdf#92768: Fix title & subtitle checkboxes on the ChartDeck

Turns out the 2nd part of tdf#92768 was not implemented yet, so it is
still necessary to remove the title/subtitle for good, otherwise we set
the "Visibility" property, but nothing actually reads that when
rendering.

So the titles now work as they did before the regression. An uncheck action
removes the title/subtitle, and a check action just makes the existing
title/subtitle visible or creates a new one if it doesn't exist

Change-Id: I23122d1be2d95af878b824ba194bd1aeed5f4f89
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90692
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105737
Tested-by: Jenkins
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
This commit is contained in:
Muhammet Kara
2020-11-13 14:34:14 +01:00
committed by Jan Holesovsky
parent ca35aea6ed
commit 5858f62882
@@ -663,7 +663,9 @@ void ChartElementsPanel::setTitleVisible(TitleHelper::eTitleType eTitle, bool bV
}
else
{
TitleHelper::hideTitle(eTitle, mxModel);
// TODO tdf#92768 use TitleHelper::hideTitle() here once there is
// rendering suport for the property "Visible"
TitleHelper::removeTitle(eTitle, mxModel);
}
}