set copy_paste_error to false rather than intentional

Change-Id: I152482ef594c286d3c2a94cab62feff49bbf79fa
Reviewed-on: https://gerrit.libreoffice.org/58884
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
This commit is contained in:
Caolán McNamara
2018-08-11 21:09:55 +02:00
parent 12ea892df9
commit 5262ec68f3
9 changed files with 16 additions and 14 deletions
+1 -1
View File
@@ -461,7 +461,7 @@ namespace basegfx
if(!fTools::equalZero(fShearY))
{
// coverity[copy_paste_error] - this is correct getZ, not getY
// coverity[copy_paste_error : FALSE] - this is correct getZ, not getY
rShear.setY(rShear.getY() / rScale.getZ());
}
+1 -1
View File
@@ -2115,7 +2115,7 @@ at_least_one_scoped_name :
} else
{
std::list< OString >* pScopedNames = new std::list< OString >;
// coverity[copy_paste_error] - this is not a cut and paste
// coverity[copy_paste_error : FALSE] - this is not a cut and paste
pScopedNames->push_back(*$1);
$$ = pScopedNames;
}
+1 -1
View File
@@ -2736,7 +2736,7 @@ bool ScDPGroupCompare::TestIncluded( const ScDPMember& rMember )
{
if (pResultData->GetGroupBase(it->mnSrcIndex) == nGroupBase)
{
// coverity[copy_paste_error] - same base (hierarchy between
// coverity[copy_paste_error : FALSE] - same base (hierarchy between
// the two groups is irrelevant)
bInclude = pResultData->HasCommonElement(
it->mnNameIndex, it->mnSrcIndex, aMemberData, nDimSource);
+1 -1
View File
@@ -5702,7 +5702,7 @@ bool ScCompiler::HandleTableRef()
default:
; // nothing
}
// coverity[copy_paste_error] - this is correct, aStart in both aDBRange uses
// coverity[copy_paste_error : FALSE] - this is correct, aStart in both aDBRange uses
if (aColRange.aStart.Row() != aDBRange.aStart.Row() || aColRange.aEnd.Row() != aDBRange.aStart.Row())
aRange = ScRange( ScAddress::INITIALIZE_INVALID);
else
+2 -2
View File
@@ -179,7 +179,7 @@ ScPositionHelper::getNearestByIndex(index_type nIndex) const
}
auto posLB = std::prev(posUB);
// coverity[copy_paste_error] - posUB is correct
// coverity[copy_paste_error : FALSE] - posUB is correct
if (posUB == mData.end())
{
return *posLB;
@@ -210,7 +210,7 @@ ScPositionHelper::getNearestByPosition(long nPos) const
}
auto posLB = std::prev(posUB);
// coverity[copy_paste_error] - posUB is correct
// coverity[copy_paste_error : FALSE] - posUB is correct
if (posUB == mData.end())
{
return *posLB;
@@ -2343,7 +2343,7 @@ void CustomAnimationPane::moveSelection( bool bUp )
CustomAnimationEffectPtr pEffect = (*aIter++);
EffectSequence::iterator aUpEffectPos( pSequence->find( pEffect ) );
// coverity[copy_paste_error] - this is correct, checking if it exists
// coverity[copy_paste_error : FALSE] - this is correct, checking if it exists
if( aUpEffectPos != rEffectSequence.end() )
{
EffectSequence::iterator aInsertPos( rEffectSequence.erase( aUpEffectPos ) );
@@ -2374,7 +2374,7 @@ void CustomAnimationPane::moveSelection( bool bUp )
CustomAnimationEffectPtr pEffect = (*aIter++);
EffectSequence::iterator aDownEffectPos( pSequence->find( pEffect ) );
// coverity[copy_paste_error] - this is correct, checking if it exists
// coverity[copy_paste_error : FALSE] - this is correct, checking if it exists
if( aDownEffectPos != rEffectSequence.end() )
{
EffectSequence::iterator aInsertPos( rEffectSequence.erase( aDownEffectPos ) );
+6 -4
View File
@@ -1601,10 +1601,12 @@ private:
Size aPaperSize( rInfo.mpPrinter->PixelToLogic( rInfo.mpPrinter->GetPaperSizePixel(), MapMode( MapUnit::Map100thMM ) ) );
maPrintSize.Width = aPaperSize.Height();
maPrintSize.Height = aPaperSize.Width();
const long nRotatedWidth = aOutRect.GetHeight();
const long nRotatedHeight = aOutRect.GetWidth();
aOutRect = ::tools::Rectangle( Point( aPageOfs.Y(), aPageOfs.X() ),
Size( nRotatedWidth, nRotatedHeight ) );
const auto nRotatedWidth = aOutRect.GetHeight();
const auto nRotatedHeight = aOutRect.GetWidth();
const auto nRotatedX = aPageOfs.Y();
const auto nRotatedY = aPageOfs.X();
aOutRect = ::tools::Rectangle(Point( nRotatedX, nRotatedY),
Size(nRotatedWidth, nRotatedHeight));
}
Outliner* pOutliner = mrBase.GetDocument()->GetInternalOutliner();
+1 -1
View File
@@ -572,7 +572,7 @@ tools::Polygon XOutBitmap::GetContour( const Bitmap& rBmp, const XOutFlags nFlag
// this loop always breaks eventually as there is at least one pixel
while( true )
{
// coverity[copy_paste_error] - this is correct nX, not nY
// coverity[copy_paste_error : FALSE] - this is correct nX, not nY
if( aBlack == pAcc->GetPixelFromData( pScanline, nX ) )
{
pPoints2[ nPolyPos ] = Point( nX, nY );
+1 -1
View File
@@ -6288,7 +6288,7 @@ void PDFWriterImpl::drawRelief( SalLayout& rLayout, const OUString& rText, bool
aTextLineColor = COL_WHITE;
if( aOverlineColor == COL_BLACK )
aOverlineColor = COL_WHITE;
// coverity[copy_paste_error] - aReliefColor depending on aTextColor is correct
// coverity[copy_paste_error : FALSE] - aReliefColor depending on aTextColor is correct
if( aTextColor == COL_WHITE )
aReliefColor = COL_BLACK;