ODFstudio/odfstudio
2
0
Fork 0
Code Issues Packages Activity

thumbnailview a11y: Drop always false param

Browse Source 
See also

    commit d144891269
    Author: Michael Weghorn <m.weghorn@posteo.de>
    Date:   Mon Feb 24 18:33:56 2025 +0100

        valueset a11y: Drop always false ValueSetItem::GetAccessible param

which basically did the same for ValueSetItem.

Change-Id: Ibb2b2d23926e618c3380a4b7aff0115fdea41a1b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182196
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
This commit is contained in:
Michael Weghorn
2025-02-26 08:10:18 +01:00
parent bb5f3c008b
commit 5003e1d57d
4 changed files with 11 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files
include/sfx2/thumbnailviewitem.hxx
+1 -2
View File
@@ -110,8 +110,7 @@ public:
void setTitle (const OUString& rTitle);
rtl::Reference< ThumbnailViewItemAcc > const &
GetAccessible( bool bIsTransientChildrenDisabled );
rtl::Reference<ThumbnailViewItemAcc> const & GetAccessible();
void setDrawArea (const tools::Rectangle &area);
sfx2/source/control/thumbnailview.cxx
+5 -7
View File
@@ -293,7 +293,7 @@ void ThumbnailView::ImplDeleteItems()
{
css::uno::Any aOldAny, aNewAny;
aOldAny <<= css::uno::Reference<css::accessibility::XAccessible>(pItem->GetAccessible( false ));
aOldAny <<= css::uno::Reference<css::accessibility::XAccessible>(pItem->GetAccessible());
ImplFireAccessibleEvent( css::accessibility::AccessibleEventId::CHILD, aOldAny, aNewAny );
}
@@ -433,11 +433,9 @@ void ThumbnailView::CalculateItemPositions(bool bScrollBarUsed)
{
css::uno::Any aOldAny, aNewAny;
if (bIsVisible)
aNewAny <<= css::uno::Reference<css::accessibility::XAccessible>(
rItem.GetAccessible(false));
aNewAny <<= css::uno::Reference<css::accessibility::XAccessible>(rItem.GetAccessible());
else
aOldAny <<= css::uno::Reference<css::accessibility::XAccessible>(
rItem.GetAccessible(false));
aOldAny <<= css::uno::Reference<css::accessibility::XAccessible>(rItem.GetAccessible());
ImplFireAccessibleEvent(css::accessibility::AccessibleEventId::CHILD, aOldAny, aNewAny);
}
};
@@ -1141,7 +1139,7 @@ void ThumbnailView::SelectItem( sal_uInt16 nItemId )
return;
// focus event (select)
const rtl::Reference<ThumbnailViewItemAcc> & pItemAcc = pItem->GetAccessible( false );
const rtl::Reference<ThumbnailViewItemAcc>& pItemAcc = pItem->GetAccessible();
if( pItemAcc )
{
@@ -1224,7 +1222,7 @@ void ThumbnailView::filterItems(const std::function<bool (const ThumbnailViewIte
{
css::uno::Any aOldAny, aNewAny;
aOldAny <<= css::uno::Reference<css::accessibility::XAccessible>(pItem->GetAccessible( false ));
aOldAny <<= css::uno::Reference<css::accessibility::XAccessible>(pItem->GetAccessible());
ImplFireAccessibleEvent( css::accessibility::AccessibleEventId::CHILD, aOldAny, aNewAny );
}
sfx2/source/control/thumbnailviewacc.cxx
+3 -3
View File
@@ -71,7 +71,7 @@ uno::Reference< accessibility::XAccessible > SAL_CALL ThumbnailViewAcc::getAcces
if( !pItem )
throw lang::IndexOutOfBoundsException();
uno::Reference< accessibility::XAccessible > xRet = pItem->GetAccessible( /*bIsTransientChildrenDisabled*/false );
uno::Reference< accessibility::XAccessible > xRet = pItem->GetAccessible();
return xRet;
}
@@ -248,7 +248,7 @@ uno::Reference< accessibility::XAccessible > SAL_CALL ThumbnailViewAcc::getAcces
if( THUMBNAILVIEW_ITEM_NONEITEM != nItemPos )
{
ThumbnailViewItem* const pItem = mpThumbnailView->mFilteredItemList[nItemPos];
xRet = pItem->GetAccessible( /*bIsTransientChildrenDisabled*/false );
xRet = pItem->GetAccessible();
}
}
@@ -412,7 +412,7 @@ uno::Reference< accessibility::XAccessible > SAL_CALL ThumbnailViewAcc::getSelec
if (pItem && mpThumbnailView->IsItemSelected(pItem->mnId)
&& (nSelectedChildIndex == static_cast<sal_Int32>(nSel++)))
xRet = pItem->GetAccessible( /*bIsTransientChildrenDisabled*/false );
xRet = pItem->GetAccessible();
}
return xRet;
sfx2/source/control/thumbnailviewitem.cxx
+2 -2
View File
@@ -111,10 +111,10 @@ void ThumbnailViewItem::setTitle (const OUString& rTitle)
maTitle = rTitle;
}
const rtl::Reference< ThumbnailViewItemAcc > & ThumbnailViewItem::GetAccessible( bool bIsTransientChildrenDisabled )
const rtl::Reference< ThumbnailViewItemAcc > & ThumbnailViewItem::GetAccessible()
{
if( !mxAcc.is() )
mxAcc = new ThumbnailViewItemAcc( this, bIsTransientChildrenDisabled );
mxAcc = new ThumbnailViewItemAcc(this, false);
return mxAcc;
}