ODFstudio/odfstudio
2
0
Fork 0
Code Issues Packages Activity

loplugin:unusedmethods

Browse Source 
and trim out some of the noise from the reports

Change-Id: Ib99a044049a7715978ef58718d2518bde23b8fe6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185958
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
This commit is contained in:
Noel Grandin
2025-05-28 16:49:14 +02:00
parent 4a3e4283c1
commit 4b61dffd1d
13 changed files with 1155 additions and 2386 deletions
Download Patch File Download Diff File Expand all files Collapse all files
compilerplugins/clang/unusedmethods.py
+17
View File
@@ -197,6 +197,23 @@ for d in definitionSet:
continue
if location.startswith("include/oox/drawingml/chart/modelbase.hxx"):
continue
# templated methods that are auto-generated by the compiler
if location.startswith("include/comphelper/interfacecontainer3.hxx"):
continue
if location.startswith("include/comphelper/interfacecontainer4.hxx"):
continue
if location.startswith("include/o3tl/sorted_vector.hxx"):
continue
if location.startswith("include/o3tl/strong_int.hxx"):
continue
if location.startswith("include/o3tl/typed_flags_set.hxx"):
continue
if location.startswith("include/svl/typedwhich.hxx"):
continue
if location.startswith("include/toolkit/helper/listenermultiplexer.hxx"):
continue
if location.startswith("include/tools/lazydelete.hxx"):
continue
unusedSet.add(d) # used by the "unused return types" analysis
tmp1set.add((method, location))
compilerplugins/clang/unusedmethods.results
+293 -2239
View File
File diff suppressed because it is too large Load Diff
compilerplugins/clang/unusedmethods.unused-returns.results
+845 -81
View File
File diff suppressed because it is too large Load Diff
cui/source/factory/dlgfact.cxx
-1
View File
@@ -755,7 +755,6 @@ public:
void SetCheckNameTooltipHdl(const Link<AbstractSvxNameDialog&, OUString>& rLink) override;
void SetEditHelpId(const OUString& rHelpId) override { m_pDlg->SetEditHelpId(rHelpId); }
//from class Window
void SetHelpId(const OUString& rHelpId) override { m_pDlg->set_help_id(rHelpId); }
void SetText(const OUString& rStr) override { m_pDlg->set_title(rStr); }
private:
include/svx/Palette.hxx
-2
View File
@@ -41,8 +41,6 @@ public:
virtual void LoadColorSet(SvxColorValueSet& rColorSet) = 0;
virtual bool IsValid() = 0;
virtual Palette* Clone() const = 0;
};
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
include/svx/chrtitem.hxx
-4
View File
@@ -158,7 +158,6 @@ class SAL_WARN_UNUSED SVXCORE_DLLPUBLIC SvxChartColorPaletteItem final : public
sal_uInt32 mnIndex;
public:
static SfxPoolItem* CreateDefault();
DECLARE_ITEM_TYPE_FUNCTION(SvxChartColorPaletteItem);
SvxChartColorPaletteItem(ChartColorPaletteType eType, sal_uInt32 nIndex,
TypedWhichId<SvxChartColorPaletteItem> nId);
@@ -176,9 +175,6 @@ public:
ChartColorPaletteType GetType() const { return meType; }
sal_uInt32 GetIndex() const { return mnIndex; }
void SetType(const ChartColorPaletteType eType) { meType = eType; }
void SetIndex(const sal_uInt32 nIndex) { mnIndex = nIndex; }
};
#endif // INCLUDED_SVX_CHRTITEM_HXX
include/svx/svxdlg.hxx
-1
View File
@@ -153,7 +153,6 @@ public:
virtual void SetCheckNameHdl( const Link<AbstractSvxNameDialog&,bool>& rLink ) = 0;
virtual void SetCheckNameTooltipHdl( const Link<AbstractSvxNameDialog&,OUString>& rLink ) = 0;
virtual void SetEditHelpId(const OUString&) = 0;
virtual void SetHelpId( const OUString& ) = 0;
virtual void SetText( const OUString& rStr ) = 0;
};
sc/source/filter/inc/worksheethelper.hxx
-3
View File
@@ -187,9 +187,6 @@ public:
/** Returns the XCell interface for the passed cell address. */
css::uno::Reference< css::table::XCell >
getCell( const ScAddress& rAddress ) const;
/** Returns the XCellRange interface for the passed cell range address. */
css::uno::Reference< css::table::XCellRange >
getCellRange( const ScRange& rRange ) const;
/** Returns the XDrawPage interface of the draw page of the current sheet. */
css::uno::Reference< css::drawing::XDrawPage >
sc/source/filter/oox/worksheethelper.cxx
-20
View File
@@ -228,8 +228,6 @@ public:
/** Returns the XCell interface for the passed cell address. */
Reference< XCell > getCell( const ScAddress& rAddress ) const;
/** Returns the XCellRange interface for the passed cell range address. */
Reference< XCellRange > getCellRange( const ScRange& rRange ) const;
/** Returns the XSheetCellRanges interface for the passed cell range addresses. */
rtl::Reference<ScCellRangesObj> getCellRangeList( const ScRangeList& rRanges ) const;
@@ -466,19 +464,6 @@ Reference< XCell > WorksheetGlobals::getCell( const ScAddress& rAddress ) const
return xCell;
}
Reference< XCellRange > WorksheetGlobals::getCellRange( const ScRange& rRange ) const
{
Reference< XCellRange > xRange;
if( mxSheet.is() ) try
{
xRange = mxSheet->getCellRangeByPosition( rRange.aStart.Col(), rRange.aStart.Row(), rRange.aEnd.Col(), rRange.aEnd.Row() );
}
catch( Exception& )
{
}
return xRange;
}
rtl::Reference<ScCellRangesObj> WorksheetGlobals::getCellRangeList( const ScRangeList& rRanges ) const
{
rtl::Reference<ScCellRangesObj> xRanges;
@@ -1446,11 +1431,6 @@ Reference< XCell > WorksheetHelper::getCell( const ScAddress& rAddress ) const
return mrSheetGlob.getCell( rAddress );
}
Reference< XCellRange > WorksheetHelper::getCellRange( const ScRange& rRange ) const
{
return mrSheetGlob.getCellRange( rRange );
}
Reference< XDrawPage > WorksheetHelper::getDrawPage() const
{
return mrSheetGlob.getDrawPage();
svx/inc/palettes.hxx
-6
View File
@@ -47,8 +47,6 @@ public:
virtual void LoadColorSet(SvxColorValueSet& rColorSet) override;
virtual bool IsValid() override;
virtual Palette* Clone() const override;
};
// GPL - this is *not* GNU Public License, but is the Gimp PaLette
@@ -75,8 +73,6 @@ public:
virtual void LoadColorSet(SvxColorValueSet& rColorSet) override;
virtual bool IsValid() override;
virtual Palette* Clone() const override;
};
// SOC - Star Office Color-table
@@ -97,8 +93,6 @@ public:
virtual void LoadColorSet(SvxColorValueSet& rColorSet) override;
virtual bool IsValid() override;
virtual Palette* Clone() const override;
};
#endif // INCLUDED_SVX_INC_PALETTE_HXX
svx/source/items/chrtitem.cxx
-6
View File
@@ -181,12 +181,6 @@ SvxChartRegressItem* SvxChartRegressItem::Clone(SfxItemPool* /*pPool*/) const
// SvxChartColorPaletteItem implementation
SfxPoolItem* SvxChartColorPaletteItem::CreateDefault()
{
return new SvxChartColorPaletteItem(ChartColorPaletteType::Unknown, 0,
TypedWhichId<SvxChartColorPaletteItem>(0));
}
SvxChartColorPaletteItem::SvxChartColorPaletteItem(const ChartColorPaletteType eType,
const sal_uInt32 nIndex,
const TypedWhichId<SvxChartColorPaletteItem> nId)
svx/source/tbxctrls/Palette.cxx
-15
View File
@@ -266,11 +266,6 @@ void PaletteASE::LoadPalette()
mbValidPalette = true;
}
Palette* PaletteASE::Clone() const
{
return new PaletteASE(*this);
}
// PaletteGPL ------------------------------------------------------------------
static OString lcl_getToken(OStringBuffer& rStr, sal_Int32& index);
@@ -389,11 +384,6 @@ void PaletteGPL::LoadPalette()
} while (aFile.ReadLine(aLine));
}
Palette* PaletteGPL::Clone() const
{
return new PaletteGPL(*this);
}
// finds first token in rStr from index, separated by whitespace
// returns position of next token in index
static OString lcl_getToken(OStringBuffer& rStr, sal_Int32& index)
@@ -470,9 +460,4 @@ bool PaletteSOC::IsValid()
return true;
}
Palette* PaletteSOC::Clone() const
{
return new PaletteSOC(*this);
}
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
sw/source/uibase/inc/swrenamexnameddlg.hxx
-8
View File
@@ -48,14 +48,6 @@ public:
{
m_aTextFilter.SetForbiddenChars(rSet);
}
void SetAlternativeAccess(
css::uno::Reference< css::container::XNameAccess > const & xSecond,
css::uno::Reference< css::container::XNameAccess > const & xThird )
{
m_xSecondAccess = xSecond;
m_xThirdAccess = xThird;
}
};
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */