ODFstudio/odfstudio
2
0
Fork 0
Code Issues Packages Activity

tdf#97087 Give comprehensible, unique names to idles

Browse Source 
Timers and idles should have programmer comprehensible, unique names

Change-Id: Id0f2c0a77cd28c3ec5473e8432569739b58d2101
Reviewed-on: https://gerrit.libreoffice.org/24388
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
This commit is contained in:
Muhammet Kara
2016-04-28 09:34:30 +00:00
committed by Michael Meeks
parent 91adb929d7
commit 376c337d46
17 changed files with 26 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
avmedia/source/framework/mediacontrol.cxx
+1
View File
@@ -60,6 +60,7 @@ namespace avmedia
MediaControl::MediaControl( vcl::Window* pParent, MediaControlStyle eControlStyle ) :
Control( pParent ),
maImageList( SvtMiscOptions().AreCurrentSymbolsLarge() ? AVMEDIA_RESID( AVMEDIA_IMGLST_L ) : AVMEDIA_RESID( AVMEDIA_IMGLST ) ),
maIdle( "avmedia MediaControl Idle" ),
maItem( 0, AVMediaSetMask::ALL ),
maPlayToolBox( VclPtr<ToolBox>::Create(this, WB_3DLOOK) ),
maTimeSlider( VclPtr<Slider>::Create(this, WB_HORZ | WB_DRAG | WB_3DLOOK | WB_SLIDERSET) ),
cui/source/dialogs/linkdlg.cxx
+2 -1
View File
@@ -95,7 +95,8 @@ SvBaseLinksDlg::SvBaseLinksDlg( vcl::Window * pParent, LinkManager* pMgr, bool b
aStrCloselinkmsgMulti( CUI_RES( STR_CLOSELINKMSG_MULTI ) ),
aStrWaitinglink( CUI_RES( STR_WAITINGLINK ) ),
pLinkMgr( nullptr ),
bHtmlMode(bHtml)
bHtmlMode(bHtml),
aUpdateIdle("cui SvBaseLinksDlg UpdateIdle")
{
get(m_pTbLinks, "TB_LINKS");
Size aSize(LogicToPixel(Size(257, 87), MAP_APPFONT));
extensions/source/bibliography/bibcont.cxx
+2 -1
View File
@@ -121,7 +121,8 @@ bool BibWindowContainer::HandleShortCutKey( const KeyEvent& rKeyEvent )
BibBookContainer::BibBookContainer(vcl::Window* pParent, WinBits nStyle):
BibSplitWindow(pParent,nStyle),
pTopWin(nullptr),
pBottomWin(nullptr)
pBottomWin(nullptr),
aIdle("extensions BibBookContainer Split Idle")
{
pBibMod = OpenBibModul();
aIdle.SetIdleHdl(LINK( this, BibBookContainer, SplitHdl));
formula/source/ui/dlg/funcutl.cxx
+2
View File
@@ -429,6 +429,7 @@ void EditBox::UpdateOldSel()
RefEdit::RefEdit( vcl::Window* _pParent, vcl::Window* pShrinkModeLabel, WinBits nStyle )
: Edit( _pParent, nStyle )
, aIdle("formula RefEdit Idle")
, pAnyRefDlg( nullptr )
, pLabelWidget(pShrinkModeLabel)
{
@@ -439,6 +440,7 @@ RefEdit::RefEdit( vcl::Window* _pParent, vcl::Window* pShrinkModeLabel, WinBits
RefEdit::RefEdit( vcl::Window* _pParent,IControlReferenceHandler* pParent,
vcl::Window* pShrinkModeLabel, const ResId& rResId )
: Edit( _pParent, rResId )
, aIdle("formula RefEdit Idle")
, pAnyRefDlg( pParent )
, pLabelWidget(pShrinkModeLabel)
{
sc/source/ui/docshell/autostyl.cxx
+2
View File
@@ -59,6 +59,8 @@ struct FindNonZeroTimeout : public ::std::unary_function<ScAutoStyleData, bool>
ScAutoStyleList::ScAutoStyleList(ScDocShell* pShell)
: pDocSh(pShell)
, aTimer("ScAutoStyleList Timer")
, aInitIdle("ScAutoStyleList InitIdle")
, nTimerStart(0)
{
aTimer.SetTimeoutHdl( LINK( this, ScAutoStyleList, TimerHdl ) );
sc/source/ui/miscdlgs/acredlin.cxx
+2
View File
@@ -77,6 +77,8 @@ ScAcceptChgDlg::ScAcceptChgDlg(SfxBindings* pB, SfxChildWindow* pCW, vcl::Window
ScViewData* ptrViewData)
: SfxModelessDialog(pB, pCW, pParent,
"AcceptRejectChangesDialog", "svx/ui/acceptrejectchangesdialog.ui"),
aSelectionIdle("ScAcceptChgDlg SelectionIdle"),
aReOpenIdle("ScAcceptChgDlg ReOpenIdle"),
pViewData ( ptrViewData ),
pDoc ( ptrViewData->GetDocument() ),
aStrInsertCols (SC_RESSTR(STR_CHG_INSERT_COLS)),
sc/source/ui/miscdlgs/conflictsdlg.cxx
+1
View File
@@ -386,6 +386,7 @@ ScConflictsDlg::ScConflictsDlg( vcl::Window* pParent, ScViewData* pViewData, ScD
,mpSharedTrack ( nullptr )
,mrConflictsList ( rConflictsList )
,maDialogSize ( GetSizePixel() )
,maSelectionIdle ( "ScConflictsDlg SelectionIdle" )
,mbInSelectHdl ( false )
,mbInDeselectHdl ( false )
{
sd/source/ui/dlg/brkdlg.cxx
+1
View File
@@ -45,6 +45,7 @@ BreakDlg::BreakDlg(
sal_uLong nSumActionCount,
sal_uLong nObjCount )
: SfxModalDialog(pWindow, "BreakDialog", "modules/sdraw/ui/breakdialog.ui")
, aIdle("sd BreakDlg Idle")
, mpProgress( nullptr )
{
get(m_pFiObjInfo, "metafiles");
sd/source/ui/framework/module/ShellStackGuard.cxx
+1 -1
View File
@@ -43,7 +43,7 @@ ShellStackGuard::ShellStackGuard (Reference<frame::XController>& rxController)
mxConfigurationController(),
mpBase(nullptr),
mpUpdateLock(),
maPrinterPollingIdle()
maPrinterPollingIdle("sd ShellStackGuard PrinterPollingIdle")
{
Reference<XControllerManager> xControllerManager (rxController, UNO_QUERY);
if (xControllerManager.is())
starmath/source/edit.cxx
+3 -1
View File
@@ -84,7 +84,9 @@ bool SmEditWindow::IsInlineEditEnabled()
SmEditWindow::SmEditWindow( SmCmdBoxWindow &rMyCmdBoxWin ) :
Window (&rMyCmdBoxWin),
DropTargetHelper ( this ),
rCmdBox (rMyCmdBoxWin)
rCmdBox (rMyCmdBoxWin),
aModifyIdle ("SmEditWindow ModifyIdle"),
aCursorMoveIdle ("SmEditWindow CursorMoveIdle")
{
SetHelpId(HID_SMA_COMMAND_WIN_EDIT);
SetMapMode(MAP_PIXEL);
svtools/source/misc/filechangedchecker.cxx
+1 -1
View File
@@ -13,7 +13,7 @@
FileChangedChecker::FileChangedChecker(const OUString& rFilename,
const ::std::function<void ()>& rCallback)
: mIdle()
: mIdle("SVTools FileChangedChecker Idle")
, mFileName(rFilename)
, mLastModTime()
, mpCallback(rCallback)
svx/source/dialog/_contdlg.cxx
+2
View File
@@ -212,6 +212,8 @@ void SvxContourDlg::Update( const Graphic& rGraphic, bool bGraphicLinked,
SvxSuperContourDlg::SvxSuperContourDlg(SfxBindings *_pBindings, SfxChildWindow *pCW,
vcl::Window* _pParent) :
SvxContourDlg ( _pBindings, pCW, _pParent ),
aUpdateIdle ( "SvxSuperContourDlg UpdateIdle" ),
aCreateIdle ( "SvxSuperContourDlg CreateIdle" ),
pUpdateEditingObject( nullptr ),
pCheckObj ( nullptr ),
aContourItem ( SID_CONTOUR_EXEC, *this, *_pBindings ),
svx/source/dialog/svxbmpnumvalueset.cxx
+1
View File
@@ -461,6 +461,7 @@ void SvxNumValueSet::SetOutlineNumberingSettings(
SvxBmpNumValueSet::SvxBmpNumValueSet(vcl::Window* pParent, WinBits nWinBits)
: SvxNumValueSet(pParent, nWinBits)
, aFormatIdle("SvxBmpNumValueSet FormatIdle")
{
init();
}
svx/source/sdr/overlay/overlaymanagerbuffered.cxx
+1
View File
@@ -379,6 +379,7 @@ namespace sdr
: OverlayManager(rOutputDevice),
mpBufferDevice(VclPtr<VirtualDevice>::Create()),
mpOutputBufferDevice(VclPtr<VirtualDevice>::Create()),
maBufferIdle("sdr overlay OverlayManagerBuffered Idle"),
mbRefreshWithPreRendering(bRefreshWithPreRendering)
{
// Init timer
svx/source/sidebar/PanelLayout.cxx
+1
View File
@@ -20,6 +20,7 @@ using namespace sfx2::sidebar;
PanelLayout::PanelLayout(vcl::Window* pParent, const OString& rID, const OUString& rUIXMLDescription, const css::uno::Reference<css::frame::XFrame> &rFrame)
: Control(pParent)
, m_aPanelLayoutIdle("svx sidebar PanelLayoutIdle")
, m_bInClose(false)
{
SetStyle(GetStyle() | WB_DIALOGCONTROL);
sw/source/core/doc/DocumentTimerManager.cxx
+2 -1
View File
@@ -39,7 +39,8 @@ namespace sw
DocumentTimerManager::DocumentTimerManager( SwDoc& i_rSwdoc ) : m_rDoc( i_rSwdoc ),
mbStartIdleTimer( false ),
mIdleBlockCount( 0 )
mIdleBlockCount( 0 ),
maIdle("DocumentTimerManagerIdleTimer")
{
maIdle.SetPriority( SchedulerPriority::LOWEST );
maIdle.SetIdleHdl( LINK( this, DocumentTimerManager, DoIdleJobs) );
sw/source/core/docnode/threadmanager.cxx
+1 -1
View File
@@ -37,7 +37,7 @@ ThreadManager::ThreadManager( uno::Reference< util::XJobManager >& rThreadJoiner
mnThreadIDCounter( 0 ),
maWaitingForStartThreads(),
maStartedThreads(),
maStartNewThreadIdle(),
maStartNewThreadIdle("SW ThreadManager StartNewThreadIdle"),
mbStartingOfThreadsSuspended( false )
{
}