cid#1662040 Variable copied when it could be moved

and

cid#1660117 Variable copied when it could be moved
cid#1659985 Variable copied when it could be moved
cid#1659983 Variable copied when it could be moved
cid#1659982 Variable copied when it could be moved
cid#1659973 Variable copied when it could be moved
cid#1659956 Variable copied when it could be moved
cid#1659955 Variable copied when it could be moved

Change-Id: Icc0f2f4a37fa8eb4c874dfd842650067c186466b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189255
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>

dbaccess/source/core/misc/DatabaseDataProvider.cxx

@@ -759,7 +759,7 @@ void DatabaseDataProvider::impl_fillInternalDataProvider_throw(bool _bHasCategor
                     k = 0;
                 aRow.push_back(fDefaultData[k]);
             }
-            aDataValues.push_back(aRow);
+            aDataValues.push_back(std::move(aRow));
         }
     }
 

helpcompiler/source/HelpCompiler.cxx

@@ -381,7 +381,7 @@ void myparser::traverse( xmlNodePtr parentNode )
                         trim(tmppos);
                         keyword = tmppre + ";" + tmppos;
                     }
-                    ll.push_back(keyword);
+                    ll.push_back(std::move(keyword));
                 }
                 if (!ll.empty())
                     (*keywords)[anchor] = std::move(ll);

sc/source/ui/sparklines/SparklineList.cxx

@@ -86,7 +86,7 @@ SparklineList::getSparklinesFor(std::shared_ptr<SparklineGroup> const& pSparklin
     {
         if (auto aSparkline = iterator->lock())
         {
-            toReturn.push_back(aSparkline);
+            toReturn.push_back(std::move(aSparkline));
             iterator++;
         }
         else

sfx2/source/doc/Metadatable.cxx

@@ -1455,7 +1455,7 @@ std::shared_ptr<MetadatableUndo> Metadatable::CreateUndo() const
 
 std::shared_ptr<MetadatableUndo> Metadatable::CreateUndoForDelete()
 {
-    std::shared_ptr<MetadatableUndo> const xUndo( CreateUndo() );
+    std::shared_ptr<MetadatableUndo> xUndo(CreateUndo());
     RemoveMetadataReference();
     return xUndo;
 }

sfx2/source/doc/SfxDocumentMetaData.cxx

@@ -954,7 +954,7 @@ propsToStrings(css::uno::Reference<css::beans::XPropertySet> const & i_xPropSet)
             SAL_WARN("sfx.doc", "Unsupported property type: " << any.getValueTypeName() );
             continue;
         }
-        attrs.push_back(as);
+        attrs.push_back(std::move(as));
     }
 
     return std::make_pair(comphelper::containerToSequence(values), attrs);

slideshow/source/engine/activitiesqueue.cxx

@@ -158,9 +158,9 @@ namespace slideshow::internal
                 }
 
                 if( bReinsert )
-                    maCurrentActivitiesReinsert.push_back( pActivity );
+                    maCurrentActivitiesReinsert.push_back(std::move(pActivity));
                 else
-                    maDequeuedActivities.push_back( pActivity );
+                    maDequeuedActivities.push_back(std::move(pActivity));
 
                 SAL_INFO("slideshow.verbose", "ActivitiesQueue: inner loop heartbeat" );
             }

vcl/source/image/ImplImageTree.cxx

@@ -189,7 +189,7 @@ void loadImageFromStream(std::shared_ptr<SvStream> const & xStream, OUString con
            else
         #endif
         vcl::bitmap::loadFromSvg(*xStream, rPath, aTmp, aScalePercentage / 100.0);
-        rParameters.mrBitmap = aTmp;
+        rParameters.mrBitmap = std::move(aTmp);
 
         if (bConvertToDarkTheme)
             BitmapFilter::Filter(rParameters.mrBitmap, BitmapLightenFilter());

xmloff/source/chart/SchXMLExport.cxx

@@ -3670,8 +3670,7 @@ void SchXMLExportHelper_Impl::exportDataPoints(
             }
 
             // if we get here the property states are empty
-            SchXMLDataPointStruct aPoint;
-            aDataPointVector.push_back( aPoint );
+            aDataPointVector.push_back(SchXMLDataPointStruct());
 
             nLastIndex = nCurrIndex;
         }
@@ -3681,7 +3680,7 @@ void SchXMLExportHelper_Impl::exportDataPoints(
         {
             SchXMLDataPointStruct aPoint;
             aPoint.mnRepeat = nRepeat;
-            aDataPointVector.push_back( aPoint );
+            aDataPointVector.push_back(std::move(aPoint));
         }
     }