ODFstudio/odfstudio
2
0
Fork 0
Code Issues Packages Activity

Remove legacy NEED_CLANG_LINUX_UBSAN_RTTI_VISIBILITY support

Browse Source 
...for ASan/UBSan builds using Clang older than current trunk twoards Clang 9,
as announced at
<https://lists.freedesktop.org/archives/libreoffice/2019-May/082654.html> "Re:
[Libreoffice-commits] core.git: The -fvisibility-ms-compat hack is no longer
needed for UBSan on Linux...".  (And drop the no longer needed
solenv/sanitizers/asan-suppressions, which people might still reference from
their ASAN_OPTIONS.)

Change-Id: Iedc0c5955366d2cbe7dc847990e2b1576750e85b
Reviewed-on: https://gerrit.libreoffice.org/72493
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
This commit is contained in:
Stephan Bergmann
2019-09-20 13:31:50 +02:00
parent 9b23171379
commit 28e028680b
37 changed files with 0 additions and 369 deletions
Download Patch File Download Diff File Expand all files Collapse all files
config_host.mk.in
-1
View File
@@ -408,7 +408,6 @@ export MWAW_LIBS=$(gb_SPACE)@MWAW_LIBS@
export MYTHES_CFLAGS=$(gb_SPACE)@MYTHES_CFLAGS@
export MYTHES_LIBS=$(gb_SPACE)@MYTHES_LIBS@
export NASM=@NASM@
export NEED_CLANG_LINUX_UBSAN_RTTI_VISIBILITY=@NEED_CLANG_LINUX_UBSAN_RTTI_VISIBILITY@
export NEON_CFLAGS=$(gb_SPACE)@NEON_CFLAGS@
export NEON_LIBS=$(gb_SPACE)@NEON_LIBS@
export NEON_VERSION=@NEON_VERSION@
configure.ac
-48
View File
@@ -3914,30 +3914,6 @@ else
fi
AC_SUBST(ENABLE_DEBUG)
AC_MSG_CHECKING([whether special RTTI visibility flags are needed for Clang Linux UBSan])
NEED_CLANG_LINUX_UBSAN_RTTI_VISIBILITY=
dnl Clang 9 is known fixed since
dnl <https://github.com/llvm/llvm-project/commit/5745eccef54ddd3caca278d1d292a88b2281528b> "Adapt
dnl -fsanitize=function to SANITIZER_NON_UNIQUE_TYPEINFO":
if test "$COM_IS_CLANG" = TRUE -a "$_os" = Linux; then
if test "$CLANGVER" -lt 90000; then
for i in $CC; do
case $i in
-fsanitize=*)
NEED_CLANG_LINUX_UBSAN_RTTI_VISIBILITY=TRUE
break
;;
esac
done
fi
fi
if test "$NEED_CLANG_LINUX_UBSAN_RTTI_VISIBILITY" = TRUE; then
AC_MSG_RESULT([yes])
else
AC_MSG_RESULT([no])
fi
AC_SUBST([NEED_CLANG_LINUX_UBSAN_RTTI_VISIBILITY])
dnl ===================================================================
dnl Select the linker to use (gold/lld/ld.bfd).
dnl This is done only after compiler checks (need to know if Clang is
@@ -3962,30 +3938,6 @@ printf ("hello world\n");
if test -n "$USE_LD"; then
AC_MSG_RESULT( yes )
use_ld_ok=yes
dnl For obscure reasons, unxgcc.mk uses the --dynamic-list-cpp-typeinfo linker option
dnl if NEED_CLANG_LINUX_UBSAN_RTTI_VISIBILITY, and lld doesn't support this option.
if test -n "$NEED_CLANG_LINUX_UBSAN_RTTI_VISIBILITY"; then
AC_MSG_CHECKING([for --dynamic-list-cpp-typeinfo linker support (-fuse-ld=$use_ld)])
use_ld_ldflags_save_2="$LDFLAGS"
LDFLAGS="$LDFLAGS -Wl,--dynamic-list-cpp-typeinfo"
use_ld_has_cpp_typeinfo=
AC_LINK_IFELSE([AC_LANG_PROGRAM([
#include <stdio.h>
],[
printf ("hello world\n");
])], use_ld_has_cpp_typeinfo=yes, [])
LDFLAGS="$use_ld_ldflags_save_2"
if test -n "$use_ld_has_cpp_typeinfo"; then
AC_MSG_RESULT( yes )
else
if test -n "$use_ld_fail_if_error"; then
AC_MSG_ERROR( no )
else
AC_MSG_RESULT( no )
fi
use_ld_ok=
fi
fi
else
if test -n "$use_ld_fail_if_error"; then
AC_MSG_ERROR( no )
external/libabw/UnpackedTarball_libabw.mk
Vendored
-8
View File
@@ -11,14 +11,6 @@ $(eval $(call gb_UnpackedTarball_UnpackedTarball,libabw))
$(eval $(call gb_UnpackedTarball_set_tarball,libabw,$(ABW_TARBALL)))
$(eval $(call gb_UnpackedTarball_set_patchlevel,libabw,0))
$(eval $(call gb_UnpackedTarball_update_autoconf_configs,libabw))
ifeq ($(NEED_CLANG_LINUX_UBSAN_RTTI_VISIBILITY),TRUE)
$(eval $(call gb_UnpackedTarball_add_patches,libabw, \
external/libabw/ubsan-visibility.patch \
))
endif
# vim: set noet sw=4 ts=4:
external/libabw/ubsan-visibility.patch
Vendored
-11
View File
@@ -1,11 +0,0 @@
--- configure
+++ configure
@@ -16635,7 +16635,7 @@
{ $as_echo "$as_me:${as_lineno-$LINENO}: checking for -fvisibility=hidden compiler flag" >&5
$as_echo_n "checking for -fvisibility=hidden compiler flag... " >&6; }
saved_CXXFLAGS="$CXXFLAGS"
- CXXFLAGS="$CXXFLAGS -fvisibility=hidden"
+ CXXFLAGS="$CXXFLAGS -fvisibility-ms-compat"
cat confdefs.h - <<_ACEOF >conftest.$ac_ext
/* end confdefs.h. */
external/libcdr/UnpackedTarball_libcdr.mk
Vendored
-6
View File
@@ -25,10 +25,4 @@ $(eval $(call gb_UnpackedTarball_add_patches,libcdr, \
external/libcdr/ubsan.patch \
))
ifeq ($(NEED_CLANG_LINUX_UBSAN_RTTI_VISIBILITY),TRUE)
$(eval $(call gb_UnpackedTarball_add_patches,libcdr, \
external/libcdr/ubsan-visibility.patch \
))
endif
# vim: set noet sw=4 ts=4:
external/libcdr/ubsan-visibility.patch
Vendored
-11
View File
@@ -1,11 +0,0 @@
--- configure
+++ configure
@@ -17651,7 +17641,7 @@
{ $as_echo "$as_me:${as_lineno-$LINENO}: checking for -fvisibility=hidden compiler flag" >&5
$as_echo_n "checking for -fvisibility=hidden compiler flag... " >&6; }
saved_CXXFLAGS="$CXXFLAGS"
- CXXFLAGS="$CXXFLAGS -fvisibility=hidden"
+ CXXFLAGS="$CXXFLAGS -fvisibility-ms-compat"
cat confdefs.h - <<_ACEOF >conftest.$ac_ext
/* end confdefs.h. */
external/libebook/UnpackedTarball_libebook.mk
Vendored
-8
View File
@@ -11,14 +11,6 @@ $(eval $(call gb_UnpackedTarball_UnpackedTarball,libebook))
$(eval $(call gb_UnpackedTarball_set_tarball,libebook,$(EBOOK_TARBALL)))
$(eval $(call gb_UnpackedTarball_set_patchlevel,libebook,0))
$(eval $(call gb_UnpackedTarball_update_autoconf_configs,libebook))
ifeq ($(NEED_CLANG_LINUX_UBSAN_RTTI_VISIBILITY),TRUE)
$(eval $(call gb_UnpackedTarball_add_patches,libebook, \
external/libebook/ubsan-visibility.patch \
))
endif
# vim: set noet sw=4 ts=4:
external/libebook/ubsan-visibility.patch
Vendored
-11
View File
@@ -1,11 +0,0 @@
--- configure
+++ configure
@@ -17254,7 +17254,7 @@
{ $as_echo "$as_me:${as_lineno-$LINENO}: checking for -fvisibility=hidden compiler flag" >&5
$as_echo_n "checking for -fvisibility=hidden compiler flag... " >&6; }
saved_CXXFLAGS="$CXXFLAGS"
- CXXFLAGS="$CXXFLAGS -fvisibility=hidden"
+ CXXFLAGS="$CXXFLAGS -fvisibility-ms-compat"
cat confdefs.h - <<_ACEOF >conftest.$ac_ext
/* end confdefs.h. */
external/libepubgen/UnpackedTarball_libepubgen.mk
Vendored
-4
View File
@@ -10,10 +10,6 @@
epubgen_patches :=
epubgen_patches += tdf-120491.patch
ifeq ($(NEED_CLANG_LINUX_UBSAN_RTTI_VISIBILITY),TRUE)
epubgen_patches += ubsan-visibility.patch
endif
$(eval $(call gb_UnpackedTarball_UnpackedTarball,libepubgen))
$(eval $(call gb_UnpackedTarball_set_tarball,libepubgen,$(EPUBGEN_TARBALL)))
external/libepubgen/ubsan-visibility.patch
Vendored
-11
View File
@@ -1,11 +0,0 @@
--- configure
+++ configure
@@ -18425,7 +18425,7 @@
{ $as_echo "$as_me:${as_lineno-$LINENO}: checking for -fvisibility=hidden compiler flag" >&5
$as_echo_n "checking for -fvisibility=hidden compiler flag... " >&6; }
saved_CXXFLAGS="$CXXFLAGS"
- CXXFLAGS="$CXXFLAGS -fvisibility=hidden"
+ CXXFLAGS="$CXXFLAGS -fvisibility-ms-compat"
cat confdefs.h - <<_ACEOF >conftest.$ac_ext
/* end confdefs.h. */
external/libetonyek/UnpackedTarball_libetonyek.mk
Vendored
-6
View File
@@ -32,10 +32,4 @@ endif
endif
endif
ifeq ($(NEED_CLANG_LINUX_UBSAN_RTTI_VISIBILITY),TRUE)
$(eval $(call gb_UnpackedTarball_add_patches,libetonyek, \
external/libetonyek/ubsan-visibility.patch \
))
endif
# vim: set noet sw=4 ts=4:
external/libetonyek/ubsan-visibility.patch
Vendored
-11
View File
@@ -1,11 +0,0 @@
--- configure
+++ configure
@@ -17443,7 +17443,7 @@
{ $as_echo "$as_me:${as_lineno-$LINENO}: checking for -fvisibility=hidden compiler flag" >&5
$as_echo_n "checking for -fvisibility=hidden compiler flag... " >&6; }
saved_CXXFLAGS="$CXXFLAGS"
- CXXFLAGS="$CXXFLAGS -fvisibility=hidden"
+ CXXFLAGS="$CXXFLAGS -fvisibility-ms-compat"
cat confdefs.h - <<_ACEOF >conftest.$ac_ext
/* end confdefs.h. */
external/libfreehand/UnpackedTarball_libfreehand.mk
Vendored
-8
View File
@@ -11,14 +11,6 @@ $(eval $(call gb_UnpackedTarball_UnpackedTarball,libfreehand))
$(eval $(call gb_UnpackedTarball_set_tarball,libfreehand,$(FREEHAND_TARBALL)))
$(eval $(call gb_UnpackedTarball_set_patchlevel,libfreehand,0))
$(eval $(call gb_UnpackedTarball_update_autoconf_configs,libfreehand))
ifeq ($(NEED_CLANG_LINUX_UBSAN_RTTI_VISIBILITY),TRUE)
$(eval $(call gb_UnpackedTarball_add_patches,libfreehand, \
external/libfreehand/ubsan-visibility.patch \
))
endif
# vim: set noet sw=4 ts=4:
external/libfreehand/ubsan-visibility.patch
Vendored
-11
View File
@@ -1,11 +0,0 @@
--- configure
+++ configure
@@ -18369,7 +18369,7 @@
{ $as_echo "$as_me:${as_lineno-$LINENO}: checking for -fvisibility=hidden compiler flag" >&5
$as_echo_n "checking for -fvisibility=hidden compiler flag... " >&6; }
saved_CXXFLAGS="$CXXFLAGS"
- CXXFLAGS="$CXXFLAGS -fvisibility=hidden"
+ CXXFLAGS="$CXXFLAGS -fvisibility-ms-compat"
cat confdefs.h - <<_ACEOF >conftest.$ac_ext
/* end confdefs.h. */
external/libmspub/UnpackedTarball_libmspub.mk
Vendored
-6
View File
@@ -28,10 +28,4 @@ $(eval $(call gb_UnpackedTarball_add_patches,libmspub, \
))
endif
ifeq ($(NEED_CLANG_LINUX_UBSAN_RTTI_VISIBILITY),TRUE)
$(eval $(call gb_UnpackedTarball_add_patches,libmspub, \
external/libmspub/ubsan-visibility.patch \
))
endif
# vim: set noet sw=4 ts=4:
external/libmspub/ubsan-visibility.patch
Vendored
-11
View File
@@ -1,11 +0,0 @@
--- configure
+++ configure
@@ -17060,7 +17060,7 @@
{ $as_echo "$as_me:${as_lineno-$LINENO}: checking for -fvisibility=hidden compiler flag" >&5
$as_echo_n "checking for -fvisibility=hidden compiler flag... " >&6; }
saved_CXXFLAGS="$CXXFLAGS"
- CXXFLAGS="$CXXFLAGS -fvisibility=hidden"
+ CXXFLAGS="$CXXFLAGS -fvisibility-ms-compat"
cat confdefs.h - <<_ACEOF >conftest.$ac_ext
/* end confdefs.h. */
external/libmwaw/UnpackedTarball_libmwaw.mk
Vendored
-6
View File
@@ -15,12 +15,6 @@ $(eval $(call gb_UnpackedTarball_set_patchlevel,libmwaw,0))
$(eval $(call gb_UnpackedTarball_update_autoconf_configs,libmwaw))
ifeq ($(NEED_CLANG_LINUX_UBSAN_RTTI_VISIBILITY),TRUE)
$(eval $(call gb_UnpackedTarball_add_patches,libmwaw, \
external/libmwaw/ubsan-visibility.patch \
))
endif
ifneq ($(OS),MACOSX)
ifneq ($(OS),WNT)
$(eval $(call gb_UnpackedTarball_add_patches,libmwaw, \
external/libmwaw/ubsan-visibility.patch
Vendored
-11
View File
@@ -1,11 +0,0 @@
--- configure
+++ configure
@@ -17225,7 +17225,7 @@
{ $as_echo "$as_me:${as_lineno-$LINENO}: checking for -fvisibility=hidden compiler flag" >&5
$as_echo_n "checking for -fvisibility=hidden compiler flag... " >&6; }
saved_CXXFLAGS="$CXXFLAGS"
- CXXFLAGS="$CXXFLAGS -fvisibility=hidden"
+ CXXFLAGS="$CXXFLAGS -fvisibility-ms-compat"
cat confdefs.h - <<_ACEOF >conftest.$ac_ext
/* end confdefs.h. */
external/libodfgen/UnpackedTarball_libodfgen.mk
Vendored
-6
View File
@@ -15,12 +15,6 @@ $(eval $(call gb_UnpackedTarball_set_patchlevel,libodfgen,0))
$(eval $(call gb_UnpackedTarball_update_autoconf_configs,libodfgen))
ifeq ($(NEED_CLANG_LINUX_UBSAN_RTTI_VISIBILITY),TRUE)
$(eval $(call gb_UnpackedTarball_add_patches,libodfgen, \
external/libodfgen/ubsan-visibility.patch \
))
endif
ifeq ($(SYSTEM_REVENGE),)
$(eval $(call gb_UnpackedTarball_add_patches,libodfgen, \
external/libodfgen/rpath.patch \
external/libodfgen/ubsan-visibility.patch
Vendored
-11
View File
@@ -1,11 +0,0 @@
--- configure
+++ configure
@@ -15721,7 +15721,7 @@
{ $as_echo "$as_me:${as_lineno-$LINENO}: checking for -fvisibility=hidden compiler flag" >&5
$as_echo_n "checking for -fvisibility=hidden compiler flag... " >&6; }
saved_CXXFLAGS="$CXXFLAGS"
- CXXFLAGS="$CXXFLAGS -fvisibility=hidden"
+ CXXFLAGS="$CXXFLAGS -fvisibility-ms-compat"
cat confdefs.h - <<_ACEOF >conftest.$ac_ext
/* end confdefs.h. */
external/libpagemaker/UnpackedTarball_libpagemaker.mk
Vendored
-8
View File
@@ -11,14 +11,6 @@ $(eval $(call gb_UnpackedTarball_UnpackedTarball,libpagemaker))
$(eval $(call gb_UnpackedTarball_set_tarball,libpagemaker,$(PAGEMAKER_TARBALL)))
$(eval $(call gb_UnpackedTarball_set_patchlevel,libpagemaker,0))
$(eval $(call gb_UnpackedTarball_update_autoconf_configs,libpagemaker))
ifeq ($(NEED_CLANG_LINUX_UBSAN_RTTI_VISIBILITY),TRUE)
$(eval $(call gb_UnpackedTarball_add_patches,libpagemaker, \
external/libpagemaker/ubsan-visibility.patch \
))
endif
# vim: set noet sw=4 ts=4:
external/libpagemaker/ubsan-visibility.patch
Vendored
-11
View File
@@ -1,11 +0,0 @@
--- configure
+++ configure
@@ -16787,7 +16787,7 @@
{ $as_echo "$as_me:${as_lineno-$LINENO}: checking for -fvisibility=hidden compiler flag" >&5
$as_echo_n "checking for -fvisibility=hidden compiler flag... " >&6; }
saved_CXXFLAGS="$CXXFLAGS"
- CXXFLAGS="$CXXFLAGS -fvisibility=hidden"
+ CXXFLAGS="$CXXFLAGS -fvisibility-ms-compat"
cat confdefs.h - <<_ACEOF >conftest.$ac_ext
/* end confdefs.h. */
external/libqxp/UnpackedTarball_libqxp.mk
Vendored
-8
View File
@@ -11,16 +11,8 @@ $(eval $(call gb_UnpackedTarball_UnpackedTarball,libqxp))
$(eval $(call gb_UnpackedTarball_set_tarball,libqxp,$(QXP_TARBALL)))
$(eval $(call gb_UnpackedTarball_set_patchlevel,libqxp,0))
$(eval $(call gb_UnpackedTarball_update_autoconf_configs,libqxp))
ifeq ($(NEED_CLANG_LINUX_UBSAN_RTTI_VISIBILITY),TRUE)
$(eval $(call gb_UnpackedTarball_add_patches,libqxp, \
external/libqxp/ubsan-visibility.patch \
))
endif
$(eval $(call gb_UnpackedTarball_add_patches,libqxp, \
external/libqxp/android-workaround.patch.1 \
))
external/libqxp/ubsan-visibility.patch
Vendored
-11
View File
@@ -1,11 +0,0 @@
--- configure
+++ configure
@@ -16787,7 +16787,7 @@
{ $as_echo "$as_me:${as_lineno-$LINENO}: checking for -fvisibility=hidden compiler flag" >&5
$as_echo_n "checking for -fvisibility=hidden compiler flag... " >&6; }
saved_CXXFLAGS="$CXXFLAGS"
- CXXFLAGS="$CXXFLAGS -fvisibility=hidden"
+ CXXFLAGS="$CXXFLAGS -fvisibility-ms-compat"
cat confdefs.h - <<_ACEOF >conftest.$ac_ext
/* end confdefs.h. */
external/librevenge/UnpackedTarball_librevenge.mk
Vendored
-6
View File
@@ -19,12 +19,6 @@ $(eval $(call gb_UnpackedTarball_add_patches,librevenge, \
external/librevenge/rpath.patch \
))
ifeq ($(NEED_CLANG_LINUX_UBSAN_RTTI_VISIBILITY),TRUE)
$(eval $(call gb_UnpackedTarball_add_patches,librevenge, \
external/librevenge/ubsan-visibility.patch \
))
endif
ifneq ($(OS),MACOSX)
ifneq ($(OS),WNT)
$(eval $(call gb_UnpackedTarball_add_patches,librevenge, \
external/librevenge/ubsan-visibility.patch
Vendored
-11
View File
@@ -1,11 +0,0 @@
--- src/lib/Makefile.in
+++ src/lib/Makefile.in
@@ -79,7 +79,7 @@
POST_UNINSTALL = :
build_triplet = @build@
host_triplet = @host@
-@HAVE_VISIBILITY_TRUE@am__append_1 = -fvisibility=hidden
+@HAVE_VISIBILITY_TRUE@am__append_1 = -fvisibility-ms-compat
@HAVE_VISIBILITY_TRUE@am__append_2 = -DLIBREVENGE_VISIBILITY
@BUILD_GENERATORS_TRUE@am__append_3 = librevenge-generators-@RVNG_MAJOR_VERSION@.@RVNG_MINOR_VERSION@.la
@BUILD_GENERATORS_TRUE@@HAVE_VISIBILITY_TRUE@am__append_4 = -DLIBREVENGE_GENERATORS_VISIBILITY
external/libstaroffice/UnpackedTarball_libstaroffice.mk
Vendored
-6
View File
@@ -15,12 +15,6 @@ $(eval $(call gb_UnpackedTarball_set_patchlevel,libstaroffice,0))
$(eval $(call gb_UnpackedTarball_update_autoconf_configs,libstaroffice))
ifeq ($(NEED_CLANG_LINUX_UBSAN_RTTI_VISIBILITY),TRUE)
$(eval $(call gb_UnpackedTarball_add_patches,libstaroffice, \
external/libstaroffice/ubsan-visibility.patch \
))
endif
ifneq ($(OS),MACOSX)
ifneq ($(OS),WNT)
$(eval $(call gb_UnpackedTarball_add_patches,libstaroffice, \
external/libstaroffice/ubsan-visibility.patch
Vendored
-11
View File
@@ -1,11 +0,0 @@
--- configure
+++ configure
@@ -17225,7 +17225,7 @@
{ $as_echo "$as_me:${as_lineno-$LINENO}: checking for -fvisibility=hidden compiler flag" >&5
$as_echo_n "checking for -fvisibility=hidden compiler flag... " >&6; }
saved_CXXFLAGS="$CXXFLAGS"
- CXXFLAGS="$CXXFLAGS -fvisibility=hidden"
+ CXXFLAGS="$CXXFLAGS -fvisibility-ms-compat"
cat confdefs.h - <<_ACEOF >conftest.$ac_ext
/* end confdefs.h. */
external/libvisio/UnpackedTarball_libvisio.mk
Vendored
-6
View File
@@ -19,10 +19,4 @@ $(eval $(call gb_UnpackedTarball_add_patches,libvisio, \
external/libvisio/ubsan.patch \
))
ifeq ($(NEED_CLANG_LINUX_UBSAN_RTTI_VISIBILITY),TRUE)
$(eval $(call gb_UnpackedTarball_add_patches,libvisio, \
external/libvisio/ubsan-visibility.patch \
))
endif
# vim: set noet sw=4 ts=4:
external/libvisio/ubsan-visibility.patch
Vendored
-11
View File
@@ -1,11 +0,0 @@
--- configure
+++ configure
@@ -17847,7 +17847,7 @@
{ $as_echo "$as_me:${as_lineno-$LINENO}: checking for -fvisibility=hidden compiler flag" >&5
$as_echo_n "checking for -fvisibility=hidden compiler flag... " >&6; }
saved_CXXFLAGS="$CXXFLAGS"
- CXXFLAGS="$CXXFLAGS -fvisibility=hidden"
+ CXXFLAGS="$CXXFLAGS -fvisibility-ms-compat"
cat confdefs.h - <<_ACEOF >conftest.$ac_ext
/* end confdefs.h. */
external/libwps/UnpackedTarball_libwps.mk
Vendored
-6
View File
@@ -28,10 +28,4 @@ $(eval $(call gb_UnpackedTarball_add_patches,libwps,\
endif
endif
ifeq ($(NEED_CLANG_LINUX_UBSAN_RTTI_VISIBILITY),TRUE)
$(eval $(call gb_UnpackedTarball_add_patches,libwps, \
external/libwps/ubsan-visibility.patch.0 \
))
endif
# vim: set noet sw=4 ts=4:
external/libwps/ubsan-visibility.patch.0
Vendored
-11
View File
@@ -1,11 +0,0 @@
--- configure
+++ configure
@@ -16632,7 +16632,7 @@
{ $as_echo "$as_me:${as_lineno-$LINENO}: checking for -fvisibility=hidden compiler flag" >&5
$as_echo_n "checking for -fvisibility=hidden compiler flag... " >&6; }
saved_CXXFLAGS="$CXXFLAGS"
- CXXFLAGS="$CXXFLAGS -fvisibility=hidden"
+ CXXFLAGS="$CXXFLAGS -fvisibility-ms-compat"
cat confdefs.h - <<_ACEOF >conftest.$ac_ext
/* end confdefs.h. */
external/libzmf/UnpackedTarball_libzmf.mk
Vendored
-8
View File
@@ -11,16 +11,8 @@ $(eval $(call gb_UnpackedTarball_UnpackedTarball,libzmf))
$(eval $(call gb_UnpackedTarball_set_tarball,libzmf,$(ZMF_TARBALL)))
$(eval $(call gb_UnpackedTarball_set_patchlevel,libzmf,0))
$(eval $(call gb_UnpackedTarball_update_autoconf_configs,libzmf))
ifeq ($(NEED_CLANG_LINUX_UBSAN_RTTI_VISIBILITY),TRUE)
$(eval $(call gb_UnpackedTarball_add_patches,libzmf, \
external/libzmf/ubsan-visibility.patch \
))
endif
$(eval $(call gb_UnpackedTarball_add_patches,libzmf, \
external/libzmf/android-workaround.patch.1 \
))
external/libzmf/ubsan-visibility.patch
Vendored
-11
View File
@@ -1,11 +0,0 @@
--- configure
+++ configure
@@ -16787,7 +16787,7 @@
{ $as_echo "$as_me:${as_lineno-$LINENO}: checking for -fvisibility=hidden compiler flag" >&5
$as_echo_n "checking for -fvisibility=hidden compiler flag... " >&6; }
saved_CXXFLAGS="$CXXFLAGS"
- CXXFLAGS="$CXXFLAGS -fvisibility=hidden"
+ CXXFLAGS="$CXXFLAGS -fvisibility-ms-compat"
cat confdefs.h - <<_ACEOF >conftest.$ac_ext
/* end confdefs.h. */
solenv/gbuild/platform/com_GCC_defs.mk
-4
View File
@@ -126,12 +126,8 @@ endif
# If CC or CXX already include -fvisibility=hidden, don't duplicate it
ifeq (,$(filter -fvisibility=hidden,$(CC)))
ifeq ($(NEED_CLANG_LINUX_UBSAN_RTTI_VISIBILITY),TRUE)
gb_VISIBILITY_FLAGS := -fvisibility-ms-compat
else
gb_VISIBILITY_FLAGS := -fvisibility=hidden
endif
endif
gb_VISIBILITY_FLAGS_CXX := -fvisibility-inlines-hidden
gb_CXXFLAGS_COMMON += $(gb_VISIBILITY_FLAGS_CXX)
solenv/gbuild/platform/unxgcc.mk
-3
View File
@@ -84,9 +84,6 @@ endif
ifneq ($(HAVE_LD_BSYMBOLIC_FUNCTIONS),)
gb_LinkTarget_LDFLAGS += -Wl,-Bsymbolic-functions
ifeq ($(NEED_CLANG_LINUX_UBSAN_RTTI_VISIBILITY),TRUE)
gb_LinkTarget_LDFLAGS += -Wl,--dynamic-list-cpp-typeinfo
endif
endif
gb_LINKEROPTFLAGS := -Wl,-O1
solenv/sanitizers/asan-suppressions
-31
View File
@@ -1,31 +0,0 @@
# [CUT] cppcanvas_emfplus
# =================================================================
# ==32735==ERROR: AddressSanitizer: odr-violation (0x7f8f717e28a0):
# [1] size=40 'vtable for graphite2::CachedFace' /home/sbergman/lo/core/workdir/UnpackedTarball/graphite/src/CachedFace.cpp
# [2] size=40 'vtable for graphite2::CachedFace' /home/sbergman/lo/core/workdir/UnpackedTarball/graphite/src/CachedFace.cpp
# These globals were registered at these points:
# [1]:
# #0 in __asan_register_globals.part.13 at /home/sbergman/github.com/llvm-project/llvm-project-20170507/compiler-rt/lib/asan/asan_globals.cc:359:3 (workdir/LinkTarget/Executable/cppunittester +0x446ff0)
# #1 in asan.module_ctor at <null> (instdir/program/libvclplug_gtk3lo.so +0xed96cb)
#
# [2]:
# #0 in __asan_register_globals.part.13 at /home/sbergman/github.com/llvm-project/llvm-project-20170507/compiler-rt/lib/asan/asan_globals.cc:359:3 (workdir/LinkTarget/Executable/cppunittester +0x446ff0)
# #1 in asan.module_ctor at <null> (instdir/program/libvcllo.so +0x6e169cb)
#
# ...and more (partly because -fvisibility-ms-compat (and "-XClang -ftype-visibility -XClang
# default", which it internally uses) also gives _ZTV* symbols default visibility):
odr_violation:^_ZTIN9graphite210CachedCmapE$
odr_violation:^_ZTSN9graphite210CachedCmapE$
odr_violation:^_ZTVN9graphite210CachedCmapE$
odr_violation:^_ZTSN9graphite210CachedFaceE$
odr_violation:^_ZTIN9graphite210CachedFaceE$
odr_violation:^_ZTVN9graphite210CachedFaceE$
odr_violation:^_ZTIN9graphite210DirectCmapE$
odr_violation:^_ZTSN9graphite210DirectCmapE$
odr_violation:^_ZTVN9graphite210DirectCmapE$
odr_violation:^_ZTSN9graphite24FaceE$
odr_violation:^_ZTIN9graphite24FaceE$
odr_violation:^_ZTVN9graphite24FaceE$
odr_violation:^_ZTSN9graphite24FontE$
odr_violation:^_ZTIN9graphite24FontE$
odr_violation:^_ZTVN9graphite24FontE$