loplugin:unusedfields make some fields private

Change-Id: Ia30e3b7f10ae11c7a74e6860ac0a6115caaa439f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143529 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-12-01 21:28:53 +01:00
parent 8e33793d72
commit 224fc96609
7 changed files with 5 additions and 13 deletions
@@ -437,11 +437,9 @@ public:

 class SVTXFormattedField : public VCLXSpinField
 {
-protected:
    rtl::Reference<SvNumberFormatsSupplierObj> m_xCurrentSupplier;
    bool                    bIsStandardSupplier;
-
-    sal_Int32                   nKeyToSetDelayed;
+    sal_Int32               nKeyToSetDelayed;

 public:
    SVTXFormattedField();
@@ -40,11 +40,9 @@ namespace utl
    {
        friend class OEventListenerImpl;

-    private:
        OEventListenerAdapter( const OEventListenerAdapter& _rSource ) = delete;
        const OEventListenerAdapter& operator=( const OEventListenerAdapter& _rSource ) = delete;

-    protected:
        std::unique_ptr<OEventListenerAdapterImpl>  m_pImpl;

    protected:
@@ -45,9 +45,8 @@ typedef InheritedHelperInterfaceWeakImpl< ov::XDialogBase > VbaDialogBase_BASE;

 class VBAHELPER_DLLPUBLIC VbaDialogBase : public VbaDialogBase_BASE
 {
-protected:
    sal_Int32 mnIndex;
-        css::uno::Reference< css::frame::XModel > m_xModel;
+    css::uno::Reference< css::frame::XModel > m_xModel;
 public:
    VbaDialogBase( const css::uno::Reference< ov::XHelperInterface >& xParent, const css::uno::Reference< css::uno::XComponentContext >& xContext, css::uno::Reference< css::frame::XModel > xModel, sal_Int32 nIndex ):VbaDialogBase_BASE( xParent, xContext ), mnIndex( nIndex ), m_xModel(std::move( xModel )) {}

@@ -53,10 +53,9 @@ class MessBox : public ButtonDialog
    Image maImage;
    bool mbHelpBtn;
    MessBoxStyle mnMessBoxStyle;
-
-protected:
    OUString maMessText;

+protected:
    void ImplInitButtons();
    void ImplPosControls();

@@ -149,7 +149,6 @@ class DynamicResultSetWrapperListener
                : public cppu::OWeakObject
                , public css::ucb::XDynamicResultSetListener
 {
-protected:
    DynamicResultSetWrapper*    m_pOwner;
    osl::Mutex                  m_aMutex;

@@ -177,14 +177,13 @@ public:
    virtual void abort() = 0;

 protected:
-    rtl::Reference< DAVSessionFactory > m_xFactory;
-
    explicit DAVSession( rtl::Reference< DAVSessionFactory > xFactory )
        : m_xFactory(std::move( xFactory )), m_nRefCount( 0 ) {}

    virtual ~DAVSession() {}

 private:
+    rtl::Reference< DAVSessionFactory > m_xFactory;
    DAVSessionFactory::Map::iterator m_aContainerIt;
    oslInterlockedCount m_nRefCount;

@@ -48,7 +48,6 @@ typedef ::cppu::WeakImplHelper< css::io::XTempFile

 class OTempFileService : public OTempFileBase
 {
-protected:
    std::optional<utl::TempFileNamed> mpTempFile;
    std::mutex maMutex;
    SvStream* mpStream;
@@ -56,6 +55,7 @@ protected:
    bool mbInClosed;
    bool mbOutClosed;

+protected:
    void checkError () const;
    void checkConnected ();