loplugin:moveparam in forms

Change-Id: Ib3a6058e933eb7030cd6d7aef335f12fbd4e6bd3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123417
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

forms/source/component/ListBox.cxx

@@ -321,7 +321,7 @@ namespace frm
             // propagate
             if ( m_eListSourceType == ListSourceType_VALUELIST )
             {
-                setBoundValues(m_aListSourceValues);
+                setBoundValues(std::vector(m_aListSourceValues));
             }
             else
             {
@@ -1000,7 +1000,7 @@ namespace frm
             m_nNULLPos = 0;
         }
 
-        setBoundValues(aValueList);
+        setBoundValues(std::move(aValueList));
 
         setFastPropertyValue( PROPERTY_ID_STRINGITEMLIST, makeAny( lcl_convertToStringSequence( aDisplayList ) ) );
         setFastPropertyValue( PROPERTY_ID_TYPEDITEMLIST, makeAny( css::uno::Sequence<css::uno::Any>() ) );
@@ -1037,10 +1037,10 @@ namespace frm
     }
 
 
-    void OListBoxModel::setBoundValues(const ValueList &l)
+    void OListBoxModel::setBoundValues(ValueList && l)
     {
         m_aConvertedBoundValues.clear();
-        m_aBoundValues = l;
+        m_aBoundValues = std::move(l);
     }
 
 

forms/source/component/ListBox.hxx

@@ -214,7 +214,7 @@ private:
     */
     void        impl_refreshDbEntryList( bool _bForce );
 
-    void        setBoundValues(const ValueList&);
+    void        setBoundValues(ValueList &&);
     void        clearBoundValues();
 
     ValueList   impl_getValues() const;