cid#1556583 COPY_INSTEAD_OF_MOVE

and cid#1556585 COPY_INSTEAD_OF_MOVE cid#1556588 COPY_INSTEAD_OF_MOVE cid#1556593 COPY_INSTEAD_OF_MOVE cid#1556597 COPY_INSTEAD_OF_MOVE cid#1556605 COPY_INSTEAD_OF_MOVE cid#1556617 COPY_INSTEAD_OF_MOVE cid#1556635 COPY_INSTEAD_OF_MOVE cid#1556790 COPY_INSTEAD_OF_MOVE cid#1556792 COPY_INSTEAD_OF_MOVE cid#1556796 COPY_INSTEAD_OF_MOVE cid#1556799 COPY_INSTEAD_OF_MOVE cid#1556815 COPY_INSTEAD_OF_MOVE cid#1556836 COPY_INSTEAD_OF_MOVE cid#1556840 COPY_INSTEAD_OF_MOVE cid#1556842 COPY_INSTEAD_OF_MOVE cid#1556859 COPY_INSTEAD_OF_MOVE cid#1556860 COPY_INSTEAD_OF_MOVE cid#1556866 COPY_INSTEAD_OF_MOVE cid#1556869 COPY_INSTEAD_OF_MOVE cid#1556870 COPY_INSTEAD_OF_MOVE Change-Id: I3df8698a4aecbb03999c084517e37e12ff46ee97 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171435 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-08-04 15:38:31 +02:00
parent 2bb84e874b
commit 1b61a652c1
20 changed files with 23 additions and 21 deletions
@@ -1816,7 +1816,7 @@ void SbiRuntime::StepSET_Impl( SbxVariableRef& refVal, SbxVariableRef& refVar, b

            if( refObjVal.is() )
            {
-                refVal = refObjVal;
+                refVal = std::move(refObjVal);
            }
            else if( !(eValType & SbxARRAY) )
            {
@@ -264,7 +264,7 @@ void ExtensionManager::addExtensionsToMap(
        {
            std::vector<Reference<css::deployment::XPackage> > vec(3);
            vec[index] = xExtension;
-            mapExt[id] = vec;
+            mapExt[id] = std::move(vec);
        }
        else
        {
@@ -76,7 +76,7 @@ bool SvMetaAttribute::ReadSvIdl( SvIdlDataBase & rBase,
        {
            tools::SvRef<SvMetaType> xT(new SvMetaType() );
            xT->SetRef( GetType() );
-            aType = xT;
+            aType = std::move(xT);
            bOk = aType->ReadMethodArgs( rBase, rInStm );
        }
        if( bOk )
@@ -369,7 +369,8 @@ void loadDiagram( ShapePtr const & pShape,
        if (!rLayoutPath.isEmpty())
        {
            rtl::Reference< core::FragmentHandler > xRefLayout(
-                    new DiagramLayoutFragmentHandler( rFilter, rLayoutPath, pLayout ));
+                    new DiagramLayoutFragmentHandler( rFilter, rLayoutPath,
+                                                      std::move(pLayout) ));

            importFragment(rFilter,
                    loadFragment(rFilter,xRefLayout),
@@ -132,7 +132,7 @@ void TextCharacterProperties::pushToPropMap( PropertyMap& rPropMap, const XmlFil
            //            then this is contoured text in LO.
            if (nLineTransparency < aColor.getTransparency()
                || (bContoured = aColor.getColor(rFilter.getGraphicHelper()) == COL_WHITE))
-                aColor = aLineColor;
+                aColor = std::move(aLineColor);
        }
        rPropMap.setProperty(PROP_CharColor, aColor.getColor(rFilter.getGraphicHelper()));

@@ -318,7 +318,7 @@ StorageRef OleStorage::implOpenSubStorage( const OUString& rElementName, bool bC
            if( xSubStorage )
                xSubStorage->copyStorageToStorage( *xTempStorage );
            // return the temp storage to caller
-            xSubStorage = xTempStorage;
+            xSubStorage = std::move(xTempStorage);
        }
        catch(const Exception& )
        {
@@ -389,7 +389,7 @@ void ScColumn::duplicateSparkline(sc::CopyFromClipContext& rContext, sc::ColumnB
        {
            auto pNewSparkline = std::make_shared<sc::Sparkline>(aCurrentPosition.Col(), aCurrentPosition.Row(), pDuplicatedGroup);
            pNewSparkline->setInputRange(pSparkline->getInputRange());
-            aSparklines[i] = new sc::SparklineCell(pNewSparkline);
+            aSparklines[i] = new sc::SparklineCell(std::move(pNewSparkline));
            aCurrentPosition.IncRow();
        }

@@ -5083,7 +5083,7 @@ std::unique_ptr<ScTokenArray> ScCompiler::CompileString( const OUString& rFormul
        if( ScTokenConversion::ConvertToTokenArray( rDoc, aTokenArray, aTokenSeq ) )
        {
            // remember pArr, in case a subsequent CompileTokenArray() is executed.
-            std::unique_ptr<ScTokenArray> pNew(new ScTokenArray( aTokenArray ));
+            std::unique_ptr<ScTokenArray> pNew(new ScTokenArray( std::move(aTokenArray) ));
            // coverity[escape : FALSE] - ownership of pNew is retained by caller, so pArr remains valid
            pArr = pNew.get();
            maArrIterator = FormulaTokenArrayPlainIterator(*pArr);
@@ -80,7 +80,7 @@ void ExtCfRuleContext::onStartElement( const AttributeList& rAttribs )
            xRule->importCfvo( rAttribs );
            xRule->getModel().mbIsLower = mbFirstEntry;
            mbFirstEntry = false;
-            mpRule = xRule;
+            mpRule = std::move(xRule);
            break;
        }
        default:
@@ -814,7 +814,7 @@ void ScCellShell::ExecuteDB( SfxRequest& rReq )
            auto xDoc = o3tl::make_shared<ScDocument>();
            xDoc->InsertTab(0, u"test"_ustr);
            ScDocument& rDoc = GetViewData().GetDocument();
-            ScDataProviderDlg aDialog(pTabViewShell->GetDialogParent(), xDoc, &rDoc);
+            ScDataProviderDlg aDialog(pTabViewShell->GetDialogParent(), std::move(xDoc), &rDoc);
            if (aDialog.run() == RET_OK)
            {
                aDialog.import(rDoc);
@@ -1253,7 +1253,8 @@ void ScViewFunc::MergeCells( bool bApi, bool bDoContents, bool bCenter,

    bool bEmptyMergedCells = officecfg::Office::Calc::Compatibility::MergeCells::EmptyMergedCells::get();

-    auto doMerge = [this, pDocSh, aMergeOption, bApi, nStartCol, nStartRow, aMarkRange]
+    auto doMerge = [this, pDocSh, aMergeOption=std::move(aMergeOption),
+                    bApi, nStartCol, nStartRow, aMarkRange]
        (bool bNowDoContents, bool bNowEmptyMergedCells)
    {
        if (pDocSh->GetDocFunc().MergeCells(aMergeOption, bNowDoContents, true/*bRecord*/,
@@ -144,7 +144,7 @@ void MasterPageObserver::Implementation::RegisterDocument (
    }

    bool bAlreadyExists = maUsedMasterPages.find(&rDocument) != maUsedMasterPages.end();
-    maUsedMasterPages[&rDocument] = aMasterPageSet;
+    maUsedMasterPages[&rDocument] = std::move(aMasterPageSet);

    if (!bAlreadyExists)
        StartListening (rDocument);
@@ -280,7 +280,7 @@ void MasterPageObserver::Implementation::AnalyzeUsedMasterPages (
    }

    // Store the new list of master pages.
-    aOldMasterPagesDescriptor->second = aCurrentMasterPages;
+    aOldMasterPagesDescriptor->second = std::move(aCurrentMasterPages);
 }

 void MasterPageObserver::Implementation::SendEvent (
@@ -299,7 +299,7 @@ ErrCode SmXMLImportWrapper::ReadThroughComponent(const Reference<io::XInputStrea
        {
            xml::sax::SAXException aTmp;
            if (aSaxEx.WrappedException >>= aTmp)
-                aSaxEx = aTmp;
+                aSaxEx = std::move(aTmp);
            else
                bTryChild = false;
        }
@@ -99,7 +99,7 @@ OUString URIHelper::SmartRel2Abs(INetURLObject const & rTheBaseURIRef,
                    bMaybeFile = rMaybeFileHdl.Call(&aFilePath);
                }
                if (!bMaybeFile)
-                    aAbsURIRef = aNonFileURIRef;
+                    aAbsURIRef = std::move(aNonFileURIRef);
            }
        }
    }
@@ -703,7 +703,7 @@ void E3dDragMove::MoveSdrDrag(const Point& rPnt)
                aNewTrans *= rCandidate.maInvDisplayTransform;

                // ...and apply
-                rCandidate.maTransform = aNewTrans;
+                rCandidate.maTransform = std::move(aNewTrans);

                if(mbMoveFull)
                {
@@ -176,7 +176,7 @@ rtl::Reference<SdrAttrObj> E3dExtrudeObj::GetBreakObj()

    if(aFrontSide.count())
    {
-        aBackSide = aFrontSide;
+        aBackSide = std::move(aFrontSide);

        if(GetExtrudeDepth())
        {
@@ -1364,7 +1364,7 @@ SwPasteContext::~SwPasteContext()
            return;

        // Invoke the listeners.
-        uno::Sequence<beans::PropertyValue> aEvent{ aPropertyValue };
+        uno::Sequence<beans::PropertyValue> aEvent{ std::move(aPropertyValue) };
        m_rWrtShell.GetPasteListeners().notifyEach( &css::text::XPasteListener::notifyPasteEvent, aEvent );
    }
    catch (const uno::Exception& rException)
@@ -1585,7 +1585,7 @@ void Content::insert(
    if ( bNewId )
    {
        m_xIdentifier = new ::ucbhelper::ContentIdentifier( aNewURL );
-        m_aUri = aNewUri;
+        m_aUri = std::move(aNewUri);
    }

    if ( !storeData( xStream ) )
@@ -250,7 +250,7 @@ bool TextSearch::SearchBackward( const OUString & rStr, sal_Int32* pStart,
                *pEnd = aRet.startOffset[ 0 ];
                *pStart = aRet.endOffset[ 0 ];
                if( pRes )
-                    *pRes = aRet;
+                    *pRes = std::move(aRet);
            }
        }
    }
@@ -453,7 +453,7 @@ bool PDFSignatureHelper::ReadAndVerifySignatureSvStream(SvStream& rStream)
        std::unique_ptr<vcl::pdf::PDFiumSignature> pSignature = pPdfDocument->getSignature(i);
        std::vector<std::pair<size_t, size_t>> aByteRanges;
        GetByteRangesFromPDF(pSignature, aByteRanges);
-        aSignatures[i] = Signature{ std::move(pSignature), aByteRanges };
+        aSignatures[i] = Signature{ std::move(pSignature), std::move(aByteRanges) };
    }

    std::set<unsigned int> aSignatureEOFs;