ODFstudio/odfstudio
2
0
Fork 0
Code Issues Packages Activity

Fix two memory leaks in Signing::Sign() when timestamping signatures.

Browse Source 
Change-Id: I85dcfbb601b9cf86d00715201d1d91e40f9fd987
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191570
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
This commit is contained in:
Juraj Šarinay
2025-09-29 09:05:46 +02:00
committed by Miklos Vajna
parent 86168b986e
commit 1a92fc1f8f
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
svl/source/crypto/cryptosign.cxx
+2 -2
View File
@@ -1079,7 +1079,7 @@ bool Signing::Sign(OStringBuffer& rCMSHexBuffer)
src.messageImprint.hashAlgorithm.algorithm.data = nullptr;
src.messageImprint.hashAlgorithm.parameters.data = nullptr;
SECOID_SetAlgorithmID(nullptr, &src.messageImprint.hashAlgorithm, SEC_OID_SHA256, nullptr);
SECOID_SetAlgorithmID(arena, &src.messageImprint.hashAlgorithm, SEC_OID_SHA256, nullptr);
src.messageImprint.hashedMessage = ts_digest;
src.reqPolicy.type = siBuffer;
@@ -1215,7 +1215,7 @@ bool Signing::Sign(OStringBuffer& rCMSHexBuffer)
response_item.data = reinterpret_cast<unsigned char*>(const_cast<char*>(response_buffer.getStr()));
response_item.len = response_buffer.getLength();
if (SEC_ASN1DecodeItem(nullptr, &response, TimeStampResp_Template, &response_item) != SECSuccess)
if (SEC_ASN1DecodeItem(arena, &response, TimeStampResp_Template, &response_item) != SECSuccess)
{
SAL_WARN("svl.crypto", "SEC_ASN1DecodeItem failed");
return false;