More loplugin:simplifybool
...found with (trunk) libc++ on macOS, where the standard library iterator implementations are apparently sufficiently different to libstdc++ to find more cases of !(... == ...) vs. ... != ... Change-Id: Ia3861406aa584c7b1d33f47448190b5cf2e770f7 Reviewed-on: https://gerrit.libreoffice.org/68089 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
This commit is contained in:
@@ -2219,7 +2219,7 @@ extern "C" void typelib_typedescriptionreference_getByName(
|
||||
{
|
||||
MutexGuard aGuard( rInit.getMutex() );
|
||||
WeakMap_Impl::const_iterator aIt = rInit.pWeakMap->find( pName->buffer );
|
||||
if( !(aIt == rInit.pWeakMap->end()) ) // != failed on msc4.2
|
||||
if( aIt != rInit.pWeakMap->end() )
|
||||
{
|
||||
sal_Int32 n = osl_atomic_increment( &(*aIt).second->nRefCount );
|
||||
if( n > 1 )
|
||||
|
||||
@@ -62,7 +62,7 @@ void XMLChartOASISTransformerContext::StartElement(
|
||||
XMLTransformerActions::key_type aKey( nPrefix, aLocalName );
|
||||
XMLTransformerActions::const_iterator aIter =
|
||||
pActions->find( aKey );
|
||||
if( !(aIter == pActions->end() ) )
|
||||
if( aIter != pActions->end() )
|
||||
{
|
||||
if( !pMutableAttrList )
|
||||
{
|
||||
|
||||
@@ -63,7 +63,7 @@ void XMLChartOOoTransformerContext::StartElement(
|
||||
XMLTransformerActions::key_type aKey( nPrefix, aLocalName );
|
||||
XMLTransformerActions::const_iterator aIter =
|
||||
pActions->find( aKey );
|
||||
if( !(aIter == pActions->end() ) )
|
||||
if( aIter != pActions->end() )
|
||||
{
|
||||
if( !pMutableAttrList )
|
||||
{
|
||||
|
||||
@@ -70,7 +70,7 @@ void XMLControlOASISTransformerContext::StartElement(
|
||||
XMLTransformerActions::key_type aKey( nPrefix, aLocalName );
|
||||
XMLTransformerActions::const_iterator aIter =
|
||||
pActions->find( aKey );
|
||||
if( !(aIter == pActions->end() ) )
|
||||
if( aIter != pActions->end() )
|
||||
{
|
||||
if( !pMutableAttrList )
|
||||
{
|
||||
|
||||
@@ -69,7 +69,7 @@ void XMLCreateElemTransformerContext::StartElement(
|
||||
XMLTransformerActions::key_type aKey( nPrefix, aLocalName );
|
||||
XMLTransformerActions::const_iterator aIter =
|
||||
pActions->find( aKey );
|
||||
if( !(aIter == pActions->end() ) )
|
||||
if( aIter != pActions->end() )
|
||||
{
|
||||
if( !pMutableAttrList )
|
||||
{
|
||||
|
||||
@@ -86,7 +86,7 @@ rtl::Reference<XMLTransformerContext> XMLPersElemContentTContext::CreateChildCon
|
||||
XMLTransformerActions::const_iterator aIter =
|
||||
GetTransformer().GetElemActions().find( aKey );
|
||||
|
||||
if( !(aIter == GetTransformer().GetElemActions().end()) )
|
||||
if( aIter != GetTransformer().GetElemActions().end() )
|
||||
{
|
||||
switch( (*aIter).second.m_nActionType )
|
||||
{
|
||||
|
||||
@@ -64,7 +64,7 @@ void XMLDlgOASISTransformerContext::StartElement(
|
||||
XMLTransformerActions::const_iterator aIter =
|
||||
pActions->find( aKey );
|
||||
|
||||
if( !(aIter == pActions->end() ) )
|
||||
if( aIter != pActions->end() )
|
||||
{
|
||||
if( !pMutableAttrList )
|
||||
{
|
||||
|
||||
@@ -111,7 +111,7 @@ OUString XMLEventOASISTransformerContext::GetEventName(
|
||||
{
|
||||
XMLTransformerOASISEventMap_Impl::const_iterator aIter =
|
||||
pMap2->find( aKey );
|
||||
if( !(aIter == pMap2->end()) )
|
||||
if( aIter != pMap2->end() )
|
||||
return (*aIter).second;
|
||||
}
|
||||
|
||||
@@ -185,7 +185,7 @@ void XMLEventOASISTransformerContext::StartElement(
|
||||
XMLTransformerActions::key_type aKey( nPrefix, aLocalName );
|
||||
XMLTransformerActions::const_iterator aIter =
|
||||
pActions->find( aKey );
|
||||
if( !(aIter == pActions->end() ) )
|
||||
if( aIter != pActions->end() )
|
||||
{
|
||||
if( !pMutableAttrList )
|
||||
{
|
||||
|
||||
@@ -147,7 +147,7 @@ void XMLEventOOoTransformerContext::StartElement(
|
||||
XMLTransformerActions::key_type aKey( nPrefix, aLocalName );
|
||||
XMLTransformerActions::const_iterator aIter =
|
||||
pActions->find( aKey );
|
||||
if( !(aIter == pActions->end() ) )
|
||||
if( aIter != pActions->end() )
|
||||
{
|
||||
if( !pMutableAttrList )
|
||||
{
|
||||
|
||||
@@ -122,7 +122,7 @@ void XMLFormPropOASISTransformerContext::StartElement(
|
||||
XMLTransformerActions::key_type aKey( nPrefix, aLocalName );
|
||||
XMLTransformerActions::const_iterator aIter =
|
||||
pActions->find( aKey );
|
||||
if( !(aIter == pActions->end() ) )
|
||||
if( aIter != pActions->end() )
|
||||
{
|
||||
const OUString& rAttrValue = xAttrList->getValueByIndex( i );
|
||||
switch( (*aIter).second.m_nActionType )
|
||||
|
||||
@@ -165,7 +165,7 @@ void XMLFormPropOOoTransformerContext::StartElement(
|
||||
XMLTransformerActions::key_type aKey( nPrefix, aLocalName );
|
||||
XMLTransformerActions::const_iterator aIter =
|
||||
pActions->find( aKey );
|
||||
if( !(aIter == pActions->end() ) )
|
||||
if( aIter != pActions->end() )
|
||||
{
|
||||
const OUString& rAttrValue = rAttrList->getValueByIndex( i );
|
||||
switch( (*aIter).second.m_nActionType )
|
||||
|
||||
@@ -128,7 +128,7 @@ rtl::Reference<XMLTransformerContext> XMLFrameOASISTransformerContext::CreateChi
|
||||
XMLTransformerActions::key_type aKey( nPrefix, rLocalName );
|
||||
XMLTransformerActions::const_iterator aIter = pActions->find( aKey );
|
||||
|
||||
if( !(aIter == pActions->end()) )
|
||||
if( aIter != pActions->end() )
|
||||
{
|
||||
switch( (*aIter).second.m_nActionType )
|
||||
{
|
||||
|
||||
@@ -73,7 +73,7 @@ void XMLFrameOOoTransformerContext::StartElement(
|
||||
XMLTransformerActions::key_type aKey( nPrefix, aLocalName );
|
||||
XMLTransformerActions::const_iterator aIter =
|
||||
pActions->find( aKey );
|
||||
if( !(aIter == pActions->end() ) )
|
||||
if( aIter != pActions->end() )
|
||||
{
|
||||
const OUString& rAttrValue = xAttrList->getValueByIndex( i );
|
||||
switch( (*aIter).second.m_nActionType )
|
||||
@@ -110,7 +110,7 @@ rtl::Reference<XMLTransformerContext> XMLFrameOOoTransformerContext::CreateChild
|
||||
XMLTransformerActions::key_type aKey( nPrefix, rLocalName );
|
||||
XMLTransformerActions::const_iterator aIter = pActions->find( aKey );
|
||||
|
||||
if( !(aIter == pActions->end()) )
|
||||
if( aIter != pActions->end() )
|
||||
{
|
||||
switch( (*aIter).second.m_nActionType )
|
||||
{
|
||||
|
||||
@@ -170,7 +170,7 @@ rtl::Reference<XMLTransformerContext> XMLMergeElemTransformerContext::CreateChil
|
||||
XMLTransformerActions::const_iterator aIter =
|
||||
pActions->find( aKey );
|
||||
|
||||
if( !(aIter == pActions->end()) )
|
||||
if( aIter != pActions->end() )
|
||||
{
|
||||
switch( (*aIter).second.m_nActionType )
|
||||
{
|
||||
@@ -223,7 +223,7 @@ rtl::Reference<XMLTransformerContext> XMLMergeElemTransformerContext::CreateChil
|
||||
XMLTransformerActions::const_iterator aIter =
|
||||
pActions->find( aKey );
|
||||
|
||||
if( !(aIter == pActions->end()) )
|
||||
if( aIter != pActions->end() )
|
||||
{
|
||||
switch( (*aIter).second.m_nActionType )
|
||||
{
|
||||
|
||||
@@ -75,7 +75,7 @@ void XMLNotesTransformerContext::StartElement(
|
||||
XMLTransformerActions::key_type aKey( nPrefix, aLocalName );
|
||||
XMLTransformerActions::const_iterator aIter =
|
||||
pActions->find( aKey );
|
||||
if( !(aIter == pActions->end() ) )
|
||||
if( aIter != pActions->end() )
|
||||
{
|
||||
const OUString& rAttrValue = xAttrList->getValueByIndex( i );
|
||||
|
||||
|
||||
@@ -1317,7 +1317,7 @@ void XMLTabStopOOoTContext_Impl::StartElement(
|
||||
XMLTransformerActions::key_type aKey( nPrefix, aLocalName );
|
||||
XMLTransformerActions::const_iterator aIter =
|
||||
pActions->find( aKey );
|
||||
if( !(aIter == pActions->end() ) )
|
||||
if( aIter != pActions->end() )
|
||||
{
|
||||
if( !pMutableAttrList )
|
||||
{
|
||||
|
||||
@@ -1328,7 +1328,7 @@ void XMLTabStopOASISTContext_Impl::StartElement(
|
||||
XMLTransformerActions::key_type aKey( nPrefix, aLocalName );
|
||||
XMLTransformerActions::const_iterator aIter =
|
||||
pActions->find( aKey );
|
||||
if( !(aIter == pActions->end() ) )
|
||||
if( aIter != pActions->end() )
|
||||
{
|
||||
if( !pMutableAttrList )
|
||||
{
|
||||
|
||||
@@ -156,7 +156,7 @@ void XMLPropertiesTContext_Impl::StartElement(
|
||||
XMLTransformerActions::key_type aKey( nPrefix, aLocalName );
|
||||
XMLTransformerActions::const_iterator aIter =
|
||||
pActions->find( aKey );
|
||||
if( !(aIter == pActions->end() ) )
|
||||
if( aIter != pActions->end() )
|
||||
{
|
||||
switch( (*aIter).second.m_nActionType )
|
||||
{
|
||||
@@ -803,7 +803,7 @@ void XMLStyleOASISTContext::StartElement(
|
||||
XMLTransformerActions::key_type aKey( nPrefix, aLocalName );
|
||||
XMLTransformerActions::const_iterator aIter =
|
||||
pActions->find( aKey );
|
||||
if( !(aIter == pActions->end() ) )
|
||||
if( aIter != pActions->end() )
|
||||
{
|
||||
if( !pMutableAttrList )
|
||||
{
|
||||
|
||||
@@ -302,7 +302,7 @@ XMLTypedPropertiesOOoTContext_Impl
|
||||
XMLTransformerActions::const_iterator aIter =
|
||||
pActions->find( aKey );
|
||||
|
||||
if( !(aIter == pActions->end()) )
|
||||
if( aIter != pActions->end() )
|
||||
{
|
||||
rAction = (*aIter).second;
|
||||
nIndex = i;
|
||||
@@ -1127,7 +1127,7 @@ void XMLStyleOOoTContext::StartElement(
|
||||
XMLTransformerActions::key_type aKey( nPrefix, aLocalName );
|
||||
XMLTransformerActions::const_iterator aIter =
|
||||
pActions->find( aKey );
|
||||
if( !(aIter == pActions->end() ) )
|
||||
if( aIter != pActions->end() )
|
||||
{
|
||||
if( !pMutableAttrList )
|
||||
{
|
||||
|
||||
@@ -77,7 +77,7 @@ XMLTransformerContext *XMLTransformerBase::CreateContext( sal_uInt16 nPrefix,
|
||||
XMLTransformerActions::const_iterator aIter =
|
||||
GetElemActions().find( aKey );
|
||||
|
||||
if( !(aIter == GetElemActions().end()) )
|
||||
if( aIter != GetElemActions().end() )
|
||||
{
|
||||
sal_uInt32 nActionType = (*aIter).second.m_nActionType;
|
||||
if( (nActionType & XML_ETACTION_USER_DEFINED) != 0 )
|
||||
@@ -487,7 +487,7 @@ XMLMutableAttributeList *XMLTransformerBase::ProcessAttrList(
|
||||
XMLTransformerActions::key_type aKey( nPrefix, aLocalName );
|
||||
XMLTransformerActions::const_iterator aIter =
|
||||
pActions->find( aKey );
|
||||
if( !(aIter == pActions->end() ) )
|
||||
if( aIter != pActions->end() )
|
||||
{
|
||||
if( !pMutableAttrList )
|
||||
{
|
||||
|
||||
Reference in New Issue
Block a user