cid#1556875 COPY_INSTEAD_OF_MOVE

and

cid#1556891 COPY_INSTEAD_OF_MOVE
cid#1556903 COPY_INSTEAD_OF_MOVE
cid#1556917 COPY_INSTEAD_OF_MOVE
cid#1556925 COPY_INSTEAD_OF_MOVE
cid#1557021 COPY_INSTEAD_OF_MOVE
cid#1557092 COPY_INSTEAD_OF_MOVE
cid#1557119 COPY_INSTEAD_OF_MOVE
cid#1557218 COPY_INSTEAD_OF_MOVE
cid#1557342 COPY_INSTEAD_OF_MOVE
cid#1557727 COPY_INSTEAD_OF_MOVE
cid#1557800 COPY_INSTEAD_OF_MOVE
cid#1557821 COPY_INSTEAD_OF_MOVE
cid#1557830 COPY_INSTEAD_OF_MOVE
cid#1557677 COPY_INSTEAD_OF_MOVE
cid#1557674 COPY_INSTEAD_OF_MOVE

Change-Id: I20dab0c49a17c28b4feaf97440a36d4962310b29
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175686
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

accessibility/source/extended/AccessibleGridControl.cxx

@@ -163,7 +163,7 @@ AccessibleGridControl::getAccessibleAtPoint( const awt::Point& rPoint )
 
             if (xCurrChildComp.is()
                 && VCLUnoHelper::ConvertToVCLRect(xCurrChildComp->getBounds()).Contains(aPoint))
-                xChild = xCurrChild;
+                xChild = std::move(xCurrChild);
         }
     }
     return xChild;

chart2/source/tools/StatisticsHelper.cxx

@@ -200,7 +200,7 @@ uno::Reference< chart2::data::XLabeledDataSequence > StatisticsHelper::getErrorL
     uno::Reference< chart2::data::XLabeledDataSequence > xLSeq =
         lcl_getErrorBarLabeledSequence( xDataSource, bPositiveValue, bYError, aRole );
     if( xLSeq.is())
-        xResult = xLSeq;
+        xResult = std::move(xLSeq);
 
     return xResult;
 }

comphelper/source/container/container.cxx

@@ -99,7 +99,7 @@ css::uno::Reference< css::uno::XInterface> const & IndexAccessIterator::Next()
                         break;
                     }
                     // Finally, if there's nothing more to do in this row (to the right), we'll move on to the next row.
-                    xSearchLoop = xParent;
+                    xSearchLoop = std::move(xParent);
                     bCheckingStartingPoint = false;
                 }
 

cppuhelper/source/component_context.cxx

@@ -410,11 +410,11 @@ void ComponentContext::disposing(std::unique_lock<std::mutex>& rGuard)
             {
                 if ( rName == TDMGR_SINGLETON )
                 {
-                    xTDMgr = xComp;
+                    xTDMgr = std::move(xComp);
                 }
                 else if ( rName == AC_SINGLETON )
                 {
-                    xAC = xComp;
+                    xAC = std::move(xComp);
                 }
                 else // dispose immediately
                 {

framework/source/uiconfiguration/moduleuiconfigurationmanager.cxx

@@ -821,7 +821,7 @@ void ModuleUIConfigurationManager::impl_Initialize()
 
         m_aUIElements[LAYER_DEFAULT][i].nElementType = i;
         m_aUIElements[LAYER_DEFAULT][i].bModified = false;
-        m_aUIElements[LAYER_DEFAULT][i].xStorage = xElementTypeStorage;
+        m_aUIElements[LAYER_DEFAULT][i].xStorage = std::move(xElementTypeStorage);
     }
 }
 

framework/source/uielement/complextoolbarcontroller.cxx

@@ -110,7 +110,7 @@ void SAL_CALL ComplexToolbarController::execute( sal_Int16 KeyModifier )
     {
         // Execute dispatch asynchronously
         ExecuteInfo* pExecuteInfo = new ExecuteInfo;
-        pExecuteInfo->xDispatch     = xDispatch;
+        pExecuteInfo->xDispatch     = std::move(xDispatch);
         pExecuteInfo->aTargetURL    = std::move(aTargetURL);
         pExecuteInfo->aArgs         = aArgs;
         Application::PostUserEvent( LINK(nullptr, ComplexToolbarController , ExecuteHdl_Impl), pExecuteInfo );

io/source/stm/odata.cxx

@@ -888,7 +888,7 @@ void OObjectOutputStream::connectToMarkable()
         Reference < XMarkableStream > markable( rTry , UNO_QUERY );
         if( markable.is() )
         {
-            m_rMarkable = markable;
+            m_rMarkable = std::move(markable);
             break;
         }
         Reference < XActiveDataSource > source( rTry , UNO_QUERY );

sc/source/filter/excel/excimp8.cxx

@@ -130,7 +130,7 @@ public:
         uno::Reference< container::XIndexContainer > xElement;
         if ( ! ( aElement >>= xElement ) )
             throw lang::IllegalArgumentException();
-        it->second = xElement;
+        it->second = std::move(xElement);
     }
 };
 

sd/source/ui/animations/CustomAnimationList.cxx

@@ -928,7 +928,7 @@ void CustomAnimationList::append( CustomAnimationEffectPtr pEffect )
             mxTreeView->insert(nullptr, -1, &aDescription, &sId, nullptr, nullptr, false, xEntry.get());
 
             // and the new root entry becomes the possible next group header
-            mxLastTargetShape = xTargetShape;
+            mxLastTargetShape = std::move(xTargetShape);
             mnLastGroupId = nGroupId;
             mxLastParentEntry = std::move(xEntry);
         }

sfx2/source/doc/docfile.cxx

@@ -2408,7 +2408,7 @@ bool SfxMedium::TryDirectTransfer( const OUString& aURL, SfxItemSet const & aTar
                     ::ucbhelper::Content aTargetContent( aURL, xEnv, comphelper::getProcessComponentContext() );
 
                     InsertCommandArgument aInsertArg;
-                    aInsertArg.Data = xInStream;
+                    aInsertArg.Data = std::move(xInStream);
                     const SfxBoolItem* pOverWrite = aTargetSet.GetItem<SfxBoolItem>(SID_OVERWRITE, false);
                     if ( pOverWrite && !pOverWrite->GetValue() ) // argument says: never overwrite
                         aInsertArg.ReplaceExisting = false;

svx/source/form/fmpgeimp.cxx

@@ -135,7 +135,7 @@ namespace
                 throw RuntimeException( u"Found inconsistent form component hierarchies (2)!"_ustr );
 
             if ( lhsControlModel.is() )
-                m_rControlModelMap[ lhsControlModel ] = rhsControlModel;
+                m_rControlModelMap[ lhsControlModel ] = std::move(rhsControlModel);
         }
 
     private:

testtools/source/bridgetest/bridgetest.cxx

@@ -1245,7 +1245,7 @@ sal_Int32 TestBridgeImpl::run( const Sequence< OUString > & rArgs )
                     rArgs[0], m_xContext);
             }
             if (!stress) {
-                xOriginal = o;
+                xOriginal = std::move(o);
                 break;
             }
         }

unotools/source/misc/eventlisteneradapter.cxx

@@ -67,7 +67,7 @@ namespace utl
         _rxComp->addEventListener(xMeMyselfAndI);
 
         m_xComponent = _rxComp;
-        m_xKeepMeAlive = xMeMyselfAndI;
+        m_xKeepMeAlive = std::move(xMeMyselfAndI);
     }
 
     void OEventListenerImpl::dispose()

unoxml/source/dom/saxbuilder.cxx

@@ -100,7 +100,7 @@ namespace DOM
         m_aDocument = ownerDoc;
         Reference< XDocumentFragment > aFragment = m_aDocument->createDocumentFragment();
         m_aNodeStack.push(aFragment);
-        m_aFragment = aFragment;
+        m_aFragment = std::move(aFragment);
         m_aState = SAXDocumentBuilderState_BUILDING_FRAGMENT;
     }
 

unoxml/source/rdf/CLiteral.cxx

@@ -120,7 +120,7 @@ void SAL_CALL CLiteral::initialize(const css::uno::Sequence< css::uno::Any > & a
             throw css::lang::IllegalArgumentException(
                 u"CLiteral::initialize: argument is null"_ustr, *this, 1);
         }
-        m_xDatatype = xURI;
+        m_xDatatype = std::move(xURI);
     } else {
         throw css::lang::IllegalArgumentException(
             u"CLiteral::initialize: argument must be string or URI"_ustr, *this, 1);

vcl/source/app/weldutils.cxx

@@ -500,7 +500,7 @@ WidgetStatusListener::WidgetStatusListener(weld::Widget* widget, const OUString&
     if (!xFrame.is())
         xFrame = xDesktop;
 
-    mxFrame = xFrame;
+    mxFrame = std::move(xFrame);
 
     maCommandURL.Complete = aCommand;
     css::uno::Reference<css::util::XURLTransformer> xParser