make some classes private

Change-Id: Icfce56436aafa14fe923b4d35835ed6dee52afba
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99624
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

bin/find-can-be-private-symbols.classes.results

@@ -63,7 +63,6 @@ ScFormatEntry
 ScPaintHint
 ScPreviewShell
 ScRefreshTimer
-SdAbstractDialogFactory
 SdOptionsItem
 SdOptionsLayout
 SdOptionsMisc
@@ -170,6 +169,8 @@ basegfx::MinimalSystemDependentDataManager
 canvas
 chart::PopupRequest
 comphelper::RefCountedMutex
+comphelper::service_decl
+comphelper::service_decl::ServiceDecl
 comphelper::service_decl::ServiceDecl::Factory
 connectivity::component::OComponentPreparedStatement
 connectivity::component::OComponentStatement
@@ -220,6 +221,16 @@ formula::FormulaMissingToken
 formula::FormulaTokenIterator::Item
 formula::FormulaTypedDoubleToken
 formula::FormulaUnknownToken
+framework::AddonMenuManager
+framework::ConfigAccess
+framework::ConstItemContainer
+framework::Converter
+framework::HandlerCache
+framework::MenuConfiguration
+framework::SaxNamespaceFilter
+framework::StatusBarConfiguration
+framework::ToolBoxConfiguration
+framework::TransactionManager
 jvmaccess::UnoVirtualMachine::CreationException
 jvmaccess::VirtualMachine::AttachGuard::CreationException
 linguistic::PropertyChgHelper
@@ -243,9 +254,6 @@ sdr::animation::primitiveAnimator
 sdr::contact::ObjectContactPainter
 sfx2::sidebar::Panel
 sfx2::sidebar::SidebarToolBox
-svt::ControlBase
-svt::EditControlBase
-svt::MultiLineTextCell
 svtools::ToolbarPopup
 svx::CommonStyleManager
 svx::PropertyValueProvider
@@ -265,4 +273,3 @@ writerperfect::DirectoryStream::Impl
 xmloff::OControlBorderHandler
 xmloff::OFontWidthHandler
 xmloff::ORotationAngleHandler
-xmlsecurity::pdfio

include/svx/gallerybinaryengineentry.hxx

@@ -27,7 +27,7 @@
 
 class GalleryStorageLocations;
 
-class SVXCORE_DLLPUBLIC GalleryBinaryEngineEntry
+class GalleryBinaryEngineEntry
 {
 private:
     GalleryStorageLocations& m_rGalleryStorageLocations;
@@ -43,8 +43,7 @@ public:
     const INetURLObject& GetSdvURL() const { return m_rGalleryStorageLocations.GetSdvURL(); }
     const INetURLObject& GetStrURL() const { return m_rGalleryStorageLocations.GetStrURL(); }
 
-    SAL_DLLPRIVATE static GalleryThemeEntry* CreateThemeEntry(const INetURLObject& rURL,
-                                                              bool bReadOnly);
+    static GalleryThemeEntry* CreateThemeEntry(const INetURLObject& rURL, bool bReadOnly);
 };
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */

include/svx/gallerystoragelocations.hxx

@@ -22,7 +22,7 @@
 #include <tools/urlobj.hxx>
 #include <svx/svxdllapi.h>
 
-class SVXCORE_DLLPUBLIC GalleryStorageLocations
+class GalleryStorageLocations
 {
 private:
     INetURLObject maThmURL;

include/toolkit/awt/vclxwindows.hxx

@@ -623,7 +623,7 @@ public:
 
 //  class VCLXEdit
 
-class UNLESS_MERGELIBS(TOOLKIT_DLLPUBLIC) VCLXEdit :  public css::awt::XTextComponent,
+class VCLXEdit :  public css::awt::XTextComponent,
                     public css::awt::XTextEditField,
                     public css::awt::XTextLayoutConstrains,
                     public VCLXWindow
@@ -831,8 +831,7 @@ public:
 
 //  class VCLXSpinField
 
-class UNLESS_MERGELIBS(TOOLKIT_DLLPUBLIC) VCLXSpinField : public css::awt::XSpinField,
-                        public VCLXEdit
+class VCLXSpinField : public css::awt::XSpinField, public VCLXEdit
 {
 private:
     SpinListenerMultiplexer maSpinListeners;
@@ -897,7 +896,7 @@ public:
 
 //  class VCLXDateField
 
-class UNLESS_MERGELIBS(TOOLKIT_DLLPUBLIC) VCLXDateField : public css::awt::XDateField,
+class VCLXDateField : public css::awt::XDateField,
                         public VCLXFormattedSpinField
 {
 protected:

include/vcl/toolkit/field.hxx

@@ -468,14 +468,14 @@ public:
     bool             IsEnforceValidValue( ) const { return mbEnforceValidValue; }
 };
 
-class UNLESS_MERGELIBS(VCL_DLLPUBLIC) DateField : public SpinField, public DateFormatter
+class DateField : public SpinField, public DateFormatter
 {
 private:
     Date                    maFirst;
     Date                    maLast;
 
 protected:
-    SAL_DLLPRIVATE void     ImplDateSpinArea( bool bUp );
+    void                    ImplDateSpinArea( bool bUp );
 
 public:
     explicit                DateField( vcl::Window* pParent, WinBits nWinStyle );

vcl/inc/jsdialog/jsdialogbuilder.hxx

@@ -135,7 +135,7 @@ public:
     }
 };
 
-class VCL_DLLPUBLIC JSDialog : public JSWidget<SalInstanceDialog, ::Dialog>
+class JSDialog : public JSWidget<SalInstanceDialog, ::Dialog>
 {
 public:
     JSDialog(VclPtr<vcl::Window> aOwnedToplevel, ::Dialog* pDialog, SalInstanceBuilder* pBuilder,