ODFstudio/odfstudio
2
0
Fork 0
Code Issues Packages Activity

tdf#132160 sw_redlinehide: more pathological redline problems

Browse Source 
This is similar to 63dba5203e except here
the redline starts with a section (in particular an entire alphabetical
index); this one is at node 13489 to node 14206.

There's another fun one, starts with a table but has a text node
following it, at node 8222 to 8231; this case also wasn't handled
correctly at least in one direction.  Fix that by continuing iteration
of text-nodes once table/section at the start are handled.

(regression from d258fc2956)

Change-Id: I3f75ad473881f01be80d2c3804b9ac209f430bdf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101287
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@cib.de>
This commit is contained in:
Michael Stahl
2020-08-25 16:31:30 +02:00
committed by Michael Stahl
parent 15988fe00c
commit 0bbc397dc5
1 changed files with 38 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files
sw/source/core/doc/DocumentRedlineManager.cxx
+38 -16
View File
@@ -140,24 +140,38 @@ void UpdateFramesForAddDeleteRedline(SwDoc & rDoc, SwPaM const& rPam)
// no need to call UpdateFootnoteNums for FTNNUM_PAGE:
// the AppendFootnote/RemoveFootnote will do it by itself!
rDoc.GetFootnoteIdxs().UpdateFootnote(rPam.Start()->nNode);
SwTextNode *const pStartNode(rPam.Start()->nNode.GetNode().GetTextNode());
if (!pStartNode)
SwPosition currentStart(*rPam.Start());
SwTextNode * pStartNode(rPam.Start()->nNode.GetNode().GetTextNode());
while (!pStartNode)
{
SwTableNode *const pTableNode(rPam.Start()->nNode.GetNode().GetTableNode());
assert(pTableNode); // known pathology
for (sal_uLong j = pTableNode->GetIndex(); j <= pTableNode->EndOfSectionIndex(); ++j)
SwStartNode *const pTableOrSectionNode(
currentStart.nNode.GetNode().IsTableNode()
? static_cast<SwStartNode*>(currentStart.nNode.GetNode().GetTableNode())
: static_cast<SwStartNode*>(currentStart.nNode.GetNode().GetSectionNode()));
assert(pTableOrSectionNode); // known pathology
for (sal_uLong j = pTableOrSectionNode->GetIndex(); j <= pTableOrSectionNode->EndOfSectionIndex(); ++j)
{
pTableNode->GetNodes()[j]->SetRedlineMergeFlag(SwNode::Merge::Hidden);
pTableOrSectionNode->GetNodes()[j]->SetRedlineMergeFlag(SwNode::Merge::Hidden);
}
for (SwRootFrame const*const pLayout : rDoc.GetAllLayouts())
{
if (pLayout->IsHideRedlines())
{
pTableNode->DelFrames(pLayout);
if (pTableOrSectionNode->IsTableNode())
{
static_cast<SwTableNode*>(pTableOrSectionNode)->DelFrames(pLayout);
}
else
{
static_cast<SwSectionNode*>(pTableOrSectionNode)->DelFrames(pLayout);
}
}
}
currentStart.nNode = pTableOrSectionNode->EndOfSectionIndex() + 1;
currentStart.nContent.Assign(currentStart.nNode.GetNode().GetContentNode(), 0);
pStartNode = currentStart.nNode.GetNode().GetTextNode();
}
else
if (currentStart < *rPam.End())
{
SwTextNode * pNode(pStartNode);
do
@@ -221,24 +235,32 @@ void UpdateFramesForRemoveDeleteRedline(SwDoc & rDoc, SwPaM const& rPam)
{
bool isAppendObjsCalled(false);
rDoc.GetFootnoteIdxs().UpdateFootnote(rPam.Start()->nNode);
SwTextNode *const pStartNode(rPam.Start()->nNode.GetNode().GetTextNode());
if (!pStartNode)
SwPosition currentStart(*rPam.Start());
SwTextNode * pStartNode(rPam.Start()->nNode.GetNode().GetTextNode());
while (!pStartNode)
{
SwTableNode const*const pTableNode(rPam.Start()->nNode.GetNode().GetTableNode());
assert(pTableNode); // known pathology
for (sal_uLong j = pTableNode->GetIndex(); j <= pTableNode->EndOfSectionIndex(); ++j)
SwStartNode const*const pTableOrSectionNode(
currentStart.nNode.GetNode().IsTableNode()
? static_cast<SwStartNode*>(currentStart.nNode.GetNode().GetTableNode())
: static_cast<SwStartNode*>(currentStart.nNode.GetNode().GetSectionNode()));
assert(pTableOrSectionNode); // known pathology
for (sal_uLong j = pTableOrSectionNode->GetIndex(); j <= pTableOrSectionNode->EndOfSectionIndex(); ++j)
{
pTableNode->GetNodes()[j]->SetRedlineMergeFlag(SwNode::Merge::None);
pTableOrSectionNode->GetNodes()[j]->SetRedlineMergeFlag(SwNode::Merge::None);
}
if (rDoc.getIDocumentLayoutAccess().GetCurrentLayout()->IsHideRedlines())
{
// note: this will also create frames for all currently hidden flys
// because it calls AppendAllObjs
::MakeFrames(&rDoc, rPam.Start()->nNode, rPam.End()->nNode);
SwNodeIndex const end(*pTableOrSectionNode->EndOfSectionNode());
::MakeFrames(&rDoc, currentStart.nNode, end);
isAppendObjsCalled = true;
}
currentStart.nNode = pTableOrSectionNode->EndOfSectionIndex() + 1;
currentStart.nContent.Assign(currentStart.nNode.GetNode().GetContentNode(), 0);
pStartNode = currentStart.nNode.GetNode().GetTextNode();
}
else
if (currentStart < *rPam.End())
{
SwTextNode * pNode(pStartNode);
do