ODFstudio/odfstudio
2
0
Fork 0
Code Issues Packages Activity

loplugin:passstuffbyref improved return in lotuswordpro

Browse Source 
Change-Id: I2e4103bb496ed3d0677d036e2f8cec76d001d682
Reviewed-on: https://gerrit.libreoffice.org/47222
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
This commit is contained in:
Noel Grandin
2017-12-31 18:11:26 +01:00
parent 35b8b7bc53
commit 0b6aad2da3
14 changed files with 22 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files
fpicker/source/office/fpsmartcontent.hxx
+1 -1
View File
@@ -131,7 +131,7 @@ namespace svt
/** returns the URL of the content
*/
OUString getURL() const { return m_pContent ? m_pContent->getURL() : m_sURL; }
OUString const & getURL() const { return m_pContent ? m_pContent->getURL() : m_sURL; }
/** (re)creates the content for the given URL
lotuswordpro/inc/lwpfont.hxx
+1 -1
View File
@@ -80,7 +80,7 @@ public:
LwpFontTableEntry(){}
public:
void Read(LwpObjectStream *pStrm);
OUString GetFaceName();
OUString const & GetFaceName();
private:
LwpAtomHolder m_WindowsFaceName; //font face name under windows
LwpAtomHolder m_FaceName; //font face name
lotuswordpro/source/filter/lwpcontent.hxx
+2 -2
View File
@@ -108,7 +108,7 @@ public:
rtl::Reference<LwpVirtualLayout> GetLayout(LwpVirtualLayout const * pStartLayout);
inline bool IsActive();
virtual bool IsTable();
inline OUString GetClassName();
inline OUString const & GetClassName();
inline LwpContent* GetNextEnumerated();
bool HasNonEmbeddedLayouts();
bool IsStyleContent();
@@ -129,7 +129,7 @@ inline bool LwpContent::IsTable()
return false;
}
inline OUString LwpContent::GetClassName()
inline OUString const & LwpContent::GetClassName()
{
return m_ClassName.str();
}
lotuswordpro/source/filter/lwpdivinfo.hxx
+2 -2
View File
@@ -76,9 +76,9 @@ public:
LwpDivInfo(LwpObjectHeader const & objHdr, LwpSvStream* pStrm);
LwpObjectID& GetInitialLayoutID() { return m_InitialLayoutID; }
LwpObjectID& GetFillerPageTextID() { return m_FillerPageTextID; }
OUString GetDivName() { return m_Name.str(); }
OUString const & GetDivName() { return m_Name.str(); }
OUString GetClassName() { return m_ClassName.str(); }
OUString const & GetClassName() { return m_ClassName.str(); }
inline bool HasContents();
inline bool IsOleDivision();
inline bool IsScrollable();
lotuswordpro/source/filter/lwpfont.cxx
+1 -1
View File
@@ -229,7 +229,7 @@ void LwpFontTableEntry::Read(LwpObjectStream *pStrm)
RegisterFontDecl();
}
OUString LwpFontTableEntry::GetFaceName()
OUString const & LwpFontTableEntry::GetFaceName()
{
return m_WindowsFaceName.str();
}
lotuswordpro/source/filter/lwpfootnote.hxx
+2 -2
View File
@@ -185,8 +185,8 @@ public:
};
public:
sal_uInt16 GetStartingNumber(){ return m_nStartingNumber;}
OUString GetLeadingText(){ return m_LeadingText.str();}
OUString GetTrailingText(){ return m_TrailingText.str();}
OUString const & GetLeadingText(){ return m_LeadingText.str();}
OUString const & GetTrailingText(){ return m_TrailingText.str();}
sal_uInt16 GetReset(){ return static_cast<sal_uInt16>(m_nFlag & RESET_MASK);}
};
lotuswordpro/source/filter/lwpmarker.cxx
+1 -1
View File
@@ -342,7 +342,7 @@ bool LwpBookMark::IsRightMarker(LwpObjectID objMarker)
return objMarker == m_objMarker;
}
OUString LwpBookMark::GetName()
OUString const & LwpBookMark::GetName()
{
return LwpDLNFVList::GetName().str();
}
lotuswordpro/source/filter/lwpmarker.hxx
+2 -2
View File
@@ -173,7 +173,7 @@ protected:
void Read() override;
public:
bool IsRightMarker(LwpObjectID objMarker);
OUString GetName();
OUString const & GetName();
private:
enum { BKMK_NOTESFX = 0x0001,
BKMK_OLDNOTESFX = 0x0002
@@ -194,7 +194,7 @@ public:
bool IsDateTimeField(sal_uInt8& type,OUString& formula);
bool IsCrossRefField(sal_uInt8& nType, OUString& sMarkName);
bool IsDocPowerField(sal_uInt8& nType,OUString& sFormula);
OUString GetFormula(){return m_Formula.str();}
OUString const & GetFormula(){return m_Formula.str();}
void SetStyleFlag(bool bFalg){m_bHasStyle = bFalg;}
bool GetStyleFlag(){return m_bHasStyle;}
bool GetStart(){return m_bHasStart;}
lotuswordpro/source/filter/lwpnumericfmt.hxx
+2 -2
View File
@@ -77,8 +77,8 @@ public:
LwpNumericFormatSubset();
~LwpNumericFormatSubset();
void QuickRead(LwpObjectStream* pStrm);
OUString GetPrefix(){ return cPrefix.str();}
OUString GetSuffix(){ return cSuffix.str();}
OUString const & GetPrefix(){ return cPrefix.str();}
OUString const & GetSuffix(){ return cSuffix.str();}
bool IsDefaultPrefix(){ return !(cSubFlags&SF_OVER_PREFIX); }
bool IsDefaultSuffix(){ return !(cSubFlags&SF_OVER_SUFFIX); }
LwpColor GetColor();
lotuswordpro/source/filter/lwpsection.hxx
+1 -1
View File
@@ -92,7 +92,7 @@ public:
virtual ~LwpSection() override;
inline LwpPageLayout* GetPageLayout();
void Parse(IXFStream* pOutputStream) override;
OUString GetSectionName(){return m_AtomHolder.str();}
OUString const & GetSectionName(){return m_AtomHolder.str();}
protected:
void Read() override;
lotuswordpro/source/filter/lwpsilverbullet.cxx
+1 -1
View File
@@ -215,7 +215,7 @@ OUString LwpSilverBullet::GetBulletFontName()
* @descr:
* @return: An UChar32 bullet character.
*/
OUString LwpSilverBullet::GetBulletChar()
OUString const & LwpSilverBullet::GetBulletChar()
{
return m_xBulletPara->GetBulletChar();
}
lotuswordpro/source/filter/lwpsilverbullet.hxx
+1 -1
View File
@@ -104,7 +104,7 @@ public:
const OUString& GetBulletStyleName() const;
OUString GetBulletChar();
OUString const & GetBulletChar();
static OUString GetPrefix() { return OUString(); }
lotuswordpro/source/filter/lwptblcell.hxx
+4 -4
View File
@@ -82,7 +82,7 @@ public:
LwpCellList(LwpObjectHeader const &objHdr, LwpSvStream* pStrm);
virtual void Parse(IXFStream* pOutputStream) override;
LwpObjectID GetNextID(){return GetNext();}
LwpObjectID const & GetNextID(){return GetNext();}
sal_uInt8 GetColumnID(){return cColumn;}
virtual void Convert(XFCell * pCell, LwpTableLayout* pCellsMap=nullptr);
@@ -105,8 +105,8 @@ public:
LwpRowList(LwpObjectHeader const &objHdr, LwpSvStream* pStrm);
void Parse(IXFStream* pOutputStream) override;
LwpObjectID GetChildHeadID(){return cChild.GetHead();}
LwpObjectID GetNextID(){return GetNext();}
LwpObjectID const & GetChildHeadID(){return cChild.GetHead();}
LwpObjectID const & GetNextID(){return GetNext();}
sal_uInt16 GetRowID(){return cRowID;}
private:
void Read() override;
@@ -181,7 +181,7 @@ public:
LwpFolder(LwpObjectHeader const &objHdr, LwpSvStream* pStrm);
void Parse(IXFStream* pOutputStream) override;
LwpObjectID GetChildHeadID(){ return cChild.GetHead();}
LwpObjectID const & GetChildHeadID(){ return cChild.GetHead();}
private:
void Read() override;
virtual ~LwpFolder() override;
lotuswordpro/source/filter/lwptoc.hxx
+1 -1
View File
@@ -149,7 +149,7 @@ public:
virtual void XFConvert(XFContentContainer* pCont) override;
sal_uInt16 GetLevel(){return m_nLevel;}
bool GetUseText(){ return (m_nFlags & USETEXT) != 0;}
OUString GetSearchStyle(){return m_SearchName.str();}
OUString const & GetSearchStyle(){return m_SearchName.str();}
bool GetUseLeadingText(){ return (m_nFlags & USENUMBER) != 0;}
private:
virtual ~LwpTocLevelData() override;