Miklos Vajna
7d4222d008
Have electronic signing configured in the LOK client, try to insert a signature line, you'll get a certificate picker, while we don't have a cert during esign. What's in fact needed for creating the signature line is just a name (previously extracted from the certificate), we can survive the lack of actual certificate. Fix the problem by adding a new External parameter to .uno:InsertSignatureLine to hint that the certificate chooser should not be opened, instead the editor name (used for comments already) should be used. Add a new CertificateOrName in svl/ and use that in all places where previously we wanted a certificate but in fact it's enough to have a certificate or a name to create the signature line. The name on the signature line is just visual feedback, the actual name on the crypto signature is still not based on untrusted used input. Change-Id: Ib7008112a8e28a9e7d9649745e6021dd6b6b9c39 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180193 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Document Signing
Introduction
This code provides dialogs, and infrastructure wrapping libxmlsec and
gpgme that implements document signing.
For signing a document, a personal key pair is used, which consists of a private key and a public key, which is added to the document in addition to the digital signature of the document, when signing it.
The document signing can be done both for the source ODF/OOXML files and the exported PDF files. It is also possible to sign existing PDF files.
Module Contents
doc: OpenDocument workflow legacy information with some illustrations to have an idea of the workflow, for starters checkdoc/OpenDocumentSignatures-Workflow.odt.inc: Headers to a subset of source files inside the module, parts likesource/frameworkhave headers inside the folder.qa: Unit tests for signing and shell scripts for certificates creation for testing.test_docs: Documents & certificates used for testing.source: More on that below.uiconfig: User interface configuration for different dialogs, it is recommended to navigate from relevant source file to the .ui file linked in the class which will be underuiconfig/ui.util: UNO passive registration config for GPG/ NSS.
Source Primary Contents
component: Main implementation ofDocumentDigitalSignatureswhere the interaction with security environment and certificates occur.dialogs: Certificate & Signatures management dialogs.certificatechooser: Dialog that allows you to find and choose certificates or signatures for encryption.certificateviewer: More detailed information about each certificate.digitalsignaturesdialog: Main window for signatures of the documents and the start point of signing document.
framework: Various elements for verifying signatures and running security engine.gpg: The implementation of encrypting with GPG and security environment initialization.helper: Some helper classes that include signatures manager and the helpers for PDF signing, UriBinding, and XML signatures. It also include helper tools for XSecurityEnvironment.xmlsec: XML, NSS, MSCrypt encryption/ signing tools, more on the low-level side of actual implementation of algorithms.
PDF Testing
To test the signed PDFs, one can use the pdfverify in this way:
./bin/run pdfverify $PWD/xmlsecurity/qa/unit/pdfsigning/data/2good.pdf
The file parameter should be an absolute path.
This is the output of pdfverify for 2good.pdf:
verifying signatures
found 2 signatures
signature #0: digest match? 1
signature #0: partial? 0
signature #1: digest match? 1
signature #1: partial? 0