Files
odfstudio/drawinglayer/source/attribute/strokeattribute.cxx
T
Andreas Heinisch e1fe3c74f9 tdf#152997 - Duplicate an odd length dash array to meet the spec
An odd-length array will be drawn as one dash spanning the entire path.
The specifications under
https://www.w3.org/TR/svg-strokes/#StrokeDashing state: "If the list has
an odd number of values, then it is repeated to yield an even number of
values. Thus, the rendering behaviour of stroke-array: 5,4,2 is
equivalent to stroke-dasharray: 5,4,2,5,4,2."

Change-Id: I8f233c4cec5c85f5ab1096b032cbb8743715f14d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/211062
Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
Tested-by: Jenkins
2026-09-21 12:28:00 +02:00

141 lines
5.3 KiB
C++

/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
/*
* This file is part of the LibreOffice project.
*
* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
*
* This file incorporates work covered by the following license notice:
*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed
* with this work for additional information regarding copyright
* ownership. The ASF licenses this file to you under the Apache
* License, Version 2.0 (the "License"); you may not use this file
* except in compliance with the License. You may obtain a copy of
* the License at http://www.apache.org/licenses/LICENSE-2.0 .
*/
#include <drawinglayer/attribute/strokeattribute.hxx>
#include <numeric>
namespace drawinglayer::attribute
{
class ImpStrokeAttribute
{
public:
// data definitions
std::vector< double > maDotDashArray; // array of double which defines the dot-dash pattern
double mfFullDotDashLen; // sum of maDotDashArray (for convenience)
ImpStrokeAttribute(
std::vector< double >&& rDotDashArray,
double fFullDotDashLen)
: maDotDashArray(std::move(rDotDashArray)),
mfFullDotDashLen(fFullDotDashLen)
{
// tdf#152997 - duplicate an odd length dash array in order to meet the spec.
// An odd-length array will be drawn as one dash spanning the entire path. The
// specifications under https://www.w3.org/TR/svg-strokes/#StrokeDashing state:
// "If the list has an odd number of values, then it is repeated to yield an
// even number of values. Thus, the rendering behavior of stroke-dasharray: 5,3,2
// is equivalent to stroke-dasharray: 5,3,2,5,3,2."
if (maDotDashArray.size() % 2 == 1)
{
const std::vector<double> aOriginal(maDotDashArray);
maDotDashArray.insert(maDotDashArray.end(), aOriginal.begin(), aOriginal.end());
// Increase the length accordingly
if (0.0 != mfFullDotDashLen)
mfFullDotDashLen *= 2.0;
}
}
ImpStrokeAttribute()
: mfFullDotDashLen(0.0)
{
}
// data read access
const std::vector< double >& getDotDashArray() const { return maDotDashArray; }
double getFullDotDashLen() const
{
if(0.0 == mfFullDotDashLen && !maDotDashArray.empty())
{
// calculate length on demand
const double fAccumulated(std::accumulate(maDotDashArray.begin(), maDotDashArray.end(), 0.0));
const_cast< ImpStrokeAttribute* >(this)->mfFullDotDashLen = fAccumulated;
}
return mfFullDotDashLen;
}
bool operator==(const ImpStrokeAttribute& rCandidate) const
{
return (getDotDashArray() == rCandidate.getDotDashArray()
&& getFullDotDashLen() == rCandidate.getFullDotDashLen());
}
};
namespace
{
StrokeAttribute::ImplType& theGlobalDefault()
{
static StrokeAttribute::ImplType SINGLETON;
return SINGLETON;
}
}
StrokeAttribute::StrokeAttribute(
std::vector< double >&& rDotDashArray,
double fFullDotDashLen)
: mpStrokeAttribute(ImpStrokeAttribute(
std::move(rDotDashArray), fFullDotDashLen))
{
}
StrokeAttribute::StrokeAttribute()
: mpStrokeAttribute(theGlobalDefault())
{
}
StrokeAttribute::StrokeAttribute(const StrokeAttribute&) = default;
StrokeAttribute::StrokeAttribute(StrokeAttribute&&) = default;
StrokeAttribute::~StrokeAttribute() = default;
bool StrokeAttribute::isDefault() const
{
return mpStrokeAttribute.same_object(theGlobalDefault());
}
StrokeAttribute& StrokeAttribute::operator=(const StrokeAttribute&) = default;
StrokeAttribute& StrokeAttribute::operator=(StrokeAttribute&&) = default;
bool StrokeAttribute::operator==(const StrokeAttribute& rCandidate) const
{
// tdf#87509 default attr is always != non-default attr, even with same values
if(rCandidate.isDefault() != isDefault())
return false;
return rCandidate.mpStrokeAttribute == mpStrokeAttribute;
}
const std::vector< double >& StrokeAttribute::getDotDashArray() const
{
return mpStrokeAttribute->getDotDashArray();
}
double StrokeAttribute::getFullDotDashLen() const
{
return mpStrokeAttribute->getFullDotDashLen();
}
} // end of namespace
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */