This commit finalizes the CoordinateMapper refactor by resolving naming
collisions and establishing a strict semantic separation between
physical units and logical distances.
To avoid ambiguity with the word "Pixel" and to clearly distinguish
between pure mathematical scaling and coordinate space translations,
the API has been standardized:
1. Distance Scaling:
Renamed the pure multiplication methods from LogicToViewX/Y to
LogicToViewDistanceX/Y. This frees up the namespace and clarifies
that these methods handle scaling without applying mapping offsets.
2. Physical Pipeline Stages (*Units):
Implemented the definitive space-to-space transformation ladder using
the 'Units' suffix for physical stages and 'LogicUnits' for the
document stage:
- DeviceToWindowUnits / WindowToDeviceUnits
- WindowToViewUnits / ViewToWindowUnits
- ViewToLogicUnits / LogicUnitsToViewUnits
3. Legacy Cleanup:
Purged the orphaned LogicToViewPixelX/Y declarations and
implementations left over from earlier refactoring attempts. Updated
the legacy ImplCalcDevicePixelX/Y helpers to utilize the new
LogicUnitsToViewUnitsX/Y pipeline stage.
4. map.cxx Alignment:
Updated all OutputDevice translation sites in map.cxx that previously
relied on the overloaded LogicToViewX/Y to explicitly call the correct
LogicToViewDistanceX/Y variants, restoring a clean build.
Change-Id: I621ed8741055a29bf65963d75b763ca3e4a7bd0f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/203658
Tested-by: Jenkins
Reviewed-by: Dan Williams <dcbw@libreoffice.org>
Christopher Sherlock
5922c26bca