Commit
commit 7312d7d3c9
Date: Wed May 20 15:28:42 2026 +0200
Relates tdf#166641 - Add category labels to Writer's Tabbed Notebookbar
* gla11y-conform
* consistent IDs (gd*/lb* and btn*/bx*)
* consistent layout with grids
* defined spacing of 3px
* defined margins of 6px
* category labels
* redundant Insert sections from Home and Forms from Tools removed
* customization of Notebookbars removed since the new position
of commands is not properly found
had dropped the possibility to customize the NotebookBar
via a "Notebookbars" tab in the the "Tools" -> "Customize..." dialog.
This was creating modified .ui files for the NotebookBar
in the user configuration/profile directory, and if such were
present, they would be loaded instead of the standard .ui file.
Now that creating such files is no longer supported, also
drop the logic to load such files from the user profile.
This will also allow dropping various old workarounds
in the VclBuilder implementation again.
The approach used for NotebookBar customization so
far had multiple problems because it
relied on internal implementation details of how
LibreOffice's UI is created from .ui files using
weld::Builder/VclBuilder, which is an internal implementation
detail and subject to change, not something anything should rely
on to work across multiple LO versions.
Keeping this somewhat working already required multiple
workarounds in the past, e.g.
commit f14a738fa8c5579c2ef8cb8387b771e94ea5bdfe
Date: Mon Aug 10 15:55:50 2020 +0100
tdf#135495 builder file format has annoyingly escaped into user config
Any later changes to Notebookbar .ui files would simply be
ignored, so later updates to the LibreOffice-provided NotebookBar
would no longer be applied. Also, e.g. an update in translated
strings would result in localization no longer working for the
"outdated" copy in the user configuration, see tdf#172831
(in particular comments 30, 32 and 33).
There's even no guarantee that such .ui files
still work at all with the current Builder logic. I.e.
trying to use my existing (a couple of years old, automatically
migrated from earlier LO versions in the past) user profile on
Debian testing with a current master debug build would result in
this assertion being triggered:
soffice.bin: /home/michi/development/git/libreoffice/vcl/source/window/window2.cxx:1628: virtual bool vcl::Window::set_property(const OUString &, const OUString &): Assertion `rKey == "margin-start" && "margin-left deprecated in favor of margin-start"' failed.
Change-Id: I35ab9f4254050262e18470befd03c921cce92c76
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/208674
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
Michael Weghorn
eeeaa9057d