Balazs Varga
130d35d198
This reverts commit 2b4cd99d33.
The 2021 commit framed Windows' write-share enforcement as a
divergence from Unix to be eliminated. The premise inverts the
situation: Unix's lack of mandatory write-share enforcement is a
known weakness, not a property to copy. LO's cooperative .lock-file
mechanism implicitly relied on the kernel guarantee Windows
provided.
The commit predicted "no new scenario will be created" because LO's
Unix path already worked this way. But it missed the silent-overwrite
manifestation reported as tdf#157943: any second writer to the same
path - another process, an external app, or even a separate write
path within the same LO instance - can now silently clobber the
first writer's data, because the kernel no longer rejects their
concurrent write open. Tests don't catch this because they verify
that writes succeed, not that competing writes don't silently lose
each other's data.
The intra-process OLE-edit scenario the 2021 commit addressed is
handled at the right layer (OLE-link activation) in the follow-up,
without weakening the cross-process guarantee.
Change-Id: Ie12d16a8be1516bdd45d1b89155f3ca2615d658c
Reviewed-on: https://gerrit.collaboraoffice.com/c/online/+/2003
Reviewed-by: Michael Stahl <michael.stahl@collabora.com>
Tested-by: Jenkins CPCI <releng@collaboraoffice.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/204939
Tested-by: Jenkins
Reviewed-by: Balazs Varga <balazs.varga@collabora.com>
System Abstraction Layer (SAL)
System abstraction layer; rtl, osl and sal
rtl:
Platform independent strings
osl:
platform specific stuff, threads, dynamic loading, process, ipc, etc
Exports only C API and some inline-methods (only C++ API).