ODFstudio/odfstudio
2
0
Fork 0
Code Issues Packages Activity
Files
b038106e8d3b24d794bfec0aa4d6b42fc470c4e4
odfstudio/basic/qa/basic_coverage
T
History
Mike Kaganski b038106e8d tdf#166972: do not reset parameters in SbUnoObject::Notify 
Resetting parameters in this function was introduced in commit
0b21b8b146 (initial commit for vba blob
( not including container_control stuff ), 2010-10-06). Unfortunately,
the reason for that is not explained.

The problem that it creates is that this code gets called eventually
from SbiRuntime::FindElement (which sets parameters using SetupArgs,
then calls SbiRuntime::CheckArray in the end, which calls GetObject,
which performs actual data access).

In SbiRuntime::CheckArray, the immediate problem was, that parameters
were referenced using a raw pointer; when the parageters were cleared
in GetObject, the pointer got dangling.

But it wasn't enough to use e.g. SbxArrayRef there, to keep the array
alive; the object will be accessed later, and needs its parameters to
work. On the other hand, it feels wrong to reinstate parameters after
the call to GetObject in SbiRuntime::CheckArray (getting the object
can run just any code path). So I chose to try and drop the resetting
of parameters in SbUnoObject::Notify. Let's see, if something breaks.

Change-Id: Icadfcfb8b7e5e87b2de46166963fd97532f8713c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186432
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
2025-06-12 21:55:17 +02:00
..
da-DK
tdf#162724: use localized decimal separator in ImpCurrencyToString
2024-09-01 04:06:40 +02:00
zh-CN
tdf#162724: use localized decimal separator in ImpCurrencyToString
2024-09-01 04:06:40 +02:00
dateadd.bas
tdf#114011: basic_macros: Add unittest
2021-07-14 18:15:28 +02:00
test_abs_method.bas
basic_coverage: use Option Explicit where possible
2021-07-07 10:01:10 +02:00
test_array_method.bas
basic_coverage: use Option Explicit where possible
2021-07-07 10:01:10 +02:00
test_asc_method.bas
basic_coverage: use Option Explicit where possible
2021-07-07 10:01:10 +02:00
test_atn_method.bas
basic_coverage: use Option Explicit where possible
2021-07-07 10:01:10 +02:00
test_beep_method.bas
basic_coverage: use Option Explicit where possible
2021-07-07 10:01:10 +02:00
test_booltypename.bas
tdf#145960 - Return type of boolean operators should be of type boolean
2021-12-28 19:54:58 +01:00
test_CallByName.bas
basic: add missing license statement in test files
2022-12-20 08:41:11 +00:00
test_cbool_method.bas
basic_coverage: use Option Explicit where possible
2021-07-07 10:01:10 +02:00
test_cbyte_method.bas
basic_coverage: use Option Explicit where possible
2021-07-07 10:01:10 +02:00
test_ccur_method.bas
tdf#162724: use localized decimal separator in ImpCurrencyToString
2024-09-01 04:06:40 +02:00
test_cdate_method.bas
basic_coverage: use Option Explicit where possible
2021-07-07 10:01:10 +02:00
test_cdatetofromiso_methods.bas
basic_coverage: use Option Explicit where possible
2021-07-07 10:01:10 +02:00
test_cdatetounodatecdatefromunodate_methods.bas
basic_coverage: use Option Explicit where possible
2021-07-07 10:01:10 +02:00
test_cdatetounodatetimecdatefromunodatetime_methods.bas
basic_coverage: use Option Explicit where possible
2021-07-07 10:01:10 +02:00
test_cdatetounotimecdatefromunotime_methods.bas
tdf#136112: return 'Date' type from Time()
2025-05-08 15:15:36 +02:00
test_cdbl_method.bas
tdf#146672 - CDbl: skip spaces and tabs at the end of the scanned string
2022-02-09 11:09:01 +01:00
test_chdircurdir_methods.bas
basic_coverage: use Option Explicit where possible
2021-07-07 10:01:10 +02:00
test_choose_method.bas
basic_coverage: use Option Explicit where possible
2021-07-07 10:01:10 +02:00
test_chr_method.bas
tdf#145693 - Argument name should be 'charcode' instead of 'string'
2022-01-08 11:48:32 +01:00
test_chr_overflow_method.bas
tdf#130426 - Rename file for tdf#145693
2022-01-07 12:17:50 +01:00
test_cint_method.bas
basic_coverage: use Option Explicit where possible
2021-07-07 10:01:10 +02:00
test_Collection_class.bas
Basic Collection class unit test
2022-03-31 17:26:55 +02:00
test_compatibilitymode_method.bas
basic_coverage: use Option Explicit where possible
2021-07-07 10:01:10 +02:00
test_converttofromurl_methods.bas
tdf#152917: basic_macros: Add unittest
2023-01-09 19:08:03 +00:00
test_cossin_methods.bas
basic_coverage: use Option Explicit where possible
2021-07-07 10:01:10 +02:00
test_createobject_method.bas
basic_coverage: use Option Explicit where possible
2021-07-07 10:01:10 +02:00
test_createunolistener_method.bas
basic_coverage: use Option Explicit where possible
2021-07-07 10:01:10 +02:00
test_createunoservice_method.bas
basic_coverage: use Option Explicit where possible
2021-07-07 10:01:10 +02:00
test_createunostruct_method.bas
basic_coverage: use Option Explicit where possible
2021-07-07 10:01:10 +02:00
test_createunovalue_method.bas
basic_coverage: use Option Explicit where possible
2021-07-07 10:01:10 +02:00
test_csng_method.bas
basic_coverage: use Option Explicit where possible
2021-07-07 10:01:10 +02:00
test_cstr_method.bas
Change the comment of the test cases to clarify the textual representation of the calculated string
2022-03-02 21:42:09 +01:00
test_Currency.bas
Improve run-time Currency type support in Basic
2024-09-09 17:46:41 +02:00
test_cvar_method.bas
basic_coverage: use Option Explicit where possible
2021-07-07 10:01:10 +02:00
test_cverr_method.bas
basic_coverage: use Option Explicit where possible
2021-07-07 10:01:10 +02:00
test_date_literal.bas
basic_coverage: use Option Explicit where possible
2021-07-07 10:01:10 +02:00
test_date_passed_to_uno.bas
tdf#164811: swap the "if IsCompatibility()" branches to match other places
2025-01-23 20:14:46 +01:00
test_Date.bas
basic_coverage: use Option Explicit where possible
2021-07-07 10:01:10 +02:00
test_datedateadddatediff_methods.bas
basic_coverage: use Option Explicit where possible
2021-07-07 10:01:10 +02:00
test_datedatepartday_methods.bas
basic_coverage: use Option Explicit where possible
2021-07-07 10:01:10 +02:00
test_declare_from_dll.bas
tdf#147364: fix function signature to account to calling convention
2022-02-11 12:56:03 +01:00
test_dimarray_method.bas
basic_coverage: use Option Explicit where possible
2021-07-07 10:01:10 +02:00
test_empty_parameter.bas
Rename LibreOffice Basic test files from .vb to .bas: they are not VBA
2021-07-02 20:48:34 +02:00
test_environ_method.bas
basic_coverage: use Option Explicit where possible
2021-07-07 10:01:10 +02:00
test_equalunoobjects_method.bas
Rename LibreOffice Basic test files from .vb to .bas: they are not VBA
2021-07-02 20:48:34 +02:00
test_erl_method.bas
Rename LibreOffice Basic test files from .vb to .bas: they are not VBA
2021-07-02 20:48:34 +02:00
test_err_method.bas
basic_coverage: use Option Explicit where possible
2021-07-07 10:01:10 +02:00
test_falsetrue_method.bas
basic_coverage: use Option Explicit where possible
2021-07-07 10:01:10 +02:00
test_filedatetime_nonexistent2.bas
basic_coverage: use Option Explicit where possible
2021-07-07 10:01:10 +02:00
test_filedatetime_nonexistent.bas
basic_coverage: use Option Explicit where possible
2021-07-07 10:01:10 +02:00
test_fix_method.bas
basic_coverage: use Option Explicit where possible
2021-07-07 10:01:10 +02:00
test_for_each.bas
Rename LibreOffice Basic test files from .vb to .bas: they are not VBA
2021-07-02 20:48:34 +02:00
test_format_function.bas
tdf#166342: refactor SbxValue::Format again, to handle date/time strings
2025-05-08 17:42:21 +02:00
test_frac_method.bas
basic_coverage: use Option Explicit where possible
2021-07-07 10:01:10 +02:00
test_freefile_method.bas
basic_coverage: use Option Explicit where possible
2021-07-07 10:01:10 +02:00
test_freelibrary_method.bas
basic_coverage: use Option Explicit where possible
2021-07-07 10:01:10 +02:00
test_getdefaultcontext_method.bas
basic_coverage: use Option Explicit where possible
2021-07-07 10:01:10 +02:00
test_getdialogzoomfactorx_method.bas
basic_coverage: use Option Explicit where possible
2021-07-07 10:01:10 +02:00
test_getdialogzoomfactory_method.bas
basic_coverage: use Option Explicit where possible
2021-07-07 10:01:10 +02:00
test_getguitype_method.bas
basic_coverage: use Option Explicit where possible
2021-07-07 10:01:10 +02:00
test_getguiversion_method.bas
basic_coverage: use Option Explicit where possible
2021-07-07 10:01:10 +02:00
test_getpathseparator_method.bas
basic_coverage: use Option Explicit where possible
2021-07-07 10:01:10 +02:00
test_getprocessservicemanager_method.bas
basic_coverage: use Option Explicit where possible
2021-07-07 10:01:10 +02:00
test_getsolarversion_method.bas
basic_coverage: use Option Explicit where possible
2021-07-07 10:01:10 +02:00
test_getsystemtype_method.bas
basic_coverage: use Option Explicit where possible
2021-07-07 10:01:10 +02:00
test_hasunointerfaces_method.bas
basic_coverage: use Option Explicit where possible
2021-07-07 10:01:10 +02:00
test_hex_method.bas
basic_coverage: use Option Explicit where possible
2021-07-07 10:01:10 +02:00
test_hour_method.bas
basic_coverage: use Option Explicit where possible
2021-07-07 10:01:10 +02:00
test_If.bas
Basic QA new unit test for IF THEN statement
2024-08-01 10:04:02 +02:00
test_iif_method.bas
basic_coverage: use Option Explicit where possible
2021-07-07 10:01:10 +02:00
test_instr_method.bas
tdf#139840 - Use utl::TextSearch to implement the InStr function
2021-07-16 09:29:16 +02:00
test_int_method.bas
basic_coverage: use Option Explicit where possible
2021-07-07 10:01:10 +02:00
test_isarray_method.bas
basic_coverage: use Option Explicit where possible
2021-07-07 10:01:10 +02:00
test_isdate_method.bas
basic_coverage: use Option Explicit where possible
2021-07-07 10:01:10 +02:00
test_isempty_method.bas
basic_coverage: use Option Explicit where possible
2021-07-07 10:01:10 +02:00
test_iserror_method.bas
basic_coverage: use Option Explicit where possible
2021-07-07 10:01:10 +02:00
test_ismissing_basic.bas
basic: add missing license statement in test files
2022-12-20 08:41:11 +00:00
test_ismissing_cascade.bas
basic: add missing license statement in test files
2022-12-20 08:41:11 +00:00
test_ismissing_compatible.bas
basic: add missing license statement in test files
2022-12-20 08:41:11 +00:00
test_isnull_method.bas
basic_coverage: use Option Explicit where possible
2021-07-07 10:01:10 +02:00
test_isnumeric_method.bas
tdf#164600: Return true from IsNumeric for booleans in VBASupport mode
2025-01-08 06:02:48 +01:00
test_isobject_method.bas
basic_coverage: use Option Explicit where possible
2021-07-07 10:01:10 +02:00
test_isunostruct_method.bas
basic_coverage: use Option Explicit where possible
2021-07-07 10:01:10 +02:00
test_join_method.bas
tdf#141474 tdf#151901 BASIC functions argument names do not match that of VBA
2023-02-26 16:14:47 +00:00
test_lbound_method.bas
basic_coverage: use Option Explicit where possible
2021-07-07 10:01:10 +02:00
test_lcase_method.bas
basic_coverage: use Option Explicit where possible
2021-07-07 10:01:10 +02:00
test_left_method.bas
tdf#141474 tdf#151901 BASIC functions argument names do not match that of VBA
2023-02-26 16:14:47 +00:00
test_len_method.bas
basic_coverage: use Option Explicit where possible
2021-07-07 10:01:10 +02:00
test_lenb_method.bas
basic_coverage: use Option Explicit where possible
2021-07-07 10:01:10 +02:00
test_like.bas
tdf#152690: Fix "!" behavior when it is not the first in a group
2023-03-16 21:14:20 +00:00
test_logexp_methods.bas
basic_coverage: use Option Explicit where possible
2021-07-07 10:01:10 +02:00
test_ltrim_method.bas
basic_coverage: use Option Explicit where possible
2021-07-07 10:01:10 +02:00
test_method_name_variable.bas
basic_coverage: use Option Explicit where possible
2021-07-07 10:01:10 +02:00
test_mid_CountNegative_3args.bas
basic_coverage: use Option Explicit where possible
2021-07-07 10:01:10 +02:00
test_mid_EndOutOfBounds_3args.bas
basic_coverage: use Option Explicit where possible
2021-07-07 10:01:10 +02:00
test_mid_firstletter_3args.bas
basic_coverage: use Option Explicit where possible
2021-07-07 10:01:10 +02:00
test_mid_keyword_names.bas
tdf#141474 tdf#151901 BASIC functions argument names do not match that of VBA
2023-02-26 16:14:47 +00:00
test_mid_replace_less.bas
Rename LibreOffice Basic test files from .vb to .bas: they are not VBA
2021-07-02 20:48:34 +02:00
test_mid_replace_more_end.bas
Rename LibreOffice Basic test files from .vb to .bas: they are not VBA
2021-07-02 20:48:34 +02:00
test_mid_replace_more.bas
Rename LibreOffice Basic test files from .vb to .bas: they are not VBA
2021-07-02 20:48:34 +02:00
test_mid_StartOutOfBounds_2args.bas
basic_coverage: use Option Explicit where possible
2021-07-07 10:01:10 +02:00
test_mid_StartOutOfBounds_3args.bas
basic_coverage: use Option Explicit where possible
2021-07-07 10:01:10 +02:00
test_mid_sub2letters_2args.bas
basic_coverage: use Option Explicit where possible
2021-07-07 10:01:10 +02:00
test_minute_method.bas
basic_coverage: use Option Explicit where possible
2021-07-07 10:01:10 +02:00
test_mod_operator.bas
basic_coverage: use Option Explicit where possible
2021-07-07 10:01:10 +02:00
test_month_method.bas
basic_coverage: use Option Explicit where possible
2021-07-07 10:01:10 +02:00
test_non_ascii_names_compatible.bas
tdf#148358 - Compare Non-ASCII variable names case-insensitive
2022-05-07 16:00:50 +02:00
test_non_ascii_names.bas
tdf#148358 - Compare Non-ASCII variable names case-insensitive
2022-05-07 16:00:50 +02:00
test_nowtimevalue_methods.bas
basic_coverage: use Option Explicit where possible
2021-07-07 10:01:10 +02:00
test_numeric_constant_parameter.bas
basic_coverage: use Option Explicit where possible
2021-07-07 10:01:10 +02:00
test_oct_method.bas
basic_coverage: use Option Explicit where possible
2021-07-07 10:01:10 +02:00
test_option_base_compatible.bas
basic: add missing license statement in test files
2022-12-20 08:41:11 +00:00
test_option_base.bas
basic: add missing license statement in test files
2022-12-20 08:41:11 +00:00
test_optional_paramter_type.bas
basic: add missing license statement in test files
2022-12-20 08:41:11 +00:00
test_optional_paramters_basic.bas
basic: add missing license statement in test files
2022-12-20 08:41:11 +00:00
test_optional_paramters_compatible.bas
basic: add missing license statement in test files
2022-12-20 08:41:11 +00:00
test_Property.GetLet.bas
basic_coverage: use Option Explicit where possible
2021-07-07 10:01:10 +02:00
test_Property.GetSet.bas
i#109051: also handle Exit Property for Property Set
2024-09-17 05:54:15 +02:00
test_qbcolor_method.bas
basic_coverage: use Option Explicit where possible
2021-07-07 10:01:10 +02:00
test_random_methods.bas
basic_coverage: use Option Explicit where possible
2021-07-07 10:01:10 +02:00
test_redim_objects.bas
basic_coverage: use Option Explicit where possible
2021-07-07 10:01:10 +02:00
test_resolvepath_method.bas
basic_coverage: use Option Explicit where possible
2021-07-07 10:01:10 +02:00
test_rgb_method.bas
basic_coverage: use Option Explicit where possible
2021-07-07 10:01:10 +02:00
test_right_method.bas
tdf#141474 tdf#151901 BASIC functions argument names do not match that of VBA
2023-02-26 16:14:47 +00:00
test_rtrim_method.bas
basic_coverage: use Option Explicit where possible
2021-07-07 10:01:10 +02:00
test_second_method.bas
basic_coverage: use Option Explicit where possible
2021-07-07 10:01:10 +02:00
test_sgn_method.bas
basic_coverage: use Option Explicit where possible
2021-07-07 10:01:10 +02:00
test_space_method.bas
basic_coverage: use Option Explicit where possible
2021-07-07 10:01:10 +02:00
test_spc_method.bas
basic_coverage: use Option Explicit where possible
2021-07-07 10:01:10 +02:00
test_split_method.bas
tdf#141474 tdf#151901 BASIC functions argument names do not match that of VBA
2023-02-26 16:14:47 +00:00
test_sqr_method.bas
basic_coverage: use Option Explicit where possible
2021-07-07 10:01:10 +02:00
test_strcomp_method.bas
basic_coverage: use Option Explicit where possible
2021-07-07 10:01:10 +02:00
test_string_fixed_len.bas
tdf#163680: fix fixed-length strings assignment
2024-10-31 20:46:09 +01:00
test_string_literal_comparison.bas
basic_coverage: use Option Explicit where possible
2021-07-07 10:01:10 +02:00
test_string_method.bas
tdf#141474 tdf#151901 BASIC functions argument names do not match that of VBA
2023-02-26 16:14:47 +00:00
test_string_overflow_safe.bas
basic: add missing license statement in test files
2022-12-20 08:41:11 +00:00
test_string_replace.bas
basic: add missing license statement in test files
2022-12-20 08:41:11 +00:00
test_strtrim_methods.bas
basic_coverage: use Option Explicit where possible
2021-07-07 10:01:10 +02:00
test_switch_method.bas
basic_coverage: use Option Explicit where possible
2021-07-07 10:01:10 +02:00
test_tab_method.bas
basic_coverage: use Option Explicit where possible
2021-07-07 10:01:10 +02:00
test_tan_method.bas
basic_coverage: use Option Explicit where possible
2021-07-07 10:01:10 +02:00
test_tdf98778.bas
basic: add missing license statement in test files
2022-12-20 08:41:11 +00:00
test_tdf111313.bas
tdf#111313: basic_macros: Add unittest
2021-07-15 10:02:00 +02:00
test_tdf125637.bas
tdf#125637 - Correctly hand names ending with an underscore
2021-10-20 20:27:59 +02:00
test_tdf132388_ReplacePerformance.bas
Adapt test to even slower builds
2022-03-31 14:06:56 +02:00
test_tdf134692.bas
basic: add missing license statement in test files
2022-12-20 08:41:11 +00:00
test_tdf147089_idiv.bas
tdf#147089 - Round Integral Division (IDIV) literals to Integer values
2022-02-21 23:10:46 +01:00
test_tdf147529_optional_parameters_msgbox.bas
tdf#151012 - Initialize optional parameters with their default values
2022-09-25 11:39:33 +02:00
test_tdf149622.bas
tdf#149622: also clear return value before calling method from SbxObject::Call
2022-06-20 12:46:27 +02:00
test_tdf150137_parse_fail.bas
tdf#150137 fastparser: don't crash on undeclared namespace
2023-08-07 17:38:30 +02:00
test_tdf160321_gosub_goto.bas
tdf#160321 - Don't execute jump statement if the expression is out of range
2024-06-10 13:52:00 +02:00
test_tdf165420.bas
tdf#165420: handle empty arguments correctly
2025-02-25 07:35:20 +01:00
test_Time.bas
tdf#136112: return 'Date' type from Time()
2025-05-08 15:15:36 +02:00
test_timer_method.bas
basic_coverage: use Option Explicit where possible
2021-07-07 10:01:10 +02:00
test_timeserialtimevalue_methods.bas
basic_coverage: use Option Explicit where possible
2021-07-07 10:01:10 +02:00
test_transliteration.bas
basic: remove tabs from test file
2022-12-20 12:56:52 +00:00
test_twipsperpixelx_method.bas
basic_coverage: use Option Explicit where possible
2021-07-07 10:01:10 +02:00
test_twipsperpixely_method.bas
basic_coverage: use Option Explicit where possible
2021-07-07 10:01:10 +02:00
test_typelen_method.bas
basic_coverage: use Option Explicit where possible
2021-07-07 10:01:10 +02:00
test_typename_method.bas
tdf#141474 tdf#151901 BASIC functions argument names do not match that of VBA
2023-02-26 16:14:47 +00:00
test_types_conversion.bas
Make the tdf#97983 changes to BASIC optional
2021-12-09 12:06:49 +01:00
test_ucase_method.bas
basic_coverage: use Option Explicit where possible
2021-07-07 10:01:10 +02:00
test_unsigned_integers.bas
tdf#149447: use proper UNO types for marshalling unsigned Basic types
2022-06-28 15:15:48 +02:00
test_val_method.bas
basic_coverage: use Option Explicit where possible
2021-07-07 10:01:10 +02:00
test_variant_arg_used_as_obj.bas
tdf#160578: do not modify procedure argument type based on its use
2025-01-23 20:14:51 +01:00
test_vartype_method.bas
tdf#141474 tdf#151901 BASIC functions argument names do not match that of VBA
2023-02-26 16:14:47 +00:00
test_Vbscript_RegExp.bas
tdf#166972: do not reset parameters in SbUnoObject::Notify
2025-06-12 21:55:17 +02:00
test_wait_method.bas
basic_coverage: use Option Explicit where possible
2021-07-07 10:01:10 +02:00
test_weekday_method.bas
basic_coverage: use Option Explicit where possible
2021-07-07 10:01:10 +02:00
test_With.bas
tdf#163219: only create local With variable for function results
2024-10-07 09:38:38 +02:00
test_year_method.bas
basic_coverage: use Option Explicit where possible
2021-07-07 10:01:10 +02:00
uno_struct_assign.bas
basic_coverage: use Option Explicit where possible
2021-07-07 10:01:10 +02:00