Stephan Bergmann
aee7b9b8e0
...by completely getting rid of the code exhibiting UB and the helpless workaround from2b27652d2d"tdf#167892 fix hang formatting very small number on windows". TODO: It is unclear to me whether using saturated values here is any better than using whatever random values came out of the original code that exhibited UB. The whole algorithm probably needs to be replaced with something that actually works. (This was now reported with4368272648"tdf#167892: svl_qa_cppunit: Add test" as > /svl/source/numbers/zformat.cxx:2886:52: runtime error: 1e+19 is outside the range of representable values of type 'long' > #0 0x7f3f6da013eb in SvNumberformat::ImpGetFractionElements(double&, unsigned short, double&, long&, long&) const /svl/source/numbers/zformat.cxx:2886:52 > #1 0x7f3f6d9f84ee in SvNumberformat::ImpGetFractionOutput(double, unsigned short, bool, NativeNumberWrapper const&, rtl::OUStringBuffer&) const /svl/source/numbers/zformat.cxx:2961:5 > #2 0x7f3f6d9e472a in SvNumberformat::GetOutputString(double, rtl::OUString&, Color const**, NativeNumberWrapper const&, SvNFLanguageData const&, bool) const /svl/source/numbers/zformat.cxx:2676:21 > #3 0x7f3f6d8c37bc in SvNFEngine::GetPreviewString(SvNFLanguageData&, SvNFFormatData const&, NativeNumberWrapper const&, SvNFEngine::Accessor const&, rtl::OUString const&, double, rtl::OUString&, Color const**, o3tl::strong_int<unsigned short, LanguageTypeTag>, bool) /svl/source/numbers/zforlist.cxx:2147:20 > #4 0x7f3f6d8c3ddb in SvNumberFormatter::GetPreviewString(rtl::OUString const&, double, rtl::OUString&, Color const**, o3tl::strong_int<unsigned short, LanguageTypeTag>, bool) /svl/source/numbers/zforlist.cxx:2165:12 > #5 0x7f3f6ef90fd3 in (anonymous namespace)::Test::checkPreviewString(SvNumberFormatter&, rtl::OUString const&, double, o3tl::strong_int<unsigned short, LanguageTypeTag>, rtl::OUString const&) /svl/qa/unit/svl.cxx:462:21 > #6 0x7f3f6ef67f13 in (anonymous namespace)::Test::testUserDefinedNumberFormats() /svl/qa/unit/svl.cxx:1443:9 <https://ci.libreoffice.org/job/lo_ubsan/3801/>.) Change-Id: Iff449629ee309f9513af02da9dfdf2505d6fe725 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/198278 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@collabora.com>
Non-Graphical Helper Code (svtools light)
Contains non-graphical helper code for office applications.
Specifically this module does not depend on or use includes from module vcl. Originally all code in svtools that did not depend on vcl was split off into this svl ("svtools light") module.
In particular the SfxItemSet is a property-bag like container that
stores arbitrary sets of properties for everything from text run
formats, to Chart regression line properties.
There are lots of other useful helpers in here for various office
tasks; much of this code was originally moved from svx/sfx2.
Items, Pools and Sets
SfxPoolItem
A small reference counted piece of data. Many subclasses, each with a
unique integer to identify its type (WhichId). Can be compared for equality
(operator==), Clone()d, and converted to/from uno::Any (QueryValue/PutValue).
A pool item may have value semantics ("poolable"), meaning that
there will generally be only one instance that compares equal per item pool,
or not, in which case the item will be Clone()d quite a bit.
SfxItemPool
Usually there is one item pool per document, with a range of valid WhichIds
that is specific to the type of document.
The item pool owns all instances of SfxPoolItem or its subclasses that have
ever been added to an item set. It also contains a default item for
every WhichId, which will be (depending on parameters) returned from item
sets if the set does not contain an item at this WhichId.
SfxItemSet
The item set can be created with a user-supplied range of WhichIds; it
will accept SfxPoolItems with matching WhichIds and ignore attempts to
insert items with non-matching WhichIds.
Items that are successfully inserted into the set will be stored in the
set's SfxItemPool, and for poolable items only a single instance that
compares equal under the predicate operator== will be stored in the pool,
regardless of how many sets contain it, thus conserving memory.
There are members m_pWhichRanges for the valid ranges (as pairs of WhichIds),
m_nCount for the number of items contained, and m_pItems for the pointers to
the actual items.