Stephan Bergmann
ad9498f8b8
More -Werror,-Wunused-private-field
...detected with a modified trunk Clang with
> Index: lib/Sema/SemaDeclCXX.cpp
> ===================================================================
> --- lib/Sema/SemaDeclCXX.cpp (revision 219190)
> +++ lib/Sema/SemaDeclCXX.cpp (working copy)
> @@ -1917,9 +1917,10 @@
> const Type *T = FD.getType()->getBaseElementTypeUnsafe();
> // FIXME: Destruction of ObjC lifetime types has side-effects.
> if (const CXXRecordDecl *RD = T->getAsCXXRecordDecl())
> - return !RD->isCompleteDefinition() ||
> - !RD->hasTrivialDefaultConstructor() ||
> - !RD->hasTrivialDestructor();
> + return !RD->hasAttr<WarnUnusedAttr>() &&
> + (!RD->isCompleteDefinition() ||
> + !RD->hasTrivialDefaultConstructor() ||
> + !RD->hasTrivialDestructor());
> return false;
> }
>
> @@ -3517,9 +3518,11 @@
> bool addFieldInitializer(CXXCtorInitializer *Init) {
> AllToInit.push_back(Init);
>
> +#if 0
> // Check whether this initializer makes the field "used".
> if (Init->getInit()->HasSideEffects(S.Context))
> S.UnusedPrivateFields.remove(Init->getAnyMember());
> +#endif
>
> return false;
> }
to warn about members of SAL_WARN_UNUSED-annotated class types, and warn about
initializations with side effects (cf.
<http://lists.cs.uiuc.edu/pipermail/cfe-dev/2014-October/039602.html>
"-Wunused-private-field distracted by side effects").
Change-Id: I3f3181c4eb8180ca28e1fa3dffc9dbe1002c6628
2014-10-15 15:58:56 +02:00
..
2014-05-14 10:00:03 +02:00
2014-04-17 11:17:21 +02:00
2014-09-17 21:15:33 +02:00
2014-09-12 16:15:27 +02:00
2014-05-22 23:21:18 +02:00
2014-03-14 07:47:01 +02:00
2014-03-27 18:12:18 +01:00
2014-05-22 23:21:18 +02:00
2014-05-11 10:16:42 +02:00
2014-08-06 13:49:32 +00:00
2014-08-06 13:49:32 +00:00
2014-08-11 16:28:42 +02:00
2014-08-06 13:49:32 +00:00
2014-05-22 23:21:18 +02:00
2014-03-27 18:12:18 +01:00
2014-05-11 10:16:42 +02:00
2014-04-30 12:13:36 +01:00
2014-10-03 15:20:04 +02:00
2014-04-17 11:17:21 +02:00
2014-04-17 11:17:21 +02:00
2014-10-03 15:20:04 +02:00
2014-09-25 08:40:12 +02:00
2014-10-03 15:20:04 +02:00
2014-03-27 18:12:18 +01:00
2014-05-22 23:21:18 +02:00
2014-04-03 13:54:02 +02:00
2014-04-03 13:54:02 +02:00
2014-04-17 11:17:21 +02:00
2014-04-17 11:17:21 +02:00
2014-05-14 10:00:03 +02:00
2014-07-18 15:36:17 +01:00
2014-04-17 11:17:21 +02:00
2014-04-17 11:17:21 +02:00
2014-05-11 01:55:42 +02:00
2014-03-27 18:12:18 +01:00
2014-06-13 17:54:25 +02:00
2014-04-17 11:17:21 +02:00
2014-10-06 12:23:22 +02:00
2014-10-15 15:58:56 +02:00
2014-10-03 15:20:04 +02:00
2014-09-25 08:40:12 +02:00
2014-09-25 08:40:12 +02:00
2014-06-17 10:55:17 +02:00
2014-05-14 10:00:03 +02:00
2014-04-17 11:17:21 +02:00
2014-07-10 11:04:11 +02:00
2014-09-22 10:23:53 +01:00
2014-05-22 23:21:18 +02:00
2014-05-14 10:00:03 +02:00
2014-04-17 11:17:21 +02:00
2014-05-28 23:09:11 +02:00
2014-05-14 10:00:03 +02:00
2014-07-01 16:43:05 +01:00
2014-05-22 23:21:18 +02:00
2014-04-17 11:17:21 +02:00
2014-05-14 10:00:03 +02:00
2014-04-17 11:17:21 +02:00