TL;DR
Now there is only one entity "THEME" the user has to care about when
using the appearance tab page. We ship three default themes which
just change the document colors. Custom themes can customize the UI
too.
We used to have two sections in the appearance tab, the themes dropdown
and the appearance radio buttons group (automatic, light and dark), and
this was really confusing.
Let's say I am a new user, and I go to the appearance tag page I select
the dark radio button, why isn't my application changing to dark mode?
same for light... and then the distinction between application colors
and document colors, the radio buttons were mainly for the docuemnt
appearance, and the themes dropdown was for changing the current theme
which might change the document colors as well.
Now the radio buttons have been merged with the themes dropdown. Now
there are three default themes there, "Automatic", "Light" and "Dark".
These three themes don't define any UI colors and just change the
document colors. If the user installs a new theme, and if that theme
defines UI colors, the UI will also be customized.
Change-Id: If8da6d2f729f117ada07e13b607ed8525395cb6c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184429
Reviewed-by: Sahil Gautam <sahil.gautam.extern@allotropia.de>
Tested-by: Jenkins
Sahil Gautam
b145d0925a