Andras Timar
186ad46f74
During background slide thumbnail rendering, the slide sorter cache can hit a SIGBUS when rendering OLE embedded objects. The crash occurs in EmbeddedObjectContainer::GetEmbeddedObjectName() where the unordered_map<Reference<XEmbeddedObject>, OUString> find operation calls operator== on References, which uses iquery/queryInterface to normalize interface pointers. If any entry in the same hash bucket holds a dangling pointer, the queryInterface dereferences freed memory whose vtable pointer is 0x0, causing SIGBUS. Use the already-available aPersistName to look up the graphic stream directly from container storage, bypassing the dangerous map traversal entirely. Change-Id: I5f99ebfd05c2daf06045c6c7124f4b598cf5f9d6 Reviewed-on: https://gerrit.collaboraoffice.com/c/core/+/758 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins CPCI <releng@collaboraoffice.com> Reviewed-on: https://gerrit.collaboraoffice.com/c/online/+/1441 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit 48e594fa9562451a8f9e0781915581a8b4417253) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/207064 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
Tools on the Top of VCL
Common dialogs, file and print dialogs, wizards, vcl filters, lots of helper code.