Files
odfstudio/writerfilter/source
Justin Luth 520de5a4b2 tdf#95495 writerfilter: clear obsolete hack
This looks completely wrong and unnecessary to me.
HOWEVER, at the time it really fixed a LOT of documents
and bug reports, so definite congratulations to the
original programmers for a successful hack in
a minefield code-area.

But it definitely seems hacky and full of wizardry.
AFTER setting the PROP_OUTLINE_LEVEL to be the real thing,
then we change the placeholder values to something different?
Plus, OutlineLevel has NOTHING to do with a list level,
so it should be irrelevant here.
[There is a fail-safe that ensures that outline level
matches list level for Chapter Numbering, but that is
not a DOCX thing, but a LO thing.]

Other major changes earlier in 7.3 fixed a lot of
inheritance issues, and highly refactored
Chapter Numbering recognition, so it is highly
likely that this code is completely pointless.

-confirm tdf#95495 examples same in Word 2010, 2016, LO
    • Windows PowerShell Language Specification Version 3.0 (confirmed)
    • 95495 Windows PowerShell - APPENDICES (confirmed)
    • 385.docx (comment 12) (confirmed)
    • numbering.docx (confirmed)
    • test1.docx (confirmed)

Change-Id: I0f1ac7c9367b094a6431fe61442d3b58ffee79d5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120755
Tested-by: Justin Luth <justin_luth@sil.org>
Reviewed-by: Justin Luth <justin_luth@sil.org>
2021-08-21 13:29:42 +02:00
..