Caolán McNamara
8749466df2
We have added various workarounds for ScPatternAttr use after free issues since: commit2e1f9da8a6Date: Sat Dec 23 15:52:06 2023 +0100 Decouple ScPatternAttr from SfxItemPool separated ScPatternAttr from SfxItemPool. Prior to that an ScPatternAttr was an SfxPoolItem held in the doc's SfxItemPool which kept every item alive for the document's whole lifetime, so any raw const ScPatternAttr* was basically safe. The various workarounds for the new behaviour were: commit dca19993a4c732e95b9a47e1abdcaad6efbeebe9 Date: Sat Jan 6 14:40:28 2024 +0100 tdf#159042: crash after changing cell style (if direct formatting done) commit 19437715eb415fe2c40b8b40dbe04ddca28f9a35 Date: Thu Sep 12 12:06:28 2024 +0100 null pattern deref seen in ScViewData::SetEditEngine commit e384f2e8de9603ee65a3edc6dcb50b07116ee4fc Date: Mon Mar 10 14:45:22 2025 +0000 crashtesting: crash on reimport of xlsx output of forum-pl-2758.ods commit 7999585bd8378f1a8d04ea2a9a93a8e0bf4d8eb6 Date: Fri May 9 08:50:17 2025 +0100 crash on null pattern de-ref commit1bf9bbea96Date: Tue Oct 28 16:53:49 2025 +0300 tdf#169115: sc: fix use-after-free bug in ScDocument::FillInfo commit 9f366af81478ad218dc2ef2e37423a9ebcc84e73 Date: Sat Apr 25 14:47:02 2026 +0200 ScPatternAttr use-after-free commit 20fe691a18fb35120d0765dd1519acd6d2986c38 Date: Tue Apr 28 08:33:34 2026 +0200 ScPatternAttr use-after-free (2) This commit picks the class member fields that are still raw ScPatternAttr* and converts them to CellAttributeHolder: ScUsedAreaIterator::pPattern and pFoundPattern ScInputHandler::pLastPattern LotAttrCol::ENTRY::pPattAttr ScPatternCache::Entry::pPattern The CalcAll() workaround from 9f366af81478 then doesn't seem to be needed(?) A new compiler plugin catches class member fields of raw type ScPatternAttr pointer. Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com> Change-Id: Ibb9f28b8fcaa5470c7a82eee52900c2d60434e41 Reviewed-on: https://gerrit.collaboraoffice.com/c/online/+/3163 Tested-by: Jenkins CPCI <releng@collaboraoffice.com> Reviewed-by: Noel Grandin <noel.grandin@collabora.com> (cherry picked from commit 9c7b6313a29067bf0eef12884fc3ce7efb0374e5) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/209822 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
Compiler plugins
Overview
This directory contains code for compiler plugins. These are used to perform additional actions during compilation (such as additional warnings) and also to perform mass code refactoring.
Currently only the Clang compiler is supported http://wiki.documentfoundation.org/Development/Clang.
Usage
Compiler plugins are enabled automatically by --enable-dbgutil if Clang headers
are found or explicitly using --enable-compiler-plugins.
Functionality
There are two kinds of plugin actions:
- compile checks - these are run during normal compilation
- rewriters - these must be run manually and modify source files
Each source has a comment saying whether it's compile check or a rewriter and description of functionality.
Compile Checks
Used during normal compilation to perform additional checks. All warnings and errors are marked '[loplugin]' in the message.
Rewriters
Rewriters analyse and possibly modify given source files.
Usage: make COMPILER_PLUGIN_TOOL=<rewriter_name>
Additional optional make arguments:
-
it is possible to also pass
FORCE_COMPILE=allto make to trigger rebuild of all source files, even those that are up to date. FORCE_COMPILE takes a list of gbuild targets specifying where to run the rewriter ('all' means everything, '-' prepended means to not enable, '/' appended means everything in the directory; there is no ordering, more specific overrides more general, and disabling takes precedence). Example: FORCE_COMPILE="all -sw/ -Library_sc" -
UPDATE_FILES=<scope>- limits which modified files will be actually written back with the changesmainfile- only the main.cxxfile will be modified (default)all- all source files involved will be modified (possibly even header files from other LO modules), 3rd party header files are however never modified<module>- only files in the given LO module (toplevel directory) will be modified (including headers)
Modifications will be written directly to the source files.
Some rewriter plugins are dual-mode and can also be used in a non-rewriting mode
in which they emit warnings for problematic code that they would otherwise
automatically rewrite. When any rewriter is enabled explicitly via make COMPILER_PLUGIN_TOOL=<rewriter_name> it works in rewriting mode (and all other
plugins are disabled), but when no rewriter is explicitly enabled (i.e., just
make), all dual-mode rewriters are enabled in non-rewriting mode (along with
all non-rewriter plugins; and all non--dual-mode plugins are disabled). The
typical process to use such a dual-mode rewriter X in rewriting mode is
make COMPILER_PLUGIN_WARNINGS_ONLY=X \
&& make COMPILER_PLUGIN_TOOL=X FORCE_COMPILE=all UPDATE_FILES=all
which first generates a full build without failing due to warnings from plugin
X in non-rewriting mode (in case of --enable-werror) and then repeats the build
in rewriting mode (during which no object files are generate).