Files
odfstudio/registry
Noel Grandin bb209f2f53 Revert "clang bugprone-unused-return-value"
comment from sberg:
  aren't these changes broken in general, when the called function
  may throw an exception before it takes ownership of the passed-in pointer?

So revert, except for
  (a) PlainTextFilterDetect::detect, which was definitely a leak
  (b) SwCursor::FindAll, where unique_ptr was being unnecessarily used

This reverts commit 7764ae70b0.

Change-Id: I555e651b44e245b031729013d2ce88d26e8a357e
Reviewed-on: https://gerrit.libreoffice.org/60301
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-11 15:18:26 +02:00
..
2018-07-30 16:26:31 +02:00
…
…

Registry reading, etc.

This provides tools for dealing with the legacy binary types database
format, still in use by extensions and the core code. While the actual
binary file format is implemented by the [[store]] code, the wrapper
that turns this into a type registry is implemented here.

While this code is primarily used in only two modes:

* linear write / concatenate
* random access read

The API unfortunately exposes a random-access write approach, which -
while ~unused needs before we can re-write this away from the store
backend.