Files
odfstudio/svx/source/sdr/properties/groupproperties.cxx
T
Armin Le Grand (collabora) 5519a3d407 Correct StyleSheet handling when cloning to different Model II
Until now the 'local' StyleSheet got set, but that may
not be the same as the original. It was/gets identified just
by searching by name and type, not comparing content.

What to do? We could...

(a) the Style-Friendly way:
 - check if StyleSheet is identical
  - if not, create a new in-between StyleSheet hosting missing Items
  - if yes, use, done.

(b) the pragmatic/practical way:
 - Just hard-attribute the Items that are detected as different
   similar to what BurnInStyleSheetAttributes does/did, but only
   for a view differing Items

(b) is the most simple for now, but will lead to more hard
attributes. The other possibilities will be better in the
long term. For now, I will use (b).

Note that there are more cases in that VERY complex and grown
stuff emerging from SdDrawDocument::PasteBookmarkAsPage. More
things will need to be fixed, see this as a 1st step.

Needed to adapt postProcessAfterCloneToDifferentModel due to
UT testTdf96206 failing, see comment there for details.

That 1st implementation showed weaknesses with those Items
critical and only on MasterPages, so decided to give up on
that and implement ContentCompare to SdPage::Equals. That
was easier than thought: No parameter needed, only used by
InsertBookmarkAsPage_FindDuplicateLayouts::operator(). Thus,
SdPage::Equals needs no change, just SdrObject::Equals.

Due to still problems with Items corrected in Objects on
MasterPages I will for now exclude this.

Could now isolate remaining problems, these are defaults
and/or PresObj things on MasterPages. Important is that I can
completely correct all Items for all Objects in
postProcessAfterCloneToDifferentModel. I can react to these
false-positives in the ContentCompare in SdrObject::Equals.

Signed-off-by: Armin Le Grand (collabora) <Armin.LeGrand@collabora.com>
Change-Id: I10e17c8d6a893dbe92ab716182f07bafce1f3284
Reviewed-on: https://gerrit.collaboraoffice.com/c/online/+/6595
Tested-by: Jenkins CPCI <releng@collaboraoffice.com>
Reviewed-by: Armin Le Grand <armin.legrand@collabora.com>
(cherry picked from commit 92ffaeac04c5c8586006b026f29ce12fba3674f1)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/211729
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2026-10-05 08:52:54 +02:00

219 lines
8.2 KiB
C++

/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
/*
* This file is part of the LibreOffice project.
*
* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
*
* This file incorporates work covered by the following license notice:
*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed
* with this work for additional information regarding copyright
* ownership. The ASF licenses this file to you under the Apache
* License, Version 2.0 (the "License"); you may not use this file
* except in compliance with the License. You may obtain a copy of
* the License at http://www.apache.org/licenses/LICENSE-2.0 .
*/
#include <sal/config.h>
#include <sdr/properties/groupproperties.hxx>
#include <svl/itemset.hxx>
#include <svl/itemiter.hxx>
#include <svx/svdogrp.hxx>
#include <svx/svdpage.hxx>
#include <osl/diagnose.h>
namespace sdr::properties
{
GroupProperties::GroupProperties(SdrObject& rObj)
: BaseProperties(rObj)
{
}
GroupProperties::~GroupProperties()
{
}
std::unique_ptr<BaseProperties> GroupProperties::implCloneProperties(SdrObject& rObj) const
{
return std::unique_ptr<BaseProperties>(new GroupProperties(rObj));
}
SfxItemSet GroupProperties::CreateObjectSpecificItemSet(SfxItemPool& rPool)
{
return SfxItemSet(rPool);
}
const SfxItemSet& GroupProperties::GetObjectItemSet() const
{
assert(!"GroupProperties::GetObjectItemSet() should never be called");
abort();
}
const SfxItemSet& GroupProperties::GetMergedItemSet() const
{
// prepare ItemSet
if(moMergedItemSet)
// clear local itemset for merge
moMergedItemSet->ClearItem();
else if(!moMergedItemSet)
// force local itemset
moMergedItemSet.emplace(GetSdrObject().GetObjectItemPool());
// collect all ItemSets in mpItemSet
const SdrObjList* pSub(static_cast<const SdrObjGroup&>(GetSdrObject()).GetSubList());
OSL_ENSURE(nullptr != pSub, "Children of SdrObject expected (!)");
if (!pSub)
return *moMergedItemSet;
for (const rtl::Reference<SdrObject>& pObj : *pSub)
{
const SfxItemSet& rSet = pObj->GetMergedItemSet();
for (SfxItemIter aIter(rSet); !aIter.IsAtEnd(); aIter.Next())
{
const SfxPoolItem *pItem = aIter.GetCurItem();
if(IsInvalidItem(pItem))
{
moMergedItemSet->InvalidateItem(aIter.GetCurWhich());
}
else
{
moMergedItemSet->MergeValue(rSet.Get(aIter.GetCurWhich()));
}
}
}
// For group properties, do not call parent since groups do
// not have local ItemSets.
return *moMergedItemSet;
}
void GroupProperties::SetMergedItemSet(const SfxItemSet& rSet, bool bClearAllItems, bool bAdjustTextFrameWidthAndHeight)
{
// iterate over contained SdrObjects
const SdrObjList* pSub(static_cast<const SdrObjGroup&>(GetSdrObject()).GetSubList());
OSL_ENSURE(nullptr != pSub, "Children of SdrObject expected (!)");
if (!pSub)
return;
for (const rtl::Reference<SdrObject>& pObj : *pSub)
// Set merged ItemSet at contained object
pObj->SetMergedItemSet(rSet, bClearAllItems, bAdjustTextFrameWidthAndHeight);
// Do not call parent here. Group objects do not have local ItemSets
// where items need to be set.
}
void GroupProperties::SetObjectItem(const SfxPoolItem& /*rItem*/)
{
assert(!"GroupProperties::SetObjectItem() should never be called");
}
void GroupProperties::SetObjectItemDirect(const SfxPoolItem& /*rItem*/)
{
assert(!"GroupProperties::SetObjectItemDirect() should never be called");
}
void GroupProperties::ClearObjectItem(const sal_uInt16 nWhich)
{
// iterate over contained SdrObjects
const SdrObjList* pSub(static_cast<const SdrObjGroup&>(GetSdrObject()).GetSubList());
OSL_ENSURE(nullptr != pSub, "Children of SdrObject expected (!)");
if (!pSub)
return;
for (const rtl::Reference<SdrObject>& pObj : *pSub)
pObj->GetProperties().ClearObjectItem(nWhich);
}
void GroupProperties::ClearObjectItemDirect(const sal_uInt16 /*nWhich*/)
{
assert(!"GroupProperties::ClearObjectItemDirect() should never be called");
}
void GroupProperties::SetMergedItem(const SfxPoolItem& rItem)
{
const SdrObjList* pSub(static_cast<const SdrObjGroup&>(GetSdrObject()).GetSubList());
OSL_ENSURE(nullptr != pSub, "Children of SdrObject expected (!)");
if (!pSub)
return;
for (const rtl::Reference<SdrObject>& pObj : *pSub)
pObj->GetProperties().SetMergedItem(rItem);
}
void GroupProperties::ClearMergedItem(const sal_uInt16 nWhich)
{
const SdrObjList* pSub(static_cast<const SdrObjGroup&>(GetSdrObject()).GetSubList());
OSL_ENSURE(nullptr != pSub, "Children of SdrObject expected (!)");
if (!pSub)
return;
for (const rtl::Reference<SdrObject>& pObj : *pSub)
pObj->GetProperties().ClearMergedItem(nWhich);
}
void GroupProperties::SetObjectItemSet(const SfxItemSet& /*rSet*/, bool /*bAdjustTextFrameWidthAndHeight*/)
{
assert(!"GroupProperties::SetObjectItemSet() should never be called");
}
SfxStyleSheet* GroupProperties::GetStyleSheet() const
{
SfxStyleSheet* pRetval = nullptr;
const SdrObjList* pSub(static_cast<const SdrObjGroup&>(GetSdrObject()).GetSubList());
OSL_ENSURE(nullptr != pSub, "Children of SdrObject expected (!)");
if (!pSub)
return pRetval;
for (const rtl::Reference<SdrObject>& pObj : *pSub)
{
SfxStyleSheet* pCandidate = pObj->GetStyleSheet();
if(pRetval)
{
if(pCandidate != pRetval)
{
// different StyleSheets, return none
return nullptr;
}
}
else
{
pRetval = pCandidate;
}
}
return pRetval;
}
void GroupProperties::SetStyleSheet(SfxStyleSheet* pNewStyleSheet, bool bDontRemoveHardAttr,
bool bBroadcast, bool bAdjustTextFrameWidthAndHeight)
{
const SdrObjList* pSub(static_cast<const SdrObjGroup&>(GetSdrObject()).GetSubList());
OSL_ENSURE(nullptr != pSub, "Children of SdrObject expected (!)");
if (!pSub)
return;
for (const rtl::Reference<SdrObject>& pObj : *pSub)
{
if(bBroadcast)
pObj->SetStyleSheet(pNewStyleSheet, bDontRemoveHardAttr);
else
pObj->NbcSetStyleSheet(pNewStyleSheet, bDontRemoveHardAttr, bAdjustTextFrameWidthAndHeight);
}
}
void GroupProperties::ForceStyleToHardAttributes()
{
const SdrObjList* pSub(static_cast<const SdrObjGroup&>(GetSdrObject()).GetSubList());
OSL_ENSURE(nullptr != pSub, "Children of SdrObject expected (!)");
if (!pSub)
return;
for (const rtl::Reference<SdrObject>& pObj : *pSub)
pObj->GetProperties().ForceStyleToHardAttributes();
}
} // end of namespace
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */