Since
commit f075fa01cb
Author: Michael Weghorn <m.weghorn@posteo.de>
Date: Tue Aug 22 10:26:32 2023 +0200
tdf#141101 tdf#101886 a11y: Restore previous focus on col/line popup close
, the menu button toggled handler is no more called before
the menu shows.
`SvxLineTabPage` was relying on the old behavior and
only populating the menu entries in the handler,
resulting in them not being present any more the
first time the menu gets opened after the above
commit.
Populate the menu items when the tab page gets created
instead, by changing the handler to a regular method
`SvxLineTabPage::PopulateMenus` that gets called
from `SvxLineTabPage::Construct` (which already takes
care of updating the list boxes in the tab page).
Move the call to `SvxLineTabPage::Construct` to the
end of `SvxLineTabPage::PageCreated`, as
`SvxLineTabPage::PopulateMenus` makes use of
`m_pSymbolList` and `m_xSymbolAttr` that were previously
only set after the call to `SvxLineTabPage::Construct`.
Change-Id: I521a50f3a3695f20f789add89ffd88749e3b5cd2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172472
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Common User Interface (cui)
It was moved out from svx in DEV300m68:
http://www.mail-archive.com/dev@openoffice.org/msg12925.html
It contains dialogs used by more than one application, e.g. paragraph properties.