So far, ChartTypeDialogController::fillSubTypeList (and its overrides) was clearing all existing entries of the passed ValueSet widget and inserting items for the chart types it handles. Change the logic to return a vector of entries for the corresponding chart types instead and let the callers handle clearing the ValueSet and inserting the entries instead. This way, the ChartTypeDialogControllers don't have to know/rely on the implementation detail what exact widget is used to display the chart types. This can simplify porting away from the use of the custom ValueSet widget in the future, e.g. to weld::IconView. Change-Id: I98b32dee7d67b2a9e8c8474c464cacebb21b717e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/211557 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Chart Implementation for LibreOffice Calc
The chart2 denotes a second generation re-write done to rid us of the
foul and twisted legacy chart code.
Debugging
Shortcuts
CTRL + F12 creates a layout dump based on the XShapeDumper based on SAL_WARN("chart2", ...