Armin Le Grand (collabora)
14312e4eb8
Whatever SdDrawDocument::renameObjectStylesIfNeeded is intended to do, it changes the look of SdrObjects when doing what it does. I am not sure if these are just the 'wrong' StyleSheets that got copied or something else. It may happen when slides from more than two sources get copied to a document: The newly imported styles get 'extended' names following a naming scheme. When pasting from a 2nd document, the *same* names for slides get created using that naming scheme, so before these were re-used here assuming they have the same content - which is wrong. To just *ensure* that the objects look will not change, compare previous ItemValues with those ItemValues after changing the style, that guarantees equal look - for the cost of some more hard-set attributes, but less StyleSheets. I see that these corrections *are* done, so that is a clear hint that re-setting these Styles in this whole import has basic errors, I have to correct the values. Also use a SdrObjListIter, the version before *only* visited all SdrObjects plain on SdrPage, leaving all GroupContent out. Signed-off-by: Armin Le Grand (collabora) <Armin.LeGrand@collabora.com> Change-Id: I0cf1f823bddcea0b0087244268d1dc224da39638 Reviewed-on: https://gerrit.collaboraoffice.com/c/online/+/6449 Reviewed-by: Armin Le Grand <armin.legrand@collabora.com> Tested-by: Jenkins CPCI <releng@collaboraoffice.com> (cherry picked from commit 605790cb198686d382c809de949094755e70e833) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/208432 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
LibreOffice Impress / Draw Application
The core directory for the impress/draw applications.
Think of impress as a hack on top of draw.
sd module contains impress/draw specific code, non-shared UI and part
of ppt and pptx filter, few other filters too.
the slideshow UI lives here as well, the slideshow engine is in
slideshow module though (including the 3D transitions engine
slideshow/source/engine/opengl).
the most used filters are ODF's odp, binary ppt and OOXML's
pptx. their locations are listed below:
-
odpimport and export filters are inxmloffmodule (mostlyxmloff/source/draw) -
pptimport is insd/source/filter/ppt(big shared chunks are also insvx) -
pptexport is insd/source/filter/eppt(big shared chunks are also insvx) -
pptximport is inoox/source/ppt(and uses a lot ofoox/source/drawingmlandoox/source/*) -
pptxexport is insd/source/filter/eppt(mostly inpptx-*source files) and shared part is inoox/source/export
PPTX Export / Import Filters
PPTX export filter is split into 2 parts. Impress related part is in
sd/source/filter/eppt/pptx-* and the other part is in
oox/source/export/ because it contains mostly code related to
DrawingML, which is shared with writer and calc ooxml export.
The export filter was written in 2009 IIRC and was not much extended feature-wise lately.
Presenter Console
The main screen uses a hardware-accelerated
canvas (e.g. cairo canvas), while the entire secondary screen
uses a VCL-canvas that is created in
sd::framework::FullScreenPane::CreateCanvas().
The secondary screen contains 3 Panes which each have
2 XWindows for the border area & the actual content,
and each content Pane is backed by a sd::presenter::PresenterCanvas
that wraps the FullScreenPane's canvas and does clipping.
Future Works
Add custom shapes export (see below). enhance text
output, we don't write text style for indentation levels now, need to
export a:lvl1pPr, a:lvl2pPr, ... elements.
PPTX import was written by Sun/Oracle and then extended in LibreOffice
a lot during bug fixing. It is located in oox/source/ppt and
oox/source/drawingml. The areas with most bugs (at least until today)
were shape placeholders and text style inheritance.