Mike Kaganski
374dd9fbd6
We used to have two duplicating sets: smart pointer-like VclPtr::reset, and Reference-style VclPtr::set / VclPtr::clear. There is no need in this duplication. Further, in ScopedVclPtr, reset is hidden / removed to avoid skipping disposeAndClear; but the twin functions are kept accessible, possibly as an overlook. This change drops Reference-style VclPtr::set / VclPtr::clear, and unifies on VclPtr::reset, which looks more consistent with the class nature (it is closer to shared_ptr, than to uno::Reference). Doing that uncovered one place, where a ScopedVclPtr was used incorrectly: clear() was used for NotebookbarPopup::m_pParent in NotebookbarPopup dtor. I assume then, that the correct class needed here is VclPtr. Change-Id: I0746075c58d793fabdce1bc357afea8ee455cd8a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185553 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
BASIC IDE Controls and Dialogs
Controls and dialogs for BASIC. Contains the BASIC IDE.