odfstudio

Files

T

History

Caolán McNamara 54c0ec8700 SdrEscherImport::RecolorGraphic reads but doesn't use FillColors

it never did, but at:

commit 025bfa7e51
Date:   Thu Apr 23 10:03:58 2015 +0100

    cppcheck: unreadVariable

the wrong choice was made wrt the dead store, the dead loop should have
been fixed rather than let the unused fill colors accumulate in the
globalcolors buffer.

This function doesn't need to consume the unused data, all callers don't
expect the entire record to be read so just drop the loop.

Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I02bce4dd78dc566f18edc3d45603534c3f724cc3
Reviewed-on: https://gerrit.collaboraoffice.com/c/online/+/1689
(cherry picked from commit 07faeadace3d8d93225f9dd72c4f911e331070e2)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205089
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
(cherry picked from commit 9ba100c0d2)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205097

2026-05-12 13:24:37 +02:00

config

tdf#170261: dotx 2007 is no longer the preferred template.

2026-01-10 02:42:25 +01:00

docbook

tdf#163102 Replace DocBookTemplate.stw by build-in...

2024-12-01 12:30:30 +01:00

graphic

BitmapEx->Bitmap in various

2025-08-25 12:59:18 +02:00

graphicfilter/icgm

early return on too many points