Jonathan Clark
742ca7e4f4
comphelper::string::replaceAt contained pointer arithmetic errors. In
testing, this function only worked at all in the trivial append case.
Inserting a non-empty string anywhere else in the buffer would either
only insert part of the string, corrupt the string in the buffer, or
both.
In addition to replacing the implementation, this change adds unit tests
so we can be more confident that this function works in the future.
Change-Id: I97e109dc513b08528d6d20e7dbf6eedb3040670c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205222
Tested-by: Jenkins
Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
(cherry picked from commit b19cc5a5d1)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205269
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Helpers for Implementing UNO Components
Here goes anything not generic / mature enough to end up in URE's stable interface
at cppuhelper, etc.