Dmitry Kulikov
23b745e20d
A Word comment whose w:commentReference sits inside <m:oMath> was lost on DOCX import: OOXMLFastContextHandlerLinear/Math buffers every child of the formula and never routes commentReference to handleComment, so comments.xml was never resolved and no annotation was created. Intercept w:commentReference in OOXMLFastContextHandlerLinear: collect its id and resolve it via the existing resolveComment() path once the formula object has been emitted (in OOXMLFastContextHandlerMath::process). The tag is never buffered into the formula, so the Starmath buffer stays balanced and formula import is unaffected. Signed-off-by: Dmitry Kulikov <dkul@altlinux.org> Change-Id: I9b0dccc79d5a7da9294b18f0cb58776a2bd8b553 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/207888 Tested-by: Jenkins Reviewed-by: Dan Williams <dcbw@libreoffice.org>
You can find different types of Writer tests here, the following directories
are available:
- core:
- filters-test: loads different file types (see SwFiltersTest::testCVEs() for
the list of supported filter types), and only makes sure Writer does not
crash. To add new tests, you just need to drop in the test files to the
relevant directory, no code change is necessary.
- uwriter: this test has access to private Writer symbols, add new tests here
if you need that.
- extras:
- see its own README -- executes import and export filters and asserts the
UNO model to verify the resulting document is the expected one.
- also, any new C++ test that links to libsw (but does not need access to
private Writer symbols) should go in this directory, whether using the UNO
API or the internal one.
- complex: JUnit-based tests using the UNO API
- unoapi: JUnit-based test trying to get/set every UNO property, etc.