Files
odfstudio/sw/CppunitTest_sw_xsltimport.mk
Ujjawal Kumar b43eb71a3c oox: only write showLeaderLines in dLbls for pie and doughnut charts
The OOXML standard defines <c:showLeaderLines> and <c:leaderLines>
as valid children of <c:dLbls> only for pie and doughnut chart types.
The export code wrote these elements unconditionally for all chart
types, including bar charts. Excel crashes when it encounters these
elements inside a barChart series dLbls.

For non-pie/doughnut charts, the c15:showLeaderLines extension
(from the Office 2013 chart extensions namespace) is the correct
mechanism to express leader lines. The code already had logic to
write this extension for non-pie charts, but it was written in
addition to the invalid standard elements rather than instead of
them.

Fix by guarding <c:showLeaderLines> and <c:leaderLines> behind a
pie/doughnut check, and writing only the c15 extension for all
other chart types.

Change-Id: I652927b8d29de159a3bda10461bc220affe93dd9
Reviewed-on: https://gerrit.collaboraoffice.com/c/core/+/778
Reviewed-by: Noel Grandin <noel.grandin@collabora.com>
Tested-by: Jenkins CPCI <releng@collaboraoffice.com>
(cherry picked from commit 9a52b0c1633108022e58605f6732ad81160a9bb1)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/204677
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2026-05-04 09:38:17 +02:00

66 lines
1.5 KiB
Makefile

# -*- Mode: makefile-gmake; tab-width: 4; indent-tabs-mode: t; fill-column: 100 -*-
#
# This file is part of the LibreOffice project.
#
# This Source Code Form is subject to the terms of the Mozilla Public
# License, v. 2.0. If a copy of the MPL was not distributed with this
# file, You can obtain one at http://mozilla.org/MPL/2.0/.
#
$(eval $(call gb_CppunitTest_CppunitTest,sw_xsltimport))
$(eval $(call gb_CppunitTest_use_common_precompiled_header,sw_xsltimport))
$(eval $(call gb_CppunitTest_add_exception_objects,sw_xsltimport, \
sw/qa/extras/xsltimport/xsltimport \
))
$(eval $(call gb_CppunitTest_use_libraries,sw_xsltimport, \
comphelper \
cppu \
cppuhelper \
i18nlangtag \
sal \
sfx \
subsequenttest \
sw \
swqahelper \
test \
tl \
unotest \
utl \
vcl \
))
$(eval $(call gb_CppunitTest_use_externals,sw_xsltimport,\
boost_headers \
libxml2 \
))
$(eval $(call gb_CppunitTest_set_include,sw_xsltimport,\
-I$(SRCDIR)/sw/inc \
-I$(SRCDIR)/sw/source/core/inc \
-I$(SRCDIR)/sw/source/uibase/inc \
-I$(SRCDIR)/sw/qa/inc \
$$(INCLUDE) \
))
$(eval $(call gb_CppunitTest_use_api,sw_xsltimport,\
udkapi \
offapi \
oovbaapi \
))
$(eval $(call gb_CppunitTest_use_ure,sw_xsltimport))
$(eval $(call gb_CppunitTest_use_vcl,sw_xsltimport))
$(eval $(call gb_CppunitTest_use_rdb,sw_xsltimport,services))
$(eval $(call gb_CppunitTest_use_configuration,sw_xsltimport))
$(eval $(call gb_CppunitTest_use_packages,sw_xsltimport,\
filter_xslt \
))
# vim: set noet sw=4 ts=4: